From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Xiaojun Liu <xiaojun.liu@silicom.co.il>
Cc: xiao.w.wang@intel.com, qi.z.zhang@intel.com,
ngai-mint.kwan@intel.com, jacob.e.keller@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support
Date: Mon, 20 Apr 2020 13:09:50 +0800 [thread overview]
Message-ID: <20200420050950.GB33101@intel.com> (raw)
In-Reply-To: <1586413588-5759-6-git-send-email-xiaojun.liu@silicom.co.il>
Hi, Xiaojun
On 04/09, Xiaojun Liu wrote:
>Split dev init to 2 parts.
>First only register the port in switch
>management; second init hook will be
>called after all the pf are registered
>and switch initialization. It will finish
>dev init. Also add switch interrupt support.
>Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset
>to support mirror operation. Add fm10k_dev_filter_ctrl
>to support flow operation.
>Add dpdk port and pf mapping, so
>the dpdk port can map to a specific pf
>and 1 dpdk port can map to 2 pf to get
>total 100G throughput. Update fm10k.rst.
>Update release_20_05.rst.
>
Could you wrap the commit message within 72 chars, the format looks weird now.
And could you please improve it to be more descriptive, something like:
This patch splits dev init to 2 parts, the first part registers the port
in switch management, the second is init hook which will be called after
all the PF are registered and switch initialization. This patch also adds
switch interrupt/mirror support and adds dpdk port and pf mapping, so the
dpdk port can map to a specific pf and 1 dpdk port can map to 2 pf to get
total 100G throughput. Document update and release notes update are also
covered in this patch.
And some comments for other patches in this series.
Thanks,
Xiaolong
next prev parent reply other threads:[~2020-04-20 5:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1584687199-19198-1-git-send-email-xiaojun.liu@silicom.co.il>
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 0/5] support fm10k switch management Xiaojun Liu
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-04-17 13:56 ` Ferruh Yigit
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-04-17 13:57 ` Ferruh Yigit
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-04-20 5:09 ` Ye Xiaolong [this message]
2020-04-16 8:33 ` [dpdk-dev] [PATCH v4 0/5] support fm10k switch management Wang, Xiao W
2020-04-17 4:02 ` Ye Xiaolong
2020-04-17 14:18 ` Ferruh Yigit
2020-04-20 4:55 ` Ye Xiaolong
2020-04-20 6:37 ` Xiaojun Liu
2020-04-20 8:14 ` Ye Xiaolong
2020-04-20 8:24 ` Xiaojun Liu
2020-04-20 13:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420050950.GB33101@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=jacob.e.keller@intel.com \
--cc=ngai-mint.kwan@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaojun.liu@silicom.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).