From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94F5CA0561; Mon, 20 Apr 2020 07:14:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F7291C21A; Mon, 20 Apr 2020 07:14:11 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 12CA71C219 for ; Mon, 20 Apr 2020 07:14:09 +0200 (CEST) IronPort-SDR: 2hTsxaa4M6kYSIC/67XSBMVIcXvaj31hThty3a0xsVQmn8diKj+h13B2IA0FyfPosXDiFuaf2t djVc5hZrncgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2020 22:14:09 -0700 IronPort-SDR: pWHJSMYSfx0bzXeb3VI78NbtuU/N3roqsX4U1fUDEVmFGz2zBbLaQ0d1mN9IRf5CjHh3y1SiNy h0mauQ57xDCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,405,1580803200"; d="scan'208";a="455562757" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga005.fm.intel.com with ESMTP; 19 Apr 2020 22:14:07 -0700 Date: Mon, 20 Apr 2020 13:09:50 +0800 From: Ye Xiaolong To: Xiaojun Liu Cc: xiao.w.wang@intel.com, qi.z.zhang@intel.com, ngai-mint.kwan@intel.com, jacob.e.keller@intel.com, dev@dpdk.org Message-ID: <20200420050950.GB33101@intel.com> References: <1584687199-19198-1-git-send-email-xiaojun.liu@silicom.co.il> <1586413588-5759-1-git-send-email-xiaojun.liu@silicom.co.il> <1586413588-5759-6-git-send-email-xiaojun.liu@silicom.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1586413588-5759-6-git-send-email-xiaojun.liu@silicom.co.il> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaojun On 04/09, Xiaojun Liu wrote: >Split dev init to 2 parts. >First only register the port in switch >management; second init hook will be >called after all the pf are registered >and switch initialization. It will finish >dev init. Also add switch interrupt support. >Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset >to support mirror operation. Add fm10k_dev_filter_ctrl >to support flow operation. >Add dpdk port and pf mapping, so >the dpdk port can map to a specific pf >and 1 dpdk port can map to 2 pf to get >total 100G throughput. Update fm10k.rst. >Update release_20_05.rst. > Could you wrap the commit message within 72 chars, the format looks weird now. And could you please improve it to be more descriptive, something like: This patch splits dev init to 2 parts, the first part registers the port in switch management, the second is init hook which will be called after all the PF are registered and switch initialization. This patch also adds switch interrupt/mirror support and adds dpdk port and pf mapping, so the dpdk port can map to a specific pf and 1 dpdk port can map to 2 pf to get total 100G throughput. Document update and release notes update are also covered in this patch. And some comments for other patches in this series. Thanks, Xiaolong