From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0832BA0588; Tue, 21 Apr 2020 11:58:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E62D1D927; Tue, 21 Apr 2020 11:58:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 039511D6EE for ; Tue, 21 Apr 2020 11:58:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03L9pSvJ008924; Tue, 21 Apr 2020 02:58:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=LOP0+SF5O1aOsvUCx8HeB9cSRJIg9B/dW+yBszfYTro=; b=gZeMxQxUmf/RpaHsZm25YyseJNME9NQ+yiURh84ZRSjokc4oxGY48bML7qJ0bD0Cp6ay f8S3YkwoOHCpHhpzWCHmiSYIHgOh8MsuqWXRdXBtnzImn0wypbtrBQomePqf2AB1Fpb3 tVDpLX2tpQi7gCObbNQunAHYvgrYOqP0iBKNRcCsU639T2g/nQEVKoQMHFLl36+cRDdj 4UdiC2j5ty+FjvWvfi37Wxu3zl/1k1t4iRXMWj/mTRfeKz8qbZ4FrmocDUIVKiwD/2Dj m//nFEX2CMJpK4892AEq5ar+tdoRzHTkPuYjDnG4a/J66vMiF8flvS6bTwBUOxdzq241 CQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 30fxwpbqu4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 21 Apr 2020 02:58:32 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 21 Apr 2020 02:58:31 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 21 Apr 2020 02:58:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaXrPH+fF5KM//6RfdF5yFabdYl1lTmixestEsyR5e/rahF/6Jnn6wl2zoud6HacXAtvHRXIxJk7RDALZNL/0npkQkTkS/BSVcrQBPWHxmfG4Lp+7onMO6nHBQKB6VbR4kS83S3qzuZiyFw/Mpw633DmUlwW7lsKhnnS8vqmAv9gvta+Ics2iUs4+PxQH/sF+s2mrYyJ/2ry7w5oUB/5E8awnjhF7HcF3H6cNhYBHRRLi5W8MvHylZrDx2n2LfzZ2bngt0rICTN4UgkofhAci9zJ3nqrUGd37iuHpOHy/3CLw0NRTl2nbMmG7vrtGBWkAL0IJ5ErqyXKt/xxelboVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOP0+SF5O1aOsvUCx8HeB9cSRJIg9B/dW+yBszfYTro=; b=GR4DAsBkNhvt0b6A7dTuSIspebCg521vVPtCSa2dOO6IjMn/Fx4OpDeLygxV7vVLmRW2QtU7hEkM0Xdobdvkt+0hv7grMviV/dh1JqPx39SDAMPNDUH+lPEw3rx7SX5KDW2QFM1LHkIwa/ooUKiU9Q4Fj0ZC79OcWNXy93v3AuEGUCbmk8fuDoBgoyJPdr1wWhNp3EHJ88FLc7CXr2Hd1t+EZOrEQYZW3HPtTxZSp31rbVD6XrM/yHFrcZSfgil3F5sMxljdtPLWWTaBGN/QE/HVw8whqzTADy2PSzolCdTlyeDq6tYot176kZxzaAWv9aIGauW1nKHMvAgrKDnOCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOP0+SF5O1aOsvUCx8HeB9cSRJIg9B/dW+yBszfYTro=; b=pmxLD4DcMo0aO5iZKTrd9dRtL6CURXBrSAoPf+d6/kalmN6LSnWeGGVXUSpd20YLntYaoN7dLz2a+JZKYgxUoX+67HjN5kU5mR7EgGcpTXXJfj9oZSanZuGRhSDuRCa2kTJ4a4Jhp/S0S8ZamwGVfdbfPA5cK2UGwTE8AQGEzz0= Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2856.namprd18.prod.outlook.com (2603:10b6:a03:10e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 09:58:28 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 09:58:28 +0000 Date: Tue, 21 Apr 2020 15:28:13 +0530 From: Nithin Dabilpuram To: "Dumitrescu, Cristian" CC: Nithin Dabilpuram , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" Message-ID: <20200421095813.GA2740@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200411114430.18506-1-nithind1988@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BM1PR01CA0137.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::31) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BM1PR01CA0137.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Tue, 21 Apr 2020 09:58:25 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7b75aec-eefd-4cf5-db25-08d7e5da8a6a X-MS-TrafficTypeDiagnostic: BYAPR18MB2856: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 038002787A X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(52116002)(6666004)(33656002)(7696005)(66946007)(1076003)(2906002)(956004)(66476007)(66556008)(4326008)(107886003)(6916009)(5660300002)(30864003)(186003)(316002)(26005)(8676002)(16526019)(86362001)(54906003)(9686003)(55016002)(478600001)(53546011)(6506007)(81156014)(55236004)(8936002)(290074003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R8vJ4ZKq9Im/kHoKjBvhNlsKZxGpofdt8wxqAkJkBqaiEpoO6e0oaZRa38Na8IU4QXYgnoduZOhpDmsanykhldCB88hnlrRTsRSufz1mEVb4zRTmEAMH0vDgHuHgOJmw/KKRqhTBbUISuFpeC2Z0JyGAa8lrAN9pHkTpGngr+L7Ra4EesDFOIfDvEGV5XFLveCJ6ZsooNua0dCgBFCEvVaUqghDG2ktjD2dUK+X0wwb+U90CYIfnY0RZ0xUTV3nQdpQQ2ebHVAK85nm8NC2iWILkP/icVVNIBBF3FXjby2+PPf5QwRuXYp98BqLI83Vm+hH2XFvB7arfO3Q9BMvRmkTHp+JgbhV5M5HgH30+92eacqyCSYmZBzBcD+Ve7c7sGEW+NPH73GVObPZ88QfhWvjjuHQmjSbyTlYMqAjjbceXwt9otJkYGb1bT7+FTyy8uCB9q4EFLUxW4jv89wPWA01IP2qrFVC0lxLRPrOALCt3IkUwpn76B7l5B/DPH85K X-MS-Exchange-AntiSpam-MessageData: uPxR6Dk7BoHkqFx6hbF6DXG4Pc2N05df49JsxiWUcw5AWsCogeJJWWX+EHj3WESl36hQJN4/02Q5ML269Ipdvy/RRNe7wG2iJ9shz/SPzvrYX5eH0kRyxJT/WlrFyM91c81zfIoQNIu+6ys26aP4pA== X-MS-Exchange-CrossTenant-Network-Message-Id: a7b75aec-eefd-4cf5-db25-08d7e5da8a6a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2020 09:58:28.8442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1CwetcFtiuGVOXWOSKRkq6qnDOgB5Hj5KGJlfvawi+7R/5YIYQjkLi4foSH+9fnv7sWLWxbmVVBGpSU3SV3qdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2856 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-21_03:2020-04-20, 2020-04-21 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Cristian, On Tue, Apr 21, 2020 at 09:30:55AM +0000, Dumitrescu, Cristian wrote: > Hi Nithin, > > > -----Original Message----- > > From: Nithin Dabilpuram > > Sent: Saturday, April 11, 2020 12:44 PM > > To: Dumitrescu, Cristian ; Thomas Monjalon > > ; Yigit, Ferruh ; Andrew > > Rybchenko > > Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > > Dabilpuram > > Subject: [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt > > mode > > > > From: Nithin Dabilpuram > > > > Some NIC hardware support shaper to work in packet mode i.e > > shaping or ratelimiting traffic is in packets per second (PPS) as > > opposed to default bytes per second (BPS). Hence this patch > > adds support to configure shared or private shaper in packet mode, > > provide rate in PPS and add related tm capabilities in port/level/node > > capability structures. > > > > This patch also updates tm port/level/node capability structures with > > exiting features of scheduler wfq packet mode, scheduler wfq byte mode > > and private/shared shaper byte mode. > > > > Signed-off-by: Nithin Dabilpuram > > --- > > > > v1..v2: > > - Add seperate capability for shaper and scheduler pktmode and bytemode. > > - Add packet_mode field in struct rte_tm_shaper_params to indicate > > packet mode shaper profile. > > > > lib/librte_ethdev/rte_tm.h | 156 > > ++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 154 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h > > index f9c0cf3..38fff4c 100644 > > --- a/lib/librte_ethdev/rte_tm.h > > +++ b/lib/librte_ethdev/rte_tm.h > > @@ -250,6 +250,23 @@ struct rte_tm_capabilities { > > */ > > uint64_t shaper_private_rate_max; > > > > + /** Shaper private packet mode supported. When non-zero, this > > parameter > > + * indicates that there is atleast one node that can be configured > > Typo (please fix all occurrences): atleast -> at least Ack. > > > + * with packet mode in it's private shaper. When shaper is configured > > Typo (please fix all occurrences): it's -> its Ack. > > > + * in packet mode, committed/peak rate provided is interpreted > > + * in packets per second. > > + */ > > + int shaper_private_packet_mode_supported; > > + > > + /** Shaper private byte mode supported. When non-zero, this > > parameter > > + * indicates that there is atleast one node that can be configured > > + * with byte mode in it's private shaper. When shaper is configured > > + * in byte mode, committed/peak rate provided is interpreted in > > + * bytes per second. > > + */ > > + int shaper_private_byte_mode_supported; > > + > > + > > /** Maximum number of shared shapers. The value of zero indicates > > that > > * shared shapers are not supported. > > */ > > @@ -284,6 +301,21 @@ struct rte_tm_capabilities { > > */ > > uint64_t shaper_shared_rate_max; > > > > + /** Shaper shared packet mode supported. When non-zero, this > > parameter > > + * indicates a shared shaper can be configured with packet mode. > > + * When shared shaper is configured in packet mode, > > committed/peak rate > > + * provided is interpreted in packets per second. > > + */ > > + int shaper_shared_packet_mode_supported; > > + > > + /** Shaper shared byte mode supported. When non-zero, this > > parameter > > + * indicates that a shared shaper can be configured with byte mode. > > + * When shared shaper is configured in byte mode, committed/peak > > rate > > + * provided is interpreted in bytes per second. > > + */ > > + int shaper_shared_byte_mode_supported; > > + > > + > > /** Minimum value allowed for packet length adjustment for any > > private > > * or shared shaper. > > */ > > @@ -339,6 +371,22 @@ struct rte_tm_capabilities { > > */ > > uint32_t sched_wfq_weight_max; > > > > + /** WFQ packet mode supported. When non-zero, this parameter > > indicates > > + * that there is at least one non-leaf node that supports packet mode > > + * for WFQ among its children. WFQ weights will be applied against > > + * packet count for scheduling children when a non-leaf node > > + * is configured appropriately. > > + */ > > + int sched_wfq_packet_mode_supported; > > + > > + /** WFQ byte mode supported. When non-zero, this parameter > > indicates > > + * that there is at least one non-leaf node that supports byte mode > > + * for WFQ among its children. WFQ weights will be applied against > > + * bytes for scheduling children when a non-leaf node is configured > > + * appropriately. > > + */ > > + int sched_wfq_byte_mode_supported; > > + > > /** WRED packet mode support. When non-zero, this parameter > > indicates > > * that there is at least one leaf node that supports the WRED packet > > * mode, which might not be true for all the leaf nodes. In packet > > @@ -485,6 +533,24 @@ struct rte_tm_level_capabilities { > > */ > > uint64_t shaper_private_rate_max; > > > > + /** Shaper private packet mode supported. When > > non-zero, > > + * this parameter indicates there is atleast one > > + * non-leaf node at this level that can be configured > > + * with packet mode in its private shaper. When > > private > > + * shaper is configured in packet mode, > > committed/peak > > + * rate provided is interpreted in packets per second. > > + */ > > + int shaper_private_packet_mode_supported; > > + > > + /** Shaper private byte mode supported. When > > non-zero, > > + * this parameter indicates there is atleast one > > + * non-leaf node at this level that can be configured > > + * with byte mode in its private shaper. When private > > + * shaper is configured in byte mode, > > committed/peak > > + * rate provided is interpreted in bytes per second. > > + */ > > + int shaper_private_byte_mode_supported; > > + > > /** Maximum number of shared shapers that any > > non-leaf > > * node on this level can be part of. The value of zero > > * indicates that shared shapers are not supported by > > @@ -554,6 +620,25 @@ struct rte_tm_level_capabilities { > > */ > > uint32_t sched_wfq_weight_max; > > > > + /** WFQ packet mode supported. When non-zero, > > this > > + * parameter indicates that there is at least one > > + * non-leaf node at this level that supports packet > > + * mode for WFQ among its children. WFQ weights > > will > > + * be applied against packet count for scheduling > > + * children when a non-leaf node is configured > > + * appropriately. > > + */ > > + int sched_wfq_packet_mode_supported; > > + > > + /** WFQ byte mode supported. When non-zero, this > > + * parameter indicates that there is at least one > > + * non-leaf node at this level that supports byte > > + * mode for WFQ among its children. WFQ weights > > will > > + * be applied against bytes for scheduling children > > + * when a non-leaf node is configured appropriately. > > + */ > > + int sched_wfq_byte_mode_supported; > > + > > /** Mask of statistics counter types supported by the > > * non-leaf nodes on this level. Every supported > > * statistics counter type is supported by at least one > > @@ -596,6 +681,24 @@ struct rte_tm_level_capabilities { > > */ > > uint64_t shaper_private_rate_max; > > > > + /** Shaper private packet mode supported. When > > non-zero, > > + * this parameter indicates there is atleast one leaf > > + * node at this level that can be configured with > > + * packet mode in its private shaper. When private > > + * shaper is configured in packet mode, > > committed/peak > > + * rate provided is interpreted in packets per second. > > + */ > > + int shaper_private_packet_mode_supported; > > + > > + /** Shaper private byte mode supported. When > > non-zero, > > + * this parameter indicates there is atleast one leaf > > + * node at this level that can be configured with > > + * byte mode in its private shaper. When private > > shaper > > + * is configured in byte mode, committed/peak rate > > + * provided is interpreted in bytes per second. > > + */ > > + int shaper_private_byte_mode_supported; > > + > > /** Maximum number of shared shapers that any > > leaf node > > * on this level can be part of. The value of zero > > * indicates that shared shapers are not supported by > > You are missing the shaper_shared_(packet, byte)_mode supported for non-leaf and leaf nodes in struct rte_tm_level_capabilities. > > The description of this nodes should be aligned with the description of e.g. shaper_shared_n_max field: basically, we want to say that, when true, the flag signifies there is at least on non-leaf/leaf node on this level that can be part of a shared shaper that works in packet/byte mode. Makes sense? I intentionally didn't add shaper_shared_(packet, byte)_mode in node and level capabilities and added it in only global cap assuming existing semantics are enforcing that. Currently, except for 'shaper_shared_n_max', all the other existing shared shaper capabilities like shaper_shared_dual_rate_n_max, shaper_shared_rate_min, etc are only provided in global cap. I felt the semantics are as such because, shared shaper doesn't really belong to any node or level and any node from any level can attach to a particular shared shaper. Isn't it so ? > > > @@ -686,6 +789,20 @@ struct rte_tm_node_capabilities { > > */ > > uint64_t shaper_private_rate_max; > > > > + /** Shaper private packet mode supported. When non-zero, this > > parameter > > + * indicates private shaper of current node can be configured with > > + * packet mode. When configured in packet mode, committed/peak > > rate > > + * provided is interpreted in packets per second. > > + */ > > + int shaper_private_packet_mode_supported; > > + > > + /** Shaper private byte mode supported. When non-zero, this > > parameter > > + * indicates private shaper of current node can be configured with > > + * byte mode. When configured in byte mode, committed/peak rate > > + * provided is interpreted in bytes per second. > > + */ > > + int shaper_private_byte_mode_supported; > > + > > /** Maximum number of shared shapers the current node can be > > part of. > > * The value of zero indicates that shared shapers are not supported > > by > > * the current node. > > You are missing the shaper_shared_(packet, byte)_mode supported (applicable for both non-leaf and leaf nodes, so it should occur only once in the common part of the struct) in struct rte_tm_node_capabilities. See the above comment on the applicable description style. Please see above. > > > @@ -735,6 +852,23 @@ struct rte_tm_node_capabilities { > > * WFQ weight, so WFQ is reduced to FQ. > > */ > > uint32_t sched_wfq_weight_max; > > + > > + /** WFQ packet mode supported. When non-zero, > > this > > + * parameter indicates that current node supports > > packet > > + * mode for WFQ among its children. WFQ weights > > will be > > + * applied against packet count for scheduling > > children > > + * when configured appropriately. > > + */ > > + int sched_wfq_packet_mode_supported; > > + > > + /** WFQ byte mode supported. When non-zero, this > > + * parameter indicates that current node supports > > byte > > + * mode for WFQ among its children. WFQ weights > > will be > > + * applied against bytes for scheduling children when > > + * configured appropriately. > > + */ > > + int sched_wfq_byte_mode_supported; > > + > > } nonleaf; > > > > /** Items valid only for leaf nodes. */ > > @@ -836,10 +970,10 @@ struct rte_tm_wred_params { > > * Token bucket > > */ > > struct rte_tm_token_bucket { > > - /** Token bucket rate (bytes per second) */ > > + /** Token bucket rate (bytes per second or packets per second) */ > > uint64_t rate; > > > > - /** Token bucket size (bytes), a.k.a. max burst size */ > > + /** Token bucket size (bytes or packets), a.k.a. max burst size */ > > uint64_t size; > > }; > > > > @@ -860,6 +994,11 @@ struct rte_tm_token_bucket { > > * Dual rate shapers use both the committed and the peak token buckets. > > The > > * rate of the peak bucket has to be bigger than zero, as well as greater than > > * or equal to the rate of the committed bucket. > > + * > > + * @see struct > > rte_tm_capabilities::shaper_private_packet_mode_supported > > + * @see struct rte_tm_capabilities::shaper_private_byte_mode_supported > > + * @see struct > > rte_tm_capabilities::shaper_shared_packet_mode_supported > > + * @see struct rte_tm_capabilities::shaper_shared_byte_mode_supported > > */ > > struct rte_tm_shaper_params { > > /** Committed token bucket */ > > @@ -874,6 +1013,17 @@ struct rte_tm_shaper_params { > > * RTE_TM_ETH_FRAMING_OVERHEAD_FCS). > > */ > > int32_t pkt_length_adjust; > > + > > + /** When zero, the private or shared shaper that is associated to this > > + * profile works in byte mode and hence *rate* and *size* fields in > > + * both token bucket configurations are specified in bytes per second > > + * and bytes respectively. > > + * When non-zero, that private or shared shaper works in packet > > mode and > > + * hence *rate* and *size* fields in both token bucket configurations > > + * are specified in packets per second and packets respectively. In > > + * packet mode, *pkt_length_adjust* is ignored. > > + */ > > Please move the last statement ("In packet mode, *pkt_length_adjust* is ignored.") to the description of the pkt_length_adjust field. Ack. > > > + int packet_mode; > > }; > > > > /** > > @@ -925,6 +1075,8 @@ struct rte_tm_node_params { > > * When non-NULL, it points to a pre-allocated array > > of > > * *n_sp_priorities* values, with non-zero value for > > * byte-mode and zero for packet-mode. > > + * @see struct > > rte_tm_node_capabilities::sched_wfq_packet_mode_supported > > + * @see struct > > rte_tm_node_capabilities::sched_wfq_byte_mode_supported > > */ > > int *wfq_weight_mode; > > > > -- > > 2.8.4 > > Regards, > Cristian