From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 549CDA0597; Tue, 21 Apr 2020 13:55:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 240391D5CE; Tue, 21 Apr 2020 13:55:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E46CE1C131 for ; Tue, 21 Apr 2020 13:55:25 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03LBtPlx003078; Tue, 21 Apr 2020 04:55:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=NCXR+k9BIqW3oehIkjo0lLnOTE4MXAGqYNDXhQA2Td4=; b=PhlYRENc13aoQegWKkzp6fk33NY+tTg9XtLkl5sPFZEksr6W22x0ArpoKjYhFquEKzwa V17e5lKrBCul9Kg/C8zGG37iZ8SAWGyxxWOxmId3mDObovT8N/UjPE0IR3xcYFl4mixZ y0U3aDdR45dwQYVA22CUxg6PhLgpkOHPVC4GtxHe/SyTEQEWBgOPKL5iBOesw0Ov94Fq VjyJIESfyr8+xXA+nYId268ZYIfxsiFnlAYK6GJcq1jrhP7GIYMRdhQ8dLso2Tqx7WvL Y6pEA4r/7cpdbaspI2FBXKFVrLe/1KK7LqyA6Ib4xTnISUj96m5CXVvuAvFKNrRxGFJ+ Dg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30fxwpc2nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 21 Apr 2020 04:55:24 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 21 Apr 2020 04:55:23 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 21 Apr 2020 04:55:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dsNGkA1SqnkF90Z6tSSlkK2Vnn7fqOZYGT5ztKMQnU8dG7kIDhVVvy55hC9Z55us3GB/zVVep2p73yynhGNqBJd4wXH8nMqtn7zZD/NOCaWpcOQGnFMIOeidQhtHLHO/mz140xs6YCfZGjyQkqGFMS7RpFElLLb290RRZjLxRLH3GtSZjzuGwHksO5/FgQq6cIoETF0uCgLFrtoCfx0Lk9Ik9APnTcmaO6kyZbY1dZ/r+O4p6VuFH7pcgGzLriR4ctL1zJnudHeBXo63cchjvyo/RroDcLUeFjnZwpPP0LKKkyICtrpt5ZxSAar1Xw9T2U+H0WRcBRZyx+Im2CR4NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NCXR+k9BIqW3oehIkjo0lLnOTE4MXAGqYNDXhQA2Td4=; b=I9KABRTAfoMis5rPEEUMwE0wUSyAoz7m94v5TcfwxGQjRHR/aPAQw1WM0VJwRzK9AeYrwm9tgve3KMhQ0s+zF3xi04fpDidVVaU8WBBO84ZIMy9vZYygwPzEzwEyjhuAbKGbtoRAhKbb9ZglNuinLjDjKeVxN977cTwrZu8tI+AHHChZhSjpqlu6JlzcGhWsHSlRJZbQm64NuXhwx9S2DARFriQuRWDefZgmtGVUfAPWITLCBB9tBMSXx9nDUjvz5Q5iWnJEWB8wCgxYJPhr6RxI6r315G4lyLUhViQX9Ls3Ezw1hG/WfyYqX8Dhzu+ZAfgWPuKzS2pFQbdEwBbavQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NCXR+k9BIqW3oehIkjo0lLnOTE4MXAGqYNDXhQA2Td4=; b=rnHiwKYx2brZkLbpV98KDXOnOmhghi2wdN/EPxo8dNQ513jot3rRFzYUQvhQ/+IMWa5wj5q/yHrzP/nNlrrWok+TvZUbIQpipjNHh/Ya+XVHwpsm/7RwP+rsxMG76UDv5X29Pf0IsDqpka3pQiyJVYBqHY5pRxmBANaZ3oTNvCs= Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB3047.namprd18.prod.outlook.com (2603:10b6:a03:105::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 11:55:21 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 11:55:21 +0000 Date: Tue, 21 Apr 2020 17:25:07 +0530 From: Nithin Dabilpuram To: "Dumitrescu, Cristian" CC: Nithin Dabilpuram , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" Message-ID: <20200421115507.GB2740@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200411114430.18506-1-nithind1988@gmail.com> <20200421095813.GA2740@outlook.office365.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BMXPR01CA0095.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::35) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BMXPR01CA0095.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Tue, 21 Apr 2020 11:55:18 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c64c6d9-228c-41aa-0ede-08d7e5eade31 X-MS-TrafficTypeDiagnostic: BYAPR18MB3047: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 038002787A X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(55016002)(316002)(81156014)(86362001)(8676002)(66476007)(6506007)(9686003)(66946007)(33656002)(6666004)(8936002)(4326008)(5660300002)(1076003)(107886003)(55236004)(7696005)(66556008)(2906002)(186003)(6916009)(26005)(54906003)(52116002)(956004)(478600001)(16526019); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J6deXKzD5yR9kK8ngijFpNGfi44QEvlR2efSm13KEOo+JQHmXp2cvpKB2Bg1Um291dVxbKW+NzpqZsVaCJJJQtizgZn3bKHoeppb2dgJju6gn/GRePdai/F5JbscH2LB3ZSf0aYLLoG5fKW2K6VWFQUym6RSeU3UVPZ+4S1sWAocQbHgAohkOuD5WA5Wp1O6rXVPkoqG4ubYjiaXsAef+KJNw9ci6zHHAonKcWhXu27qzAQ1GvesH5GzMbqIBJPEaqJIVa3Xk6nLRvmZaypwKid8f01FnxDQ1M2EHzRw11EjFdjVwYAwMuKl6MaBraWwnl5tO3r6Irxlx+Fic8LvnGgRshYE30LWRrit6uc+SrPijdsJe+RLrWVyoNdiWYeR1qWdnCIIPLrADzldsoyMfu3LNwNgqlHFxg8xc5QE4uLJi/tfRUTWEZReYxj5hC7c X-MS-Exchange-AntiSpam-MessageData: PuYq4XEm+r2vfkPb9ThQH8QWDH3w+5IlFIf9wDE70vVJ4wut2oeOOvFvlB+1z+iCekEiaf4w9dglVJeOJJy/RYloB4aWJzbKIqjKVEUXjZSHfU7CJLSf6AE/kzIh29uPnnpeh5FKpICUqH2T5lpV9g== X-MS-Exchange-CrossTenant-Network-Message-Id: 0c64c6d9-228c-41aa-0ede-08d7e5eade31 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2020 11:55:21.1777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a21zZfo2QeGp6neKSLeFG+j3XQYB+k5W3RmdIx2xW/gS2O5Nx9IEJz+qMdyRttWgZohsMzBf5GZgUeu24X24Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3047 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-21_04:2020-04-20, 2020-04-21 signatures=0 Subject: Re: [dpdk-dev] [EXT] RE: [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 21, 2020 at 10:23:11AM +0000, Dumitrescu, Cristian wrote: > External Email > > ---------------------------------------------------------------------- > Hi Nithin, > > ... > > > > You are missing the shaper_shared_(packet, byte)_mode supported for > > non-leaf and leaf nodes in struct rte_tm_level_capabilities. > > > > > > The description of this nodes should be aligned with the description of e.g. > > shaper_shared_n_max field: basically, we want to say that, when true, the > > flag signifies there is at least on non-leaf/leaf node on this level that can be > > part of a shared shaper that works in packet/byte mode. Makes sense? > > > > I intentionally didn't add shaper_shared_(packet, byte)_mode in node and > > level > > capabilities and added it in only global cap assuming existing semantics are > > enforcing that. > > > > Currently, except for 'shaper_shared_n_max', all the other existing shared > > shaper capabilities like > > shaper_shared_dual_rate_n_max, shaper_shared_rate_min, etc are only > > provided in global cap. > > > > I felt the semantics are as such because, shared shaper doesn't really belong > > to any node > > or level and any node from any level can attach to a particular shared shaper. > > Isn't it so > > ? > > That's exactly why we need to formulate node/level capability from node's perspective, and not from the shared shaper's perspective, as a shared shaper is by definition related to a set of nodes, not just one node. > > The fact that a given node can be part of a shared shaper that works in packet or byte mode, etc is a node capability in itself, right? So the node's capability called "shaper_shared_(packet, byte)_mode" being supported by the node means that this specific node can be part of a shared shaper that has those properties. To me, this is a valuable thing to capture in node/level capabilities. > > We already have other node level capabilities for shared shaper, and we apply the same rationale there. > > What do you think? Ok. I'll add them from the node's perspective. Thanks. > > Regards, > Cristian