From: talshn@mellanox.com
To: dev@dpdk.org
Cc: thomas@monjalon.net, Tal Shnaiderman <talshn@mellanox.com>
Subject: [dpdk-dev] [PATCH] eal: fix Windows build
Date: Tue, 21 Apr 2020 18:05:20 +0300 [thread overview]
Message-ID: <20200421150520.18840-1-talshn@mellanox.com> (raw)
From: Tal Shnaiderman <talshn@mellanox.com>
Windows headers pthread.h and fnmatch.h
uses rte_common types
The error is: error: unknown type name '__rte_unused'
The fix adds the missing includes.
Bugzilla ID: 458
Fixes: f2fc83b40f06 ("replace unused attributes")
Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
---
Depends-on: patch-68444
(eal/windows: do not expose private EAL facilities)
---
lib/librte_eal/windows/include/fnmatch.h | 2 ++
lib/librte_eal/windows/include/pthread.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/lib/librte_eal/windows/include/fnmatch.h b/lib/librte_eal/windows/include/fnmatch.h
index 41b574312..d0159f07a 100644
--- a/lib/librte_eal/windows/include/fnmatch.h
+++ b/lib/librte_eal/windows/include/fnmatch.h
@@ -14,6 +14,8 @@
extern "C" {
#endif
+#include <rte_common.h>
+
#define FNM_NOMATCH 1
/**
diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h
index 7c0caaf07..0bbed5c3b 100644
--- a/lib/librte_eal/windows/include/pthread.h
+++ b/lib/librte_eal/windows/include/pthread.h
@@ -17,6 +17,7 @@ extern "C" {
#endif
#include <windows.h>
+#include <rte_common.h>
#define PTHREAD_BARRIER_SERIAL_THREAD TRUE
--
2.16.1.windows.4
next reply other threads:[~2020-04-21 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 15:05 talshn [this message]
2020-04-21 22:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421150520.18840-1-talshn@mellanox.com \
--to=talshn@mellanox.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).