From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25375A05A1; Wed, 22 Apr 2020 01:36:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 174611D41C; Wed, 22 Apr 2020 01:36:46 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by dpdk.org (Postfix) with ESMTP id B135C1C1D8 for ; Wed, 22 Apr 2020 01:36:44 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id t11so131593lfe.4 for ; Tue, 21 Apr 2020 16:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dMlON8MDiF3j+23FMNnSOXyFL+EUwz+Jx06+n8RtE6w=; b=dESign5kX8QZLtddhU4DJYKHsCGRsOZZ1iNQEXeuFFD/kbKirRa+Vhfi901uT5Mnsg BovofDoIzFtm8WaJ/k/1npheLQ/8BkF3tWmoo63V3qeYvHMt9ga0uXkMZgkWFXOsUlhV W1XUS4kUHcO2/vt45K88dM9JY57ONE7RZTkn1t9hg6Tmo9LbEnGp+6xzIrJp6DLPMh7m YZVYaay6rnpI7OEv3TVZAQta094kn2Y0Uydm0TuOO0USzg5E418jqULGcKeawspGGBDk c0VgTbrm7jsSISPOeoKuncNrrhKipFTfByursurvpSV3UKhcr1LEQFaRUQdzEQ+0qaRX LP3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dMlON8MDiF3j+23FMNnSOXyFL+EUwz+Jx06+n8RtE6w=; b=IE1trBOpLFdansXX1NkFvjyM5y2qqWf3ZlZ0Qg8hj7mEPrknRiJy2xQlHlmgQxHR86 kzC6cb9KPY6hUGBaU6drgKv9KLkvjTPtMTmIZBiR9JX0scutrY5bv78rK2JM6TnNBnV8 3pwAeezdA3faqr/IN8qf0+g30voocLIJGOQ+cKd1TjqKqlacE2wVhQgHvAN90rP2Yhkq ohsiJDLOMTNgz9HWff2prvh0H1e2PZAk/FCXPP/WbppNRn+aK/KrbeHOvjTsNbI9/sO8 G+mOuyaFSKL6Xpu8fSuqwVTZHNUDZe8o4llxcAQg9zWfdyjxL4mac8ScZAzEyH9gzSro Vz6g== X-Gm-Message-State: AGi0PuZjFgio3QlkPCC3Gxc82nZFoL9ct13NgvmDQBTM/ROHoGyiqHuS KKE4E/gFUwstqYw64Iy9Z2M= X-Google-Smtp-Source: APiQypIJncq/WRMaTaBl3oObG1RcNR2BDjlgXu9e0ze5BVJm9N+Ywnvt/1sC9gOcWl/5LA55W0oBOA== X-Received: by 2002:a19:f610:: with SMTP id x16mr15331881lfe.79.1587512204143; Tue, 21 Apr 2020 16:36:44 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id m12sm3189879ljc.81.2020.04.21.16.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2020 16:36:43 -0700 (PDT) Date: Wed, 22 Apr 2020 02:36:37 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: "dev@dpdk.org" , "Dmitry Malloy (MESHCHANINOV)" , Narcisa Ana Maria Vasile , Fady Bader , Thomas Monjalon , Anatoly Burakov , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Message-ID: <20200422023637.0fd70090@Sovereign> In-Reply-To: References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-7-dmitry.kozliuk@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > I'd remove the GetVersionEx check entirely and add the comments regarding OS dependency to the RTE_LOG > Of the LoadLibraryA failure below, GetVersionEx returns the Windows 8 OS version on newer servers Agreed, will do in v4. > Also, it looks like not all Win2016 servers versions support VirtualAlloc2, I'm using Microsoft Windows Server 2016 Datacenter Version 10.0.14393 and LoadLibraryA failed to load VirtualAlloc2. I confirm this. Documentation states Windows Server 2016 is supported, but it is at least partially incorrect, see comments in meson.build and GitHub issue: https://github.com/MicrosoftDocs/feedback/issues/1129 How would you estimate Server 2016 support importance? Server 2019 and Windows 10 are known to work. -- Dmitry Kozlyuk