From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8BCAA00C2; Wed, 22 Apr 2020 09:32:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BB841C2F0; Wed, 22 Apr 2020 09:32:19 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C9C041C296 for ; Wed, 22 Apr 2020 09:32:17 +0200 (CEST) IronPort-SDR: n2phyC0Gdwk2/pXv2gsyz9YABENn7kHI5HeRd7OBG+FNUxUJDgxNuLWg0SoYknS+gWrQ4DUK3+ QlX4bQa26QZg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 00:32:16 -0700 IronPort-SDR: wYp4tmt4kALhjZaCRLnLslFrjoCQsp4idVzrmrGf4gkYn8PN3GpCrPe29g4f/XKUcSeb4/BuKI hI6ku9FVV8cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,412,1580803200"; d="scan'208";a="273796220" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga002.jf.intel.com with ESMTP; 22 Apr 2020 00:32:15 -0700 Date: Wed, 22 Apr 2020 15:27:53 +0800 From: Ye Xiaolong To: cheng.peng5@zte.com.cn Cc: jingjing.wu@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org Message-ID: <20200422072753.GC105307@intel.com> References: <202004140956577212766@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202004140956577212766@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix return value of stats get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thanks for the fix. On 04/14, cheng.peng5@zte.com.cn wrote: >The iavf_dev_stats_get function should return ret instead of -eio. > Fixes: f4a41a6953af ("net/avf: support stats") Cc: stable@dpdk.org >Signed-off-by: Peng Cheng >--- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c >index 34913f9..93ab121 100644 >--- a/drivers/net/iavf/iavf_ethdev.c >+++ b/drivers/net/iavf/iavf_ethdev.c >@@ -1074,7 +1074,7 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > } else { > PMD_DRV_LOG(ERR, "Get statistics failed"); > } >- return -EIO; >+ return ret; > } > > static int >-- >1.8.3.1 Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel with fixes tag and cc table, Thanks.