From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63547A00C2; Wed, 22 Apr 2020 09:38:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C43001D162; Wed, 22 Apr 2020 09:38:15 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id DB2831D151 for ; Wed, 22 Apr 2020 09:38:13 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from fady@mellanox.com) with ESMTPS (AES256-SHA encrypted); 22 Apr 2020 10:38:11 +0300 Received: from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 03M7cBH3016396; Wed, 22 Apr 2020 10:38:11 +0300 From: Fady Bader To: dev@dpdk.org Cc: thomas@monjalon.net, olivier.matz@6wind.com, arybchenko@solarflare.com, stable@dpdk.org Date: Wed, 22 Apr 2020 10:37:44 +0300 Message-Id: <20200422073744.21804-1-fady@mellanox.com> X-Mailer: git-send-email 2.16.1.windows.4 Subject: [dpdk-dev] [PATCH] mempool: remove inline functions from export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The code didn't compile when using exported mempool functions under windows. compilation error logs: rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_cache_flush rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_default_cache rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_get rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_put lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals clang: error: linker command failed with exit code 1120 (use -v to see invocation) [77/77] Linking target drivers/librte_bus_pci-0.200.2.dll. ninja: build stopped: subcommand failed. The cause was that there were some inline functions that were included in the export list. To solve this the functions were removed from rte_mempool_version.map export list which are implemented in the header and shouldn't be exported. Fixes: 4b5062755aa74517ed1d7bd ("mempool: allow user-owned cache") Fixes: 656f2d3ede96902202a1a5f ("mempool: deprecate specific get and put functions") Cc: stable@dpdk.org Signed-off-by: Fady Bader --- lib/librte_mempool/rte_mempool_version.map | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map index d002dfc46..d67ed2e2b 100644 --- a/lib/librte_mempool/rte_mempool_version.map +++ b/lib/librte_mempool/rte_mempool_version.map @@ -4,18 +4,14 @@ DPDK_20.0 { rte_mempool_audit; rte_mempool_avail_count; rte_mempool_cache_create; - rte_mempool_cache_flush; rte_mempool_cache_free; rte_mempool_calc_obj_size; rte_mempool_check_cookies; rte_mempool_contig_blocks_check_cookies; rte_mempool_create; rte_mempool_create_empty; - rte_mempool_default_cache; rte_mempool_dump; rte_mempool_free; - rte_mempool_generic_get; - rte_mempool_generic_put; rte_mempool_in_use_count; rte_mempool_list_dump; rte_mempool_lookup; -- 2.16.1.windows.4