From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A9F2A00C2; Wed, 22 Apr 2020 13:32:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EDA91D5AE; Wed, 22 Apr 2020 13:32:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 354D61C1C4 for ; Wed, 22 Apr 2020 13:32:04 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03MBPqX4007635; Wed, 22 Apr 2020 04:32:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=pfpt0818; bh=i+tDBrfSsnTzqctsVPjsl7Zmv6WG7ddc1lEc5k1qCHE=; b=NiU7qPuWR+x1fpbc+68CJIzXelhAt+KHLJAyLDNsMfl0urs93Z48tJcCh7Lq5gLR1Hq/ rNOjM3+Fzw2u7j3lZyBg1HMqowZPNCbuWutLELc/i5x69gjFZ01oZ43TavX6SpIscwAk ebtbr8piHOikJGGVarIDIIXq4RQZQPvcZS9af8bsBAOTTJ8g4UU5tzxJ9xnb/LlF0xJ2 DHqe5VjDVgNJsbYDZxviCFLNJj7WpnkNlfwg79h4yX5f/smcr72rm1F89FfTeeHU/5km xQFI22mZGZDERysnjXFPrUKeJ9MOUISy1Z2e9hxp1m0KMLTMIMmtAE48XsywUEko0dch vQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30fxwph6y6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 Apr 2020 04:32:03 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Apr 2020 04:32:01 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Apr 2020 04:32:01 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 22 Apr 2020 04:32:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgXJ7yn/IqSBPWpkn1wJuD4Tr1N5NHwYGuXMYn8PJ/q1Wx5xiwfT1rqIz1hu9+6BeP1y5ZoAQsEArJEcaORB8UXzuRUvqGAdmKqxVkQUUpcQb8swZXUTiU8zBpuP855PKerlpkXfoyAlF2lHIisAG1i5BzfH72M5TXe5Vh/tvryCgFlUFvObCS+prUCrsQWZl2ADtDjPfyIM9/a5EJ+O2i/xrRv4Gni3K5wMEdJQcElZLi5FeBlWAUiLnJcnaGkNGMA9dLrKikM3zKxas45XfdVEsSYO2S+aB19ZtWE5ANcf4zLjHXuVsWxEXtX9TLnue4w+TLPK+xDG8YoyGeEgwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i+tDBrfSsnTzqctsVPjsl7Zmv6WG7ddc1lEc5k1qCHE=; b=GMDV/wsgCfMeoNLPMwEq2Q5jO0HFHy67fysfwqLedEISN5C/BX8XRmcw1or92hoaRU3X71mJvCop5ZMJ6lxMrR3NhFPP8ilALfX7/RZehTAXEqRKUG8K4vmTxev6c/6fXRynELeYb8THOrLSXSXW7t1Toxfk7vWjtv87Zke8BfuI36XvUoWQDgKlVpQ87Wt5Kb1GQzDULalGgLAJzMoYMRcZuEHkKCZP4iuRiYV9fVmKw0eZvPxivzPfKDs5ZD4h8UIpNA+SI8xBRYTjboZvb3owOrWKL75JiSuqBVumQKqFGTlhQCYlb/KVChH47y1XLctR+Nw6Vid35V2FwTXZew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i+tDBrfSsnTzqctsVPjsl7Zmv6WG7ddc1lEc5k1qCHE=; b=kziNh4Koj98OcSP9JOJ8yF8ssSdA4nqU49oEdDos7+5FfDE/NFh/M6Nt+LGY9NPtUXKgifLR6Ym/OpJTtsGpxmMtuA9bdZPJRCDUvnI5Lv9QcgGbyg57XqouP6+J0SK8H71JYiF9zHRlafPwJPFUlgmCbFt+JZzJlmbS9Do5Ih4= Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2885.namprd18.prod.outlook.com (2603:10b6:a03:10e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.30; Wed, 22 Apr 2020 11:31:59 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2921.030; Wed, 22 Apr 2020 11:31:59 +0000 Date: Wed, 22 Apr 2020 17:01:46 +0530 From: Nithin Dabilpuram To: "Dumitrescu, Cristian" CC: Nithin Dabilpuram , "Singh, Jasvinder" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" Message-ID: <20200422113146.GB760@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200422075948.10051-1-nithind1988@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BM1PR01CA0164.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::34) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BM1PR01CA0164.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.26 via Frontend Transport; Wed, 22 Apr 2020 11:31:56 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6f6b073-af7a-4373-29e6-08d7e6b0c512 X-MS-TrafficTypeDiagnostic: BYAPR18MB2885: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 03818C953D X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(396003)(39850400004)(136003)(376002)(346002)(5660300002)(8676002)(956004)(55236004)(7696005)(2906002)(6506007)(26005)(53546011)(66476007)(9686003)(52116002)(66946007)(66556008)(186003)(16526019)(33656002)(4326008)(6916009)(8936002)(81156014)(55016002)(966005)(6666004)(86362001)(54906003)(478600001)(107886003)(1076003)(316002)(290074003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dyZVoTjHfTj/Hk4lTPWDZgmLTn/zvgCfw8YNKl1JtKAgTh3pLJvozn/R4wuTnwzSamS2Wn/mLIUDrZoo+g1RgVO9Ne8k3XRITlIuWhdWwmYMj9otE4RJ+GD2PJ+dyXu7dG/TcmXKRO3reLTdnuri6ovKtGITZWvTK1/si9lvl1yEB5uzRPWnqQBp7zHjHLMOBZxIg+B3ZotpIyPuCZI8FL6ZkSF+pFrRVRYmTcCcyPq0yF/NOrOulXAmvhZYazCgVfcNdEkMmCZJGGiB5Tvjnlh456XfT6IXskhzNIAQ04ZlUAOI3p4Ii6Yu7Vq94fgq+pu+4HeAr5kMUrCMwevmYhDYkYjsMo66wc2PyiIi6DwAFa9StB37CGVpxdDgrhD9Es2RVGX5c1m5BO56dFi3br+w2op54yMcd5dv91M3z82tiTjC8+jxNPt7Sl2NOJKFnHjQGKTf0u9heRkl8lzxLO/yD0dZ529g1Sm9/z1Mwj/sYa8xevcFP/8nDEOnXmxztB57Pr2GnivuuVQD0m9vgzTa9iz9lvWuyUYcK+xOuALTVb0pka2y4hXpWQ3ztC8K X-MS-Exchange-AntiSpam-MessageData: yTt7vtB1NKosm2c8ewghGAiJEAdh/8JlitpbxUDKtjVA+8TbX7mhACJ37WXylkFJt1mYsrzwz4RzSGuNyOk6O8Vo/nAvvPJEZkx5uOKFsFS1pRDDXFnfEDU8PGSTv0bsED7u22cg9c+STWpiQD/JSw== X-MS-Exchange-CrossTenant-Network-Message-Id: f6f6b073-af7a-4373-29e6-08d7e6b0c512 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2020 11:31:59.3487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dc/RBgDa8Sw+WMHOKQrCmOXl3q0NbTXGvgZ5kh8DSDvgKY0qLGV92kFNhQR/mFQ+aGrzNQpESPrxS+dRMFvjpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2885 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-22_03:2020-04-22, 2020-04-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] RE: [PATCH v3] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 22, 2020 at 10:10:47AM +0000, Dumitrescu, Cristian wrote: > External Email > > ---------------------------------------------------------------------- > Hi Nithin, > > > -----Original Message----- > > From: Nithin Dabilpuram > > Sent: Wednesday, April 22, 2020 9:00 AM > > To: Singh, Jasvinder ; Dumitrescu, Cristian > > ; Thomas Monjalon > > ; Yigit, Ferruh ; Andrew > > Rybchenko > > Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > > Dabilpuram > > Subject: [PATCH v3] ethdev: add tm support for shaper config in pkt mode > > > > From: Nithin Dabilpuram > > > > Some NIC hardware support shaper to work in packet mode i.e > > shaping or ratelimiting traffic is in packets per second (PPS) as > > opposed to default bytes per second (BPS). Hence this patch > > adds support to configure shared or private shaper in packet mode, > > provide rate in PPS and add related tm capabilities in port/level/node > > capability structures. > > > > This patch also updates tm port/level/node capability structures with > > exiting features of scheduler wfq packet mode, scheduler wfq byte mode > > and private/shared shaper byte mode. > > > > SoftNIC PMD is also updated with new capabilities. > > > > Signed-off-by: Nithin Dabilpuram > > --- > > > > v2..v3: > > - Fix typo's > > - Add shaper_shared_(packet, byte)_mode_supported in level and node cap > > - Fix comment in pkt_length_adjust. > > - Move rte_eth_softnic_tm.c capability update to patch 1/4 to > > avoid compilations issues in node and level cap array in softnicpmd. > > ../drivers/net/softnic/rte_eth_softnic_tm.c:782:3: warning: braces around > > scalar initializer > > {.nonleaf = { > > ../drivers/net/softnic/rte_eth_softnic_tm.c:782:3: note: (near initialization > > for ‘tm_node_cap[0].shaper_shared_byte_mode_supported’) > > ../drivers/net/softnic/rte_eth_softnic_tm.c:782:4: error: field name not in > > record or union initializer > > {.nonleaf = { > > > > v1..v2: > > - Add seperate capability for shaper and scheduler pktmode and bytemode. > > - Add packet_mode field in struct rte_tm_shaper_params to indicate > > packet mode shaper profile. > > > > > > drivers/net/softnic/rte_eth_softnic_tm.c | 65 ++++++++++ > > lib/librte_ethdev/rte_tm.h | 196 > > ++++++++++++++++++++++++++++++- > > 2 files changed, 259 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c > > b/drivers/net/softnic/rte_eth_softnic_tm.c > > index 80a470c..344819f 100644 > > --- a/drivers/net/softnic/rte_eth_softnic_tm.c > > +++ b/drivers/net/softnic/rte_eth_softnic_tm.c > > ... > > The softnic changes logically belong to a separate patch. I understand you are getting some build warnings, but it does not make sense to me. Are you sure there is no other way to avoid them? I see error only because of v3 changes in node cap. There seems to be some gcc issue with order of initializations only when next field is union. I tried both gcc 4.8.5 and 7.3.1 struct test { int a; char b; int c; union { int d; }; }; struct test ds1 = { .a = 10, .b = 20, { .d = 40, } }; int main(void) { printf("ds1.a %d\n", ds1.a); } [root@hyd1588t430 dpdk]# make a cc a.c -o a a.c:20:2: warning: braces around scalar initializer [enabled by default] { ^ a.c:20:2: warning: (near initialization for ‘ds1.c’) [enabled by default] a.c:21:3: error: field name not in record or union initializer .d = 40, ^ a.c:21:3: error: (near initialization for ‘ds1.c’) make: *** [a] Error 1 I don't see any issue if 'd' is not inside a union. Similar issue is reported in kernel and similar fix was applied of initializing all the fields. https://patchwork.kernel.org/patch/3033041/ > > You are not checking that packet_mode is set to 0. Please add a check in function shaper_profile_check() (file rte_eth_softnic_tm.c) to verify that packet_mode is always set to 0. Ack. > > Jasvinder, any other changes we need in Soft NIC? > > > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h > > index f9c0cf3..b3865af 100644 > > --- a/lib/librte_ethdev/rte_tm.h > > +++ b/lib/librte_ethdev/rte_tm.h > > I am now fine with your additions to this file, with some minor exceptions listed below. Thank you! > > > @@ -250,6 +250,23 @@ struct rte_tm_capabilities { > > */ > > uint64_t shaper_private_rate_max; > > > > + /** Shaper private packet mode supported. When non-zero, this > > parameter > > + * indicates that there is at least one node that can be configured > > + * with packet mode in it's private shaper. When shaper is configured > > Recurring typo: it's -> its > > Please search for all occurrences of "it's", all should be replaced with either "its" or "it is", we should have absolutely no occurrence of "it's". Ack. My bad, I misunderstood earlier comment. Will fix in v4. > > ... > > > > > @@ -860,6 +1034,11 @@ struct rte_tm_token_bucket { > > * Dual rate shapers use both the committed and the peak token buckets. > > The > > * rate of the peak bucket has to be bigger than zero, as well as greater than > > * or equal to the rate of the committed bucket. > > + * > > + * @see struct > > rte_tm_capabilities::shaper_private_packet_mode_supported > > + * @see struct rte_tm_capabilities::shaper_private_byte_mode_supported > > + * @see struct > > rte_tm_capabilities::shaper_shared_packet_mode_supported > > + * @see struct rte_tm_capabilities::shaper_shared_byte_mode_supported > > */ > > struct rte_tm_shaper_params { > > /** Committed token bucket */ > > @@ -872,8 +1051,19 @@ struct rte_tm_shaper_params { > > * purpose of shaping. Can be used to correct the packet length with > > * the framing overhead bytes that are also consumed on the wire > > (e.g. > > * RTE_TM_ETH_FRAMING_OVERHEAD_FCS). > > + * This field is ignored when the profile enables packet mode. > > */ > > int32_t pkt_length_adjust; > > + > > + /** When zero, the private or shared shaper that is associated to this > > + * profile works in byte mode and hence *rate* and *size* fields in > > + * both token bucket configurations are specified in bytes per second > > + * and bytes respectively. > > + * When non-zero, that private or shared shaper works in packet > > mode and > > + * hence *rate* and *size* fields in both token bucket configurations > > + * are specified in packets per second and packets respectively. > > + */ > > + int packet_mode; > > }; > > I would like to simplify this comment a bit. The reference to a shaper being associated with a profile might be confusing, as some people might incorrectly read there is a 1:1 association between shaper and profile, etc; this is described in mode details in the comment at the top of this structure. I would avoid any mentions of objects outside of the current structure. > > I would phrase it like: "When zero, the byte mode is enabled for the current profile, so the *rate* and *size* fields in both the committed and peak token buckets are specified in bytes per second and bytes, respectively. When non-zero, the packet mode is enabled for the current profile, so the *rate* and *size* fields in both the committed and peak token buckets are specified in packets per second and packets, respectively. ". Is this OK with you? Ack. > > Please also add the links to the relevant capabilities: @see struct rte_tm_node_capabilities::XYZ. Ack. > > > Regards, > Cristian