From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27117A00C2; Wed, 22 Apr 2020 13:49:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B8161D5C9; Wed, 22 Apr 2020 13:49:25 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id F40E41D5C8 for ; Wed, 22 Apr 2020 13:49:23 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03MBjXha025228; Wed, 22 Apr 2020 04:49:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=pfpt0818; bh=vIxbJJVq6QptmZd5iMRa7z7fDwaNMSsYVnXT1By1h4Q=; b=lNm5eFhN5/5Oxn1JF74fiTu6hHYE9D5q6+/NHf3JFgKSLr7tbK3v7f/RSXrInI8i522V sf48yY6WPSjbTE82OItW3jv/E5+bTSZb+S9I1wVfPWCmNU+ZP8oUMFnZG/tZk5IRsU1+ XotKL6bzOBDMi4/8bH1b+PIKpJQ2Xi9p2Ew2M13BtKufyA3kHaxV856cgrUXJURX5fmR 1l933ly0+2m63rx0dmIYF0CM2gAG7r46zYlxi7RKUOt/QD3KWK0Cm22dL4ZP4EiFX766 bnr2DrJx6eGT5xf//hLGIkQ6ldSc/bRS+Dfh2mw2DphhvUQo2dRUdXhVimdtCkM6IiHw Uw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 30jd011v7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 Apr 2020 04:49:22 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Apr 2020 04:49:20 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Apr 2020 04:49:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 22 Apr 2020 04:49:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqUfhkonknV8mt20PTdT15WGGn8u2e5Qnnby5y7+h1Tpq/pRTjRQhY8gyBLbLzBDAQk7C1h0noO9tlmzDQCFc2hYpC8X+3/pAkfXpW05ysNX5WYfNKYGZZZYQI1BE3rmQW4fGcZSrRmEf5a0XkAz0vosv4Gmgtbczzu/fDXnGV4V6TGoZVEZBXZog8/N2xq3W+XsT65QWVKtMXHWnMRwZmSE1F193/3i7Czjh9C1OATpNrryDqzjYPA1yV/4sbQNXF9Xb3vrN4XF26q6o8s/M6n8zcyOm5GsSXBr+8Eif3K7beOhucH9mAvcV6nHrl1k+KRj0T2sS53x4X2B6PzueA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vIxbJJVq6QptmZd5iMRa7z7fDwaNMSsYVnXT1By1h4Q=; b=cXjV6Q/XrcYUwUST5Yya0bXnPVj959KJoFL+jOKImAUc5UK5q0fix39ICaTnwMOIs4ZToYuufsiX3LLGU4hFy1WaQZlUk2+F4GjYGFGDTHcXsSM++bAnqX7NZbk4zAhINBU+BmuWizid/IypZiUkEVBQ98GU+Hl+FBLBU9cV6e6nijprjHIagiVjBbE44UZ9TO1CP1SI3pKfVmYTS3X45suhCRpLVUjUWEv4jJ12WZtdlF3ogu1l17N7M0tYcwuXYdlF3HvlF0AeBVsdOgLDsJ9F5ganNDx+RRaR2Csq05QzYv0iF/BLajwWM5XLcqDyjtE3BSEwFgY5b79+gosqow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vIxbJJVq6QptmZd5iMRa7z7fDwaNMSsYVnXT1By1h4Q=; b=k0zsmNhuRY+lfwhu99wckYjFXyPcuYQ1xbtGrfiQwooDOUuC3qRUIao2blgUClTxqLh3pG3pwi/MunlQGZG7/gG8IRB0cIEL6WKQR4VeuXLj+qs6Gw6hUPwJuAD8uUJ2XwLm0m3D0+4AagIkaPGWrII3wfGDX7yU2Qd7a3Jj5Rk= Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2711.namprd18.prod.outlook.com (2603:10b6:a03:10a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Wed, 22 Apr 2020 11:49:18 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2921.030; Wed, 22 Apr 2020 11:49:18 +0000 Date: Wed, 22 Apr 2020 17:19:06 +0530 From: Nithin Dabilpuram To: "Dumitrescu, Cristian" CC: Nithin Dabilpuram , "Singh, Jasvinder" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" Message-ID: <20200422114906.GC760@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200422075948.10051-1-nithind1988@gmail.com> <20200422113146.GB760@outlook.office365.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200422113146.GB760@outlook.office365.com> User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BM1PR0101CA0022.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::32) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BM1PR0101CA0022.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 22 Apr 2020 11:49:15 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c007891e-0273-46ff-2662-08d7e6b33037 X-MS-TrafficTypeDiagnostic: BYAPR18MB2711: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 03818C953D X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(6666004)(7696005)(52116002)(8676002)(66556008)(81156014)(66946007)(66476007)(6506007)(53546011)(55236004)(1076003)(2906002)(5660300002)(26005)(86362001)(966005)(107886003)(6916009)(33656002)(478600001)(54906003)(316002)(4326008)(8936002)(186003)(956004)(16526019)(55016002)(9686003)(290074003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uwq3qc7x0ud7ehcRKbeymTt09l/iuYcMaMVkMJgdQhKL78DlnpNc9n86r6l6c1BVfDebgXTh/iVw8j0U7QUoXPZ/zel9noh+tR6uATK0ki+DgKmpFWC//KsB9b3dL0MtwvzI5v0g0JiGtGfZUNJSLm33Zvb9CXLixz+4PGCNJ0ltB+jMNRX+F6ynELKTud7pt6O8mJjuMIgtAKsNOyK6aKAxfcWSAgzuXzKCYsE5A/LUCKYrJN8pJ3CmVLUdyHMfXlb/pTGKzcwKYtEg89DPaY+6xu36sXrJzp97tptoumstlNW7pWUCp6wm+tKNHWdSb/JmF27dYv2G4Erv6SZ5eQOEU9AV5VwxdZkdxmaRmqpQaiL1ixL9GzeiGv1UUG3XdFDxBST25mNmVrhY7g7nBV3/M3G8Xpy5NX1gLdnSCH9OBHlV50UX612qHF+j8WBcUw4/GBLZ1WSvpljWjPlYsQZKAW5V56wrdjGplqHtzl3I8ZeH/IkfwpKFJ5GMrp/1pQ+oJEhjN/Gzv/jgsaKJ+hl7zGWgg31VA4GSW7cQikcF4esvKc3ClUqpGP9kkFTB X-MS-Exchange-AntiSpam-MessageData: j8ahENpLOiB/Podwp6XvZ0HJn/dDlXUlfPFSkdcFD34y6cQjSHcEuVhD4WhGw10uw3H1Pv48BUMVblocNwu4TbVDHiJQUmepWEslGtCvVrjiHHYdfyioeFjRXCGlksd9Pbbd+ZKUN8kZiPSaj6/IJg== X-MS-Exchange-CrossTenant-Network-Message-Id: c007891e-0273-46ff-2662-08d7e6b33037 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2020 11:49:18.1538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bvaCX+oGrHnCriRSUAeosQ1L76+gKsglB85hC0XwCO9i0wjn3xhp86if+gjRxEd20rtZd/rXZnh+rITx3WvM4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2711 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-22_03:2020-04-22, 2020-04-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] RE: [PATCH v3] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Please also add the links to the relevant capabilities: @see struct > rte_tm_node_capabilities::XYZ. This is already added for packet_mode field in descrption of struct rte_tm_shaper_params similar to struct rte_tm_wred_params. Do you see anything missing ? On Wed, Apr 22, 2020 at 05:01:46PM +0530, Nithin Dabilpuram wrote: > On Wed, Apr 22, 2020 at 10:10:47AM +0000, Dumitrescu, Cristian wrote: > > External Email > > > > ---------------------------------------------------------------------- > > Hi Nithin, > > > > > -----Original Message----- > > > From: Nithin Dabilpuram > > > Sent: Wednesday, April 22, 2020 9:00 AM > > > To: Singh, Jasvinder ; Dumitrescu, Cristian > > > ; Thomas Monjalon > > > ; Yigit, Ferruh ; Andrew > > > Rybchenko > > > Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > > > Dabilpuram > > > Subject: [PATCH v3] ethdev: add tm support for shaper config in pkt mode > > > > > > From: Nithin Dabilpuram > > > > > > Some NIC hardware support shaper to work in packet mode i.e > > > shaping or ratelimiting traffic is in packets per second (PPS) as > > > opposed to default bytes per second (BPS). Hence this patch > > > adds support to configure shared or private shaper in packet mode, > > > provide rate in PPS and add related tm capabilities in port/level/node > > > capability structures. > > > > > > This patch also updates tm port/level/node capability structures with > > > exiting features of scheduler wfq packet mode, scheduler wfq byte mode > > > and private/shared shaper byte mode. > > > > > > SoftNIC PMD is also updated with new capabilities. > > > > > > Signed-off-by: Nithin Dabilpuram > > > --- > > > > > > v2..v3: > > > - Fix typo's > > > - Add shaper_shared_(packet, byte)_mode_supported in level and node cap > > > - Fix comment in pkt_length_adjust. > > > - Move rte_eth_softnic_tm.c capability update to patch 1/4 to > > > avoid compilations issues in node and level cap array in softnicpmd. > > > ../drivers/net/softnic/rte_eth_softnic_tm.c:782:3: warning: braces around > > > scalar initializer > > > {.nonleaf = { > > > ../drivers/net/softnic/rte_eth_softnic_tm.c:782:3: note: (near initialization > > > for ‘tm_node_cap[0].shaper_shared_byte_mode_supported’) > > > ../drivers/net/softnic/rte_eth_softnic_tm.c:782:4: error: field name not in > > > record or union initializer > > > {.nonleaf = { > > > > > > v1..v2: > > > - Add seperate capability for shaper and scheduler pktmode and bytemode. > > > - Add packet_mode field in struct rte_tm_shaper_params to indicate > > > packet mode shaper profile. > > > > > > > > > drivers/net/softnic/rte_eth_softnic_tm.c | 65 ++++++++++ > > > lib/librte_ethdev/rte_tm.h | 196 > > > ++++++++++++++++++++++++++++++- > > > 2 files changed, 259 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c > > > b/drivers/net/softnic/rte_eth_softnic_tm.c > > > index 80a470c..344819f 100644 > > > --- a/drivers/net/softnic/rte_eth_softnic_tm.c > > > +++ b/drivers/net/softnic/rte_eth_softnic_tm.c > > > > ... > > > > The softnic changes logically belong to a separate patch. I understand you are getting some build warnings, but it does not make sense to me. Are you sure there is no other way to avoid them? > I see error only because of v3 changes in node cap. There seems to be some gcc > issue with order of initializations only when next field is union. I tried both > gcc 4.8.5 and 7.3.1 > > struct test { > int a; > char b; > int c; > union { > int d; > }; > > }; > > struct test ds1 = { > .a = 10, > .b = 20, > { > .d = 40, > } > }; > > int main(void) > { > printf("ds1.a %d\n", ds1.a); > } > [root@hyd1588t430 dpdk]# make a > cc a.c -o a > a.c:20:2: warning: braces around scalar initializer [enabled by default] > { > ^ > a.c:20:2: warning: (near initialization for ‘ds1.c’) [enabled by default] > a.c:21:3: error: field name not in record or union initializer > .d = 40, > ^ > a.c:21:3: error: (near initialization for ‘ds1.c’) > make: *** [a] Error 1 > > I don't see any issue if 'd' is not inside a union. > > Similar issue is reported in kernel and similar fix was applied of initializing all the fields. > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_3033041_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=Ygf72TMZqO2D2qgWdhga8M61LRznr54ORYKCZ5iQG7w&s=n6pWrzBSgTCaznkjfH4UXjJS_CvBpX2_uY-CJ-LZcd4&e= > > > > > You are not checking that packet_mode is set to 0. Please add a check in function shaper_profile_check() (file rte_eth_softnic_tm.c) to verify that packet_mode is always set to 0. > Ack. > > > > Jasvinder, any other changes we need in Soft NIC? > > > > > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h > > > index f9c0cf3..b3865af 100644 > > > --- a/lib/librte_ethdev/rte_tm.h > > > +++ b/lib/librte_ethdev/rte_tm.h > > > > I am now fine with your additions to this file, with some minor exceptions listed below. Thank you! > > > > > @@ -250,6 +250,23 @@ struct rte_tm_capabilities { > > > */ > > > uint64_t shaper_private_rate_max; > > > > > > + /** Shaper private packet mode supported. When non-zero, this > > > parameter > > > + * indicates that there is at least one node that can be configured > > > + * with packet mode in it's private shaper. When shaper is configured > > > > Recurring typo: it's -> its > > > > Please search for all occurrences of "it's", all should be replaced with either "its" or "it is", we should have absolutely no occurrence of "it's". > Ack. My bad, I misunderstood earlier comment. Will fix in v4. > > > > ... > > > > > > > > @@ -860,6 +1034,11 @@ struct rte_tm_token_bucket { > > > * Dual rate shapers use both the committed and the peak token buckets. > > > The > > > * rate of the peak bucket has to be bigger than zero, as well as greater than > > > * or equal to the rate of the committed bucket. > > > + * > > > + * @see struct > > > rte_tm_capabilities::shaper_private_packet_mode_supported > > > + * @see struct rte_tm_capabilities::shaper_private_byte_mode_supported > > > + * @see struct > > > rte_tm_capabilities::shaper_shared_packet_mode_supported > > > + * @see struct rte_tm_capabilities::shaper_shared_byte_mode_supported > > > */ > > > struct rte_tm_shaper_params { > > > /** Committed token bucket */ > > > @@ -872,8 +1051,19 @@ struct rte_tm_shaper_params { > > > * purpose of shaping. Can be used to correct the packet length with > > > * the framing overhead bytes that are also consumed on the wire > > > (e.g. > > > * RTE_TM_ETH_FRAMING_OVERHEAD_FCS). > > > + * This field is ignored when the profile enables packet mode. > > > */ > > > int32_t pkt_length_adjust; > > > + > > > + /** When zero, the private or shared shaper that is associated to this > > > + * profile works in byte mode and hence *rate* and *size* fields in > > > + * both token bucket configurations are specified in bytes per second > > > + * and bytes respectively. > > > + * When non-zero, that private or shared shaper works in packet > > > mode and > > > + * hence *rate* and *size* fields in both token bucket configurations > > > + * are specified in packets per second and packets respectively. > > > + */ > > > + int packet_mode; > > > }; > > > > I would like to simplify this comment a bit. The reference to a shaper being associated with a profile might be confusing, as some people might incorrectly read there is a 1:1 association between shaper and profile, etc; this is described in mode details in the comment at the top of this structure. I would avoid any mentions of objects outside of the current structure. > > > > I would phrase it like: "When zero, the byte mode is enabled for the current profile, so the *rate* and *size* fields in both the committed and peak token buckets are specified in bytes per second and bytes, respectively. When non-zero, the packet mode is enabled for the current profile, so the *rate* and *size* fields in both the committed and peak token buckets are specified in packets per second and packets, respectively. ". Is this OK with you? > Ack. > > > > Please also add the links to the relevant capabilities: @see struct rte_tm_node_capabilities::XYZ. > Ack. > > > > > > Regards, > > Cristian