From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net
Subject: [dpdk-dev] [PATCH] eal: fix build on armv7
Date: Thu, 23 Apr 2020 16:24:36 +0200 [thread overview]
Message-ID: <20200423142436.12810-1-david.marchand@redhat.com> (raw)
Caught by OBS on armv7:
In file included from .../lib/librte_eal/include/rte_string_fns.h:21,
from .../lib/librte_kvargs/rte_kvargs.c:9:
.../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
67 | typedef uint64_t unaligned_uint64_t __rte_aligned(1);
| ^~~~~~~~~~~~~
.../lib/librte_eal/include/rte_common.h:68:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
68 | typedef uint32_t unaligned_uint32_t __rte_aligned(1);
| ^~~~~~~~~~~~~
.../lib/librte_eal/include/rte_common.h:69:37: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__rte_aligned'
69 | typedef uint16_t unaligned_uint16_t __rte_aligned(1);
| ^~~~~~~~~~~~~
make[3]: *** [.../mk/internal/rte.compile-pre.mk:116: rte_kvargs.o] Error 1
Fixes: f35e5b3e07b2 ("replace alignment attributes")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/include/rte_common.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h
index 733447b736..668e8b0af8 100644
--- a/lib/librte_eal/include/rte_common.h
+++ b/lib/librte_eal/include/rte_common.h
@@ -63,6 +63,11 @@ extern "C" {
__GNUC_PATCHLEVEL__)
#endif
+/**
+ * Force alignment
+ */
+#define __rte_aligned(a) __attribute__((__aligned__(a)))
+
#ifdef RTE_ARCH_STRICT_ALIGN
typedef uint64_t unaligned_uint64_t __rte_aligned(1);
typedef uint32_t unaligned_uint32_t __rte_aligned(1);
@@ -73,11 +78,6 @@ typedef uint32_t unaligned_uint32_t;
typedef uint16_t unaligned_uint16_t;
#endif
-/**
- * Force alignment
- */
-#define __rte_aligned(a) __attribute__((__aligned__(a)))
-
/**
* Force a structure to be packed
*/
--
2.23.0
next reply other threads:[~2020-04-23 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 14:24 David Marchand [this message]
2020-04-23 15:36 ` Thomas Monjalon
2020-04-24 17:35 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423142436.12810-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).