From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7EB2A00C2; Fri, 24 Apr 2020 12:53:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D5501C1EC; Fri, 24 Apr 2020 12:53:51 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 3C28F1C01B for ; Fri, 24 Apr 2020 12:53:49 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 841F65C0044; Fri, 24 Apr 2020 06:53:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 24 Apr 2020 06:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=oNv1TAKXe3HkFD6QNo7SZonjwr 1x8bQpD1sFK02or6k=; b=mLQsVJQxRAeol2E7Uyfb/SLXZScUSGQcbR9ZpUN3Z0 YpozyCgUoHAKogQjFhsMSgWz7AvRO10ggDWti5ssgu7eJb7lAzQRE2ZiT1VKenrB uwTORw3wMz9hTuLS29K6ma0YRfi9jkChC+JUHnIeHiMEI7zTTRtDu12vJbpcMmO0 DDufuCsb2mYr0aadRW9QRP97vSzjsLkoT7jQtR+rXZ74RYojnsKFposiuF+yj0xp FTO5XSur/fW+2XV+u2PDJO/Ikjv9m6kaU911CuZ8wtCPL6DOW2Im0pTc9OE6Fv6q Z9ULaby1eZxMhZnmToCT/SQssU7vpPqEvxSsCOv9VHVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oNv1TAKXe3HkFD6QN o7SZonjwr1x8bQpD1sFK02or6k=; b=bj1FCVFckKB5JoDVuxkYlqKKSmzhXkaiV dCCQ/hb3GEmjFh+PUkpHqBiIIQkSKMMcDjbz27kwCRIP2ockCOdpe3ZFgRqbAtxU Dv9pFDOjrGxqxGKVYQb+17QiVDGiMJs9m2LL30my6gvOSz9H1BEmZAdw+pqrb1/t 7V+Qbk3ZK1FqbhHPcJ0yNtr63lvu/xOHNW7TTMpIfBe89JOo9kBOzbs8oAlKLRk/ gzcvQlWrLgjSe2BpSxIgBP5MItmGK1h+MIOyI8OOqUeASEHBDCTv8PeuAhISx0UN okOtfxP25+/SnlAQfkcqrr3ghAXVSKOaWtyiBSK9ZdrtlNt6scHVg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrhedugdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhn jhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhho nhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 746393065D87; Fri, 24 Apr 2020 06:53:46 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, jerinj@marvell.com, skori@marvell.com Date: Fri, 24 Apr 2020 12:53:31 +0200 Message-Id: <20200424105331.3643868-1-thomas@monjalon.net> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] devtools: fix tracepoint symbols check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The tracepoint symbols __rte_*_trace_* are defined via a macro, adding prefix "__", so they cannot be found by map checker. Those symbols defined by RTE_TRACE_POINT and RTE_TRACE_POINT_FP are checked without the generated prefix. The same logic is applied to per-lcore variables, previously skipped. Fixes: 6c232fc44c74 ("trace: add generic tracepoints") Fixes: 4931010619fe ("trace: add alarm tracepoints") Fixes: 52f409d614a0 ("trace: add memory tracepoints") Fixes: 402321cfca9b ("trace: add memzone tracepoints") Fixes: 0baa1e01c339 ("trace: add thread tracepoints") Fixes: 05c4105738d8 ("trace: add interrupt tracepoints") Fixes: 78d44153de8f ("ethdev: add tracepoints") Fixes: 32e326869ed6 ("eventdev: add tracepoints") Fixes: 4cf30e3f3c35 ("cryptodev: add tracepoints") Fixes: 40b75c73d1c6 ("mempool: add tracepoints") Signed-off-by: Thomas Monjalon --- devtools/check-symbol-maps.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index e137d48a49..7fdfaa11c4 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -12,10 +12,14 @@ find_orphan_symbols () for map in $(find lib drivers -name '*.map') ; do for sym in $(sed -rn 's,^([^}]*_.*);,\1,p' $map) ; do if echo $sym | grep -q '^per_lcore_' ; then - continue + symsrc=${sym#per_lcore_} + elif echo $sym | grep -q '^__rte_.*_trace_' ; then + symsrc=${sym#__} + else + symsrc=$sym fi if ! grep -q -r --exclude=$(basename $map) \ - -w $sym $(dirname $map) ; then + -w $symsrc $(dirname $map) ; then echo "$map: $sym" fi done -- 2.26.0