From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8480A00C5; Sun, 26 Apr 2020 18:42:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B46051C0BD; Sun, 26 Apr 2020 18:42:09 +0200 (CEST) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 2F2A81C06D for ; Sun, 26 Apr 2020 18:42:08 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id j3so14980194ljg.8 for ; Sun, 26 Apr 2020 09:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z9YRgY/feSghF6+KjH4Fp1u/W1b+1MwQlmMgo/A/dGg=; b=MU7YTuTVgxDhu3p5a8kHNXlvuW3yqM2oF3t9dagQUlrg4i4O/eRxBBxWXRsIkxOdS1 2lq9/Bqeoj/mJ4SY294NVKTtHBYyMMDuwLEgbx3qa8wNlgu+sq1pDRhu5qq/cfm51y6J 6exs5UNCC5GlccaSwRJAFomOHvx2KeIcRLVQZA4ZxCbpLb1WaScSqKkngF2noqPn2azU GWTbJvJXaXhqBqitPCl7ENDo6AVB/GFKIvDmzPFYKxKOC6ox59uu1DHE2RA7X7D53juc 8BAkPTsRCU60rE9AQ4luyajg25OGVs6NaCoL6EW4yOkGtYFIM72g8ga2nZNmU7udLCwm pEXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z9YRgY/feSghF6+KjH4Fp1u/W1b+1MwQlmMgo/A/dGg=; b=AdNk1kVF+kqDxrGGQnUfK9aRa2fdNtv+HIGRXqsUDkROTN6W8tMRwOTGSGtWEMN3OK VePA4RsmXhbPQgPn+KKGwSEDBDk5wKNssrD+3zGD4/YuP9EnyaIPeqVXWOBaRtBarhaF aDU6OUybzX6xK24bWfYDnQ6/aY88lQGUWx6391MERDltFq/ChNFEnkuwgNedkX5XRJ+B cZ/9jnjxjq2MTOsnuhF5VL6Z8ORXB3T+Tkw2Eyd1KyoarPUQ7PB0mjLb3CJ10yS0Ol3Y QjGGUM39ruK4Ph05LBFaMRAvMJEPd5lU9XFbPZ0aLMv5OAGt+WsL2eZL7wEXLY33uSI9 NTgQ== X-Gm-Message-State: AGi0PuY39HQjSdI3pce2qp7E91rMj74ZpxHdNKyVdzcPNiDIWh2Qj+ak Nu1/51lxdrLnBDiW7xagwKU= X-Google-Smtp-Source: APiQypJzgaFjII/daRXt3MPcturNUfcwQy8VCMEEJ8ALAWk05gK3IvZXo+rwohtiV1COjDPNfVk4cw== X-Received: by 2002:a2e:953:: with SMTP id 80mr11894954ljj.276.1587919327715; Sun, 26 Apr 2020 09:42:07 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id t16sm8379462ljg.41.2020.04.26.09.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2020 09:42:07 -0700 (PDT) Date: Sun, 26 Apr 2020 19:42:06 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Pallavi Kadam , Narcisa Ana Maria Vasile , Ranjit Menon , Jerin Jacob , Sunil Kumar Kori , Harini Ramakrishnan , Omar Cardona , David Marchand Message-ID: <20200426194206.63ef1dbd@Sovereign> In-Reply-To: <17842859.gIjEHFZm8d@thomas> References: <20200426032245.2437733-1-dmitry.kozliuk@gmail.com> <20200426152819.2496610-1-dmitry.kozliuk@gmail.com> <20200426152819.2496610-4-dmitry.kozliuk@gmail.com> <17842859.gIjEHFZm8d@thomas> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: fix build by enabling trace compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-04-26 17:38 GMT+0200 Thomas Monjalon wrote: > I think this patch is doing too many things at once. > Why not just disabling tracing on Windows for now, > and apply proper patches for memory management, timer, endianness, etc > in 20.08? Sounds reasonable since tracing cannot be fully supported anyway and we're past deadline. Replacing the series with a trivial patch for now. > Some cosmetic comments below, Thanks. -- Dmitry Kozlyuk