From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE304A00BE; Mon, 27 Apr 2020 23:42:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC5F01D444; Mon, 27 Apr 2020 23:42:31 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 466D01D441 for ; Mon, 27 Apr 2020 23:42:30 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id x77so9646612pfc.0 for ; Mon, 27 Apr 2020 14:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/ONyDsTLOv8KbZ6AMrWku8BdMUOkKWthVgJLJp1vCl8=; b=t0s5BvIQOk2pMmlVaNi2nCQhtiwXHz3iWTKeI/MEBNXi6PUsJDn7c/mDJHx5c0Aprl 7PFZtp/wc6nYEi8tdNrR4mZBqOqy1SZ2dw0liKuq57fDsa74CBBNRMw3vfFakl2ep6nS BfvC1nkCkWva7R6M1b/tBCL7sdRDV0Y2JTlUlY9cIebFvE+ivWc1FEeygq4R5DIEwCSB wsVaHNZspK4B85RoPY1VclSdICrUWUfyGodYKsRYZ0I4AoKtWATlwh0icz64V5Cu4pfA DXTjCNW8r5KlzUpZp/XE8SooI+K/JvjttXcECbJv3LcEvvW7HNuoB2EDgePRoElfTIau hXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/ONyDsTLOv8KbZ6AMrWku8BdMUOkKWthVgJLJp1vCl8=; b=Fu2gsAUVyIRh3xkB4IjQTTj0hgHFlwcC41r4/0aIHeFd7T6ntw/miFf0YqAVCCBz9u ocXgiCXBcQKNvezO9y7bsbKSKajOCRIyHb+HWPCuB8b6p0Dc4FlD7YdpdtwRw5xVO05k K1f9wX0r5ca1oLV7FkTT5uRtdWqeG9jTCVfMbudkq8Byczn9OLKNp1Ag+/naLu2CoJnC ACmu9wDDPsVBhVfbyKR0a+pHLU/LAe6Ss7hSUjRkonNKBepR01Or/qMi1hs3XnHzR8W0 Xe404ZcLtiE6lboWpOM/KDOh6vgDvp0droJ8UliEIPtSJ6q99RE2N/YMLBMj1AL504Yb NP7w== X-Gm-Message-State: AGi0PuZF004e3r2EKaizv5+W5JCz/en3+gEbbcB6FSdFTMmt1Sbv3vu1 6Bbn6KF6yl0SNrzfNNY2EPRBnw== X-Google-Smtp-Source: APiQypK+XGbr2LNCiGphkZ/iG/ZbbPtSD6Z9qtYXSrndabZ+nKXw3VoKevO2ghRdfiK11swrwszuiA== X-Received: by 2002:aa7:946d:: with SMTP id t13mr18345710pfq.111.1588023749173; Mon, 27 Apr 2020 14:42:29 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k24sm12975684pfk.164.2020.04.27.14.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 14:42:28 -0700 (PDT) Date: Mon, 27 Apr 2020 10:00:24 -0700 From: Stephen Hemminger To: "Burakov, Anatoly" Cc: dev@dpdk.org Message-ID: <20200427100017.2470b009@hermes.lan> In-Reply-To: <3a9e69b8-93ea-9631-67bd-4e5408ccdfac@intel.com> References: <20200104013341.19809-1-stephen@networkplumber.org> <20200104013341.19809-10-stephen@networkplumber.org> <3a9e69b8-93ea-9631-67bd-4e5408ccdfac@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 09/14] eal: close mem config on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 27 Apr 2020 13:12:32 +0100 "Burakov, Anatoly" wrote: > On 04-Jan-20 1:33 AM, Stephen Hemminger wrote: > > Resolves file descriptor left open after rte_eal_cleanup. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_eal/linux/eal/eal.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c > > index 9ad81378f23c..e5c2a24322e9 100644 > > --- a/lib/librte_eal/linux/eal/eal.c > > +++ b/lib/librte_eal/linux/eal/eal.c > > @@ -1346,6 +1346,12 @@ rte_eal_cleanup(void) > > rte_mp_channel_cleanup(); > > eal_cleanup_config(&internal_config); > > rte_eal_log_cleanup(); > > + > > + if (mem_cfg_fd != -1) { > > + close(mem_cfg_fd); > > + mem_cfg_fd = -1; > > + } > > + > > return 0; > > } > > > > > > For the patch, > > Acked-by: Anatoly Burakov > > However i think it's incomplete, as there are also memory-backing > fbarrays that are still mapped. Also, secondary processes have their own > shadow copies of the master page table located in the mem config, so > those should be destroyed on cleanup too. > This patch set was targeting things in stages. It is not complete, some of the cleanups would be hard to do. Just getting the obvious things first.