From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 476EFA00BE; Tue, 28 Apr 2020 09:25:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1FEB1D43F; Tue, 28 Apr 2020 09:25:17 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 5E5131D42B for ; Tue, 28 Apr 2020 09:25:16 +0200 (CEST) IronPort-SDR: cK/O7QPTianZmNS0SIBJmI6c3p8wAX2//HdA8qedML3eMOvxCfFwcFA2dP99imvuueREHq7Hje GZX1+X9XW08g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 00:25:09 -0700 IronPort-SDR: tGX1SwBV2TOFwcgWUhh6347Eq+3Aq4t6+F7qEOhjC+NPeZGOCASYxw8H0bWSt5FuLvQDBYAwk0 KWjpxLb9BqoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="458692396" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga005.fm.intel.com with ESMTP; 28 Apr 2020 00:25:08 -0700 Date: Tue, 28 Apr 2020 15:17:55 +0800 From: Ye Xiaolong To: "Zhao1, Wei" Cc: "Zhang, Qi Z" , "Yang, Qiming" , "Xing, Beilei" , "Zhang, Xiao" , "dev@dpdk.org" Message-ID: <20200428071755.GD6502@intel.com> References: <20200423042213.17391-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule deletion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/24, Zhao1, Wei wrote: >It will be delete after fix in kernel to re-enable vf list feature. > >Reviewed-by: Wei Zhao > >> -----Original Message----- >> From: dev On Behalf Of Qi Zhang >> Sent: Thursday, April 23, 2020 12:22 PM >> To: Yang, Qiming >> Cc: Ye, Xiaolong ; Xing, Beilei ; >> Zhang, Xiao ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule >> deletion >> >> Ideally a rule with "TO VSI LIST" action should not be deleted when one of the >> VF reset happens. The correct action by kernel PF driver is to remove the VSI of >> a reset VF from the VSI list, but this is not implemented in kernel PF yet, so >> workaround is the DCF to prevent a rule with "To VSI List" action happens. >> >> Signed-off-by: Qi Zhang >> --- >> drivers/net/ice/base/ice_switch.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/net/ice/base/ice_switch.c >> b/drivers/net/ice/base/ice_switch.c >> index 08999d336..b9fa516b0 100644 >> --- a/drivers/net/ice/base/ice_switch.c >> +++ b/drivers/net/ice/base/ice_switch.c >> @@ -6438,6 +6438,13 @@ ice_adv_add_update_vsi_list(struct ice_hw *hw, >> cur_fltr->sw_act.fltr_act == ICE_FWD_TO_VSI_LIST)) >> return ICE_ERR_NOT_IMPL; >> >> +/* Workaround fix for unexpected rule deletion by kernel PF >> + * during VF reset. >> + */ >> +if (new_fltr->sw_act.fltr_act == ICE_FWD_TO_VSI && >> + cur_fltr->sw_act.fltr_act == ICE_FWD_TO_VSI) >> +return ICE_ERR_NOT_IMPL; >> + >> if (m_entry->vsi_count < 2 && !m_entry->vsi_list_info) { >> /* Only one entry existed in the mapping and it was not already >> * a part of a VSI list. So, create a VSI list with the old and >> -- >> 2.13.6 > Applied to dpdk-next-net-intel, Thanks.