From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F31B1A00BE; Tue, 28 Apr 2020 13:52:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFB081D59E; Tue, 28 Apr 2020 13:52:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 382F51D58F for ; Tue, 28 Apr 2020 13:52:44 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03SBeeME002370; Tue, 28 Apr 2020 04:51:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=SX2t4PuDn+Z2LFP4Gy+yEhRD79NWtD4OgXJ///7IN80=; b=KvRBcItK0KpHWCrhgVN91LQyNurGWI7SYoTcl6hmg7v7qXkKaeLanWugzPOX8DY7gn+3 FpJScv62cL8SOdRlbsVTDc9n5hTV2FlPrQ4vHg7eRWwvmTDkZhDTHmdBaGGkO9379O0x sHMIzryMw0e9AvJPXEidHPM+r4GtqL7rZS6e6OnXvfDoqDWvNrVQwGmmWuWuNzhuR8iA YUJvLZ9N02z/WHjP7hJp7aeYERuDmI55PDHcBSghPwxX1oAayCDh2P6QfRYMAn1B4Ykv UM35lAqn0kkjW8DTD2is9nvJ6B2GI9e53MqtTPy12iaiAuNGsIMlQBf67/Hk5Km5HAII tQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 30mmqmknnm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 28 Apr 2020 04:51:40 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Apr 2020 04:51:38 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 28 Apr 2020 04:51:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=attrGi7ECcGBCkfarnQJpEb2jN/FP4c6zGpuXaD3YZZuPG4+KEh39ZwLwPq5zsom5Ujy/xCBFuF6Gaxn5/BXO49fnwvn78kAAmo4Or3jdjUWv2QobCqWHEA6giwOazNYOCq3vPI3jjGGwGFDirOoYUdbjuSknz5ZHkiCoW4NI7AVuoS5zdVusUgCr9EThTHzq+tyPTThUA026G00DBAVIJf237OEC0RdnX39VsOw1FS7Kdu3nb2xGEwaCm7WSli0/EKQa7YQo7ohdk2k/ninoizVT0Ff6xVUqWzks+7SE/S+0uG9RrOHg89Tioj/7cUtqfDCxkOpcyRYZCzU/nObGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SX2t4PuDn+Z2LFP4Gy+yEhRD79NWtD4OgXJ///7IN80=; b=BkgGiM2MnAr/iLJTQOHGLOmJ2NuU8EAvOH8wZ5pum0FipBUkf/6ebyXLL8UnurzoP6PnwA8chCTkp9WJXIudCcNPIXOFCtkzsqQRJQNvMU5vV1SNJZXBr0TWiFp8cwtj1nuYsTHDldOJo/rukzr/Hff5ZD/1KOQN/zSwqkigoYFNxVZG46w7zWBHKdOp7xpMu8lYkoxOErqFNvN0c8lRQVnuawZXt5BtUFjU3zYTZmUqtTUqz/qt0/a0IU7T9n4DCXAUiqNUXYFMUW4XPgKUO56FWuVQ+e3F9nk7DjE/GwEUMCuYj4O0S1JJGNT3JE0OsAh+zzQONwvyqrcBhK+FrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SX2t4PuDn+Z2LFP4Gy+yEhRD79NWtD4OgXJ///7IN80=; b=X+nF6UJVHQrbGsePESPbv1mWgmIZh62FclyZNAJw5wTQbHOklN/eXzSi0YvkctXGdMAUu/wdM9VgdMlQMzeRRCciUGCzzKliMzRjGZmsAHiMgPVnw8boWiJMoJRAngk5NSvzsJnzy3tNmwOKdueOuPd+RxOKTnpAKZ/dqK11n4s= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=marvell.com; Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2968.namprd18.prod.outlook.com (2603:10b6:a03:111::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 11:51:37 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2937.026; Tue, 28 Apr 2020 11:51:37 +0000 Date: Tue, 28 Apr 2020 17:21:19 +0530 From: Nithin Dabilpuram To: Jerin Jacob CC: Ferruh Yigit , "Dumitrescu, Cristian" , Nithin Dabilpuram , "Singh, Jasvinder" , Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" , "Kinsella, Ray" , Neil Horman , Luca Boccassi , Kevin Traynor , David Marchand , Bruce Richardson Message-ID: <20200428115119.GA16188@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200422172104.23099-1-nithind1988@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR0101CA0072.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::34) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR0101CA0072.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Tue, 28 Apr 2020 11:51:32 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8cda3edd-6fde-4f0d-dbd9-08d7eb6a816d X-MS-TrafficTypeDiagnostic: BYAPR18MB2968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 0387D64A71 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(366004)(81156014)(54906003)(55236004)(2906002)(8676002)(33656002)(7696005)(52116002)(6506007)(53546011)(966005)(86362001)(956004)(6666004)(478600001)(16526019)(186003)(55016002)(66556008)(66946007)(26005)(9686003)(66476007)(5660300002)(7416002)(4326008)(6916009)(316002)(8936002)(1076003)(290074003); DIR:OUT; SFP:1101; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wGVbPqTIJ1iYLXYv5Nj3XAgsVFAbDfYsBKDX7oFwXKt7mC6rv37p9Zepm5M+YqbwsfMOJ4RnHHTDybn5Mptnxs8+Z4E2hX88bKdW0/y4+1QNmjZp10ZbpqR+dZddOmSpWsjt3aJz0vTTssCTgFgDOienz2Z/JAKx4DbY59dFfH+nphkzbd626U3gura5+rWeRq+U2Y2uUNjKglTtte1LnPAR8yAULgUYjyS8aVUiwjbGSAl4IQKHNiCRqTK53X2c3fbQ7OldAuIUSiZo4A97biWJDgCbUrx/SLasg86tGtBgXPhulvIirtqF/fp8FH0OR1GsCs7lErpQdLno1FemrJw16gdq9kGYzxdda7LmGZ9t88OlDExj2acz2iN/Gmun2cFTPmyx7+IeL01CGm+Nw98fhV6ue3/tRuhN8ItxbYATuXMH6RK6P4CohIJ2iiavNUxilrdEteaQ6w0Xl6oMQJeJ0stlDwzwbjxY2Wum6zn4l855bfSrFlANRszZTeyfMW0m1BHOdEmQtoUrWVRNLqtKk4oLHzwPBqEM5f56THKtMyAL8Y0TxI6NdjQrowLa X-MS-Exchange-AntiSpam-MessageData: HN5v58fq7yHqF7w+sqkzEcuehRmeX5DzpGs1msBHAQ5Y0fA36vrBSXo5JXh1/CEthSYul1+Xc20LOBh/oRkJ1F2s8aSflKZG92Fyx7npq5pTqa88mvjCT56WtZvdHypYmdqUpB930PLQwK8zaRWLbr81v3O5N2GHyBvRhIuuLHEEwlo8RZXSkSTlf+TH1GyxxgPlJ947nHRHhlHHoYHHa9+eoMRmPy+pll8SJtvIlyjFHFiMBGBWZstozz1UnE9ItNED2Ljrav66uYnKMWBDO2m3oCKLr5AAECosF+EkGkRXU84rUHaTukqm+UvI8avoKvZTFQst6y+dC9BVTbTffxC2hbT/zIEAlsB57z2lhPgAeCKz+fzWJZPTOKZvt/X36VIFQYiU+KrZcTTrAE/wvghL+SW98TBMNucR6yGxFIavY0FWcmU15scP+uGfT72e80Dx79pG6+KmPrlU4TGbCNtb4kysWIVYSzv5XlBtEG0fQSxeNtL8nREpmlj7RVhZ+1eU+4SRMC+Tzx4Gwe5l/qUUhEPEV8gojkAdZm2fKh/4d/bmbUmBPl1KzamwWG/KncpnaaNlWQHWPOP5iQVc+a6EMSKo9BdFXKZsVmh20vVTncsbNBqo7aslSJIc+GkfHBRBSm5C2hZPQ/ycgIZzP0206j+JJ2DsdPtqDSn2+inyex/FRqz1+snIFV/hiUOe+Hutheu2TjRJaDXeCkXt8SkHDKervVKEpI6P95Ldpm9SpRhtDE9BlNm3ZxQE1t6qe2upDmeLvhE0GKQg9nfWG51LSZBlTARH5z8fq/aymZE= X-MS-Exchange-CrossTenant-Network-Message-Id: 8cda3edd-6fde-4f0d-dbd9-08d7eb6a816d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2020 11:51:37.0024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kb14RXXvGLGj4Qli+jYEsz2AFjP/ZkQ3IEfR7elp+J4CpkkqJ96fK7jXdAg5mF0+hKUF8YE8PksP65MhCNqmow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2968 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-28_07:2020-04-28, 2020-04-28 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 10:29:48PM +0530, Jerin Jacob wrote: > External Email > > ---------------------------------------------------------------------- > On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit wrote: > > > > On 4/27/2020 5:29 PM, Jerin Jacob wrote: > > > On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: > > >> > > >> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > > >>> > > >>> > > >>>> -----Original Message----- > > >>>> From: Yigit, Ferruh > > >>>> Sent: Saturday, April 25, 2020 9:09 PM > > >>>> To: Dumitrescu, Cristian ; Nithin Dabilpuram > > >>>> ; Singh, Jasvinder ; > > >>>> Thomas Monjalon ; Andrew Rybchenko > > >>>> > > >>>> Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > > >>>> Dabilpuram > > >>>> Subject: Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt > > >>>> mode > > >>>> > > >>>> On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: > > >>>>> > > >>>>> > > >>>>>> -----Original Message----- > > >>>>>> From: Nithin Dabilpuram > > >>>>>> Sent: Wednesday, April 22, 2020 6:21 PM > > >>>>>> To: Singh, Jasvinder ; Dumitrescu, Cristian > > >>>>>> ; Thomas Monjalon > > >>>>>> ; Yigit, Ferruh ; Andrew > > >>>>>> Rybchenko > > >>>>>> Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > > >>>>>> Dabilpuram > > >>>>>> Subject: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt > > >>>>>> mode > > >>>>>> > > >>>>>> From: Nithin Dabilpuram > > >>>>>> > > >>>>>> Some NIC hardware support shaper to work in packet mode i.e > > >>>>>> shaping or ratelimiting traffic is in packets per second (PPS) as > > >>>>>> opposed to default bytes per second (BPS). Hence this patch > > >>>>>> adds support to configure shared or private shaper in packet mode, > > >>>>>> provide rate in PPS and add related tm capabilities in port/level/node > > >>>>>> capability structures. > > >>>>>> > > >>>>>> This patch also updates tm port/level/node capability structures with > > >>>>>> exiting features of scheduler wfq packet mode, scheduler wfq byte mode > > >>>>>> and private/shared shaper byte mode. > > >>>>>> > > >>>>>> SoftNIC PMD is also updated with new capabilities. > > >>>>>> > > >>>>>> Signed-off-by: Nithin Dabilpuram > > >>>>>> --- > > >>>>>> v3..v4: > > >>>>>> - Update text under packet_mode as per Cristian. > > >>>>>> - Update rte_eth_softnic_tm.c based on Jasvinder's comments. > > >>>>>> - Add error enum > > >>>> RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PACKET_MODE > > >>>>>> - Fix shaper_profile_check() with packet mode check > > >>>>>> - Fix typo's > > >>>>>> > > >>>>> > > >>>>> Acked-by: Cristian Dumitrescu > > >>>>> > > >>>> > > >>>> Hi Nithin, > > >>>> > > >>>> It looks like patch is causing ABI break, I am getting following warning [1], > > >>>> can you please check? > > >>>> > > >>>> [1] > > >>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__pastebin.com_XYNFg14u&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=xJB0Qb2Q-1bl0hEDeknUjJqrCDc3z-h0F0e7kj8KvvI&s=R6xtRQRRIIzAilc5z52oYjyHNlvvJB_9SUsKBkpPC6g&e= > > >>> > > >>> > > >>> Hi Ferruh, > > >>> > > >>> The RTE_TM API is marked as experimental, but it looks that this was not correctly marked when __rte_experimental ABI checker was introduced. > > >>> > > >>> It is marked as experimental at the top of the rte_tm.h, similarly to other APIs introduced around same time, but it was not correctly picked up by the ABI check procedure when later introduced, so __rte_experimental was not added to every function. > > >>> > > >> > > >> :( > > >> > > >> Is it time to mature them? > > >> > > >> As you said they are not marked as experimental both in header file (function > > >> declarations) and .map file. > > >> > > >> The problem is, they are not marked as experimental in DPDK_20.0 ABI (v19.11), > > >> so marking them as experimental now will break the ABI. Not sure what to do, > > >> cc'ed a few ABI related names for comment. > > >> > > >> For me, we need to proceed as the experimental tag removed and APIs become > > >> mature starting from v19.11, since this is what happened in practice, and remove > > >> a few existing being experimental references in the doxygen comments. > > > > > > I think, accidentally we can not make a library as NON-experimental. > > > TM never went through experimental to mature transition(see git log > > > lib/librte_ethdev/rte_tm.h) > > > It was a bug to not mark as experimental in each function in the ABI process. > > > Some of the features like packet marking are not even implemented by any HW. > > > I think, we can make API stable only all the features are implemented > > > by one or two HW. > > > > Fair enough, specially if the API is not ready yet. > > > > But they were part of stable ABI, and marking them as experimental now will > > break the old applications using these APIs. > > it is still marked as EXPERIMENTAL everywhere and API is not ready yet. > Anyway, we need to break the ABI to make it work on various HW. > I am not sure what to do? > IMO, We need to send a patch as Fixes: for the bug of not adding > __rte_experimental in each function. > > Traffic Management API - EXPERIMENTAL > M: Cristian Dumitrescu > T: git://dpdk.org/next/dpdk-next-qos > F: lib/librte_ethdev/rte_tm* Ray, Neil, David, Luca, Kevin, Ferruh Any thoughts on this proposal ? If it is fine, I can send a "Fixes:" patch to update experimental attribute in rte_tm.h for all functions so that 20.05 is having the right marking. > > > > > > > >> > > >> Ray, Neil, David, Luca, Kevin, what do you think? > >