From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30C3AA00BE; Wed, 29 Apr 2020 01:51:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 644841D688; Wed, 29 Apr 2020 01:51:14 +0200 (CEST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 167F41D67A for ; Wed, 29 Apr 2020 01:50:54 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id u10so122681lfo.8 for ; Tue, 28 Apr 2020 16:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qBI5sc1vqEeY+jIeaOsAFnga83wwkITFvMi3VZrmg8M=; b=A9zwMuzzRYnMPS6YR6Cy7lqnkzoK7dYAiBVvcg5nWlMqPWOxh48JOW7IqVtYgEB1uK q0tBscJg3KE/a9OOBTpe3e4e3g59o4vyQOPJ59eNQr2IHpg/DkRJks6RrxR1sxj30vCf mFlpMOVJPr6hYQAkYbEdrPiSEq89uvet9o4j3zUauA+WbLtwR828g+IbpnbB0rs1ap8G YNw03gmpg3Ok6zFETP3N0CPfBT7+P8iUlHB9ACchDCVvah+TRuOyXD0BFch10dUWJrw+ A32jpYIR7sRVsmjyriCZ2pezTEjPu4f6bq2VSfkKY/f/yq5Ubk+96xKN1qx+DNISLcaG vmCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qBI5sc1vqEeY+jIeaOsAFnga83wwkITFvMi3VZrmg8M=; b=UXNixlMvMmJ4DXposwm72MzkGMcl+x2lVTTPq6ydjlVD0DOIU/WzNC/KBY/ss/3Rzv FbCBwnCVxKReFxiq7IBDoGBnloh1i7h051UEwzn5PcERg8ck0n/KGzxdpijbSK4A1WzG +a4jAcozQNIG8IidsqcaZbY5p1NzFK5+DhoOj2YFJHaf71AxfiYJoqsojL392LTszdYf ddMfX7/BGgpNB7v5YZOvESA9XD7Y73qU+nDkeZ8UTZZ9QoT0j54N41JPK6mIo17i68Iz OiBvao1xqHcIjR/U9mCKj4kdWcYC9YGK7poKpvjxuwzCx3sdzghLaJcfF24/aKMot7bH 6VPg== X-Gm-Message-State: AGi0PuYBwWF0duC8DKIONTzoUlogFOrOwDD4CeWt1bA3Nm2oolrBxJ1a NzSu0ZC/S7IUIdoJB3sZpME= X-Google-Smtp-Source: APiQypKJ7hYgakFDEOfJcdfg/wsi5bKb9KNPnISj/Bk3xvY18lRKa6f7gFWMLdkUzk6cpt3mAx5ffw== X-Received: by 2002:ac2:515d:: with SMTP id q29mr20523486lfd.210.1588117853728; Tue, 28 Apr 2020 16:50:53 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z9sm870458lfd.9.2020.04.28.16.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 16:50:53 -0700 (PDT) Date: Wed, 29 Apr 2020 02:50:52 +0300 From: Dmitry Kozlyuk To: "Burakov, Anatoly" Cc: dev@dpdk.org, "Dmitry Malloy (MESHCHANINOV)" , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Message-ID: <20200429025052.693ce508@Sovereign> In-Reply-To: <458481db-0e16-7f6f-692e-1ec47c4e6845@intel.com> References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-6-dmitry.kozliuk@gmail.com> <458481db-0e16-7f6f-692e-1ec47c4e6845@intel.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 05/10] eal: introduce internal wrappers for file operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-04-17 13:24 GMT+0100 Burakov, Anatoly wrote: [snip] > > +/** Behavior on file locking conflict. */ > > +enum eal_flock_mode { > > + EAL_FLOCK_WAIT, /**< Wait until the file gets unlocked to lock it. */ > > + EAL_FLOCK_RETURN /**< Return immediately if the file is locked. */ > > +}; > > Nitpicking, but why not blocking/unblocking? The terminology seems > pretty standard. On Windows, LockFileEx() call may be non-blocking, but still configured to fail if the lock is already taken. To avoid confusion, these names reflect what the behavior will be instead of how it will be achieved. -- Dmitry Kozlyuk