From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, bluca@debian.org, david.marchand@redhat.com,
ktraynor@redhat.com
Subject: Re: [dpdk-dev] [PATCH 2/7] build: remove unnecessary variable
Date: Wed, 29 Apr 2020 11:29:27 +0100 [thread overview]
Message-ID: <20200429102927.GB1907@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <6109402.zIJbB62Pao@thomas>
O Wed, Apr 29, 2020 at 12:19:38PM +0200, Thomas Monjalon wrote:
> 29/04/2020 12:08, Bruce Richardson:
> > Since all libraries are explicitly linked as part of a build, we no longer
> > need to track ones that should be always included for linking against apps.
>
> I don't understand why telemetry was managed differently.
>
Because it was never directly called by applications - and so unneeded from
the linkers viewpoint - but still needed to be linked in to allow apps to
support emitting telemetry data. Therefore it was needed to add it
explicitly because it was never in the required dependency list for each
app.
This wasn't needed for make, since all libs were always linked into make
builds. The previous patch in this set changes meson to behave that way
too.
/Bruce
next prev parent reply other threads:[~2020-04-29 10:29 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 10:08 [dpdk-dev] [PATCH 0/7] improve DPDK static builds with meson Bruce Richardson
2020-04-29 10:08 ` [dpdk-dev] [PATCH 1/7] build: always link-whole DPDK static libraries Bruce Richardson
2020-04-29 10:18 ` Thomas Monjalon
2020-04-29 10:42 ` Bruce Richardson
2020-04-29 10:49 ` Thomas Monjalon
2020-04-29 14:04 ` Andrzej Ostruszka [C]
2020-04-29 10:08 ` [dpdk-dev] [PATCH 2/7] build: remove unnecessary variable Bruce Richardson
2020-04-29 10:19 ` Thomas Monjalon
2020-04-29 10:29 ` Bruce Richardson [this message]
2020-04-29 10:08 ` [dpdk-dev] [PATCH 3/7] devtools/test-meson-builds.sh: add pkg-config static builds Bruce Richardson
2020-04-29 10:08 ` [dpdk-dev] [PATCH 4/7] build: move pkg-config creation to separate file Bruce Richardson
2020-04-29 10:08 ` [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build Bruce Richardson
2020-04-29 10:30 ` Thomas Monjalon
2020-04-29 10:54 ` Bruce Richardson
2020-04-29 10:40 ` Luca Boccassi
2020-04-29 11:03 ` Bruce Richardson
2020-04-29 11:12 ` Luca Boccassi
2020-04-29 10:08 ` [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags Bruce Richardson
2020-04-29 10:32 ` Thomas Monjalon
2020-04-29 10:56 ` Bruce Richardson
2020-04-29 10:57 ` Thomas Monjalon
2020-04-29 10:37 ` Luca Boccassi
2020-04-29 10:58 ` Bruce Richardson
2020-04-29 11:10 ` Luca Boccassi
2020-04-29 10:08 ` [dpdk-dev] [PATCH 7/7] build/pkg-config: prevent overlinking Bruce Richardson
2020-04-29 10:34 ` Thomas Monjalon
2020-04-29 11:00 ` Bruce Richardson
2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson Bruce Richardson
2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 1/7] build: always link-whole DPDK static libraries Bruce Richardson
2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 2/7] build: remove unnecessary variable Bruce Richardson
2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 3/7] devtools/test-meson-builds.sh: add pkg-config static builds Bruce Richardson
2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 4/7] build: move pkg-config creation to separate file Bruce Richardson
2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 5/7] build/pkg-config: output driver libs first for static build Bruce Richardson
2020-05-01 13:54 ` [dpdk-dev] [PATCH v2 6/7] build/pkg-config: improve static linking flags Bruce Richardson
2020-05-01 13:54 ` [dpdk-dev] [PATCH v2 7/7] build/pkg-config: prevent overlinking Bruce Richardson
2020-05-01 14:02 ` [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson Luca Boccassi
2020-06-30 13:25 ` Pai G, Sunil
2020-06-30 16:37 ` Stokes, Ian
2020-07-01 17:29 ` Thomas Monjalon
2020-07-02 10:46 ` Stokes, Ian
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 1/7] build: always link-whole DPDK static libraries Bruce Richardson
2020-07-01 14:19 ` Thomas Monjalon
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 2/7] build: remove unnecessary variable Bruce Richardson
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 3/7] devtools/test-meson-builds.sh: add pkg-config static builds Bruce Richardson
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 4/7] build: move pkg-config creation to separate file Bruce Richardson
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 5/7] build/pkg-config: output driver libs first for static build Bruce Richardson
2020-07-01 7:50 ` Thomas Monjalon
2020-07-01 8:43 ` Bruce Richardson
2020-07-01 14:42 ` Thomas Monjalon
2020-07-01 15:16 ` Bruce Richardson
2020-07-01 15:36 ` Thomas Monjalon
2020-07-01 15:45 ` Bruce Richardson
2020-07-01 16:04 ` Thomas Monjalon
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 6/7] build/pkg-config: improve static linking flags Bruce Richardson
2020-07-01 14:30 ` Thomas Monjalon
2020-07-01 14:33 ` Thomas Monjalon
2020-07-01 14:36 ` Bruce Richardson
2020-07-01 14:45 ` Thomas Monjalon
2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 7/7] build/pkg-config: prevent overlinking Bruce Richardson
2020-07-01 7:56 ` Thomas Monjalon
2020-07-01 8:58 ` Bruce Richardson
2020-07-01 17:33 ` [dpdk-dev] [PATCH v3 0/7] improve DPDK static builds with meson Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429102927.GB1907@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).