From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B203BA00BE; Wed, 29 Apr 2020 12:29:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DA171D98D; Wed, 29 Apr 2020 12:29:37 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8A53E1D983 for ; Wed, 29 Apr 2020 12:29:35 +0200 (CEST) IronPort-SDR: yYK/jFhOl0UyxyTE//SI423B+hMUaVNvDktFExBP41/8aNhAMSV7JgULMJtxnsVp8yc9ov3wFG mA0U4gOkCXbA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 03:29:34 -0700 IronPort-SDR: 3Leqtb1GbawPVkvGm1AYsz052FxMaWgvEGELO76XOL5TB2JhwAPtWOcaM0NUGZjj1Bl5U6oGoe U3oh7js5uCCA== X-IronPort-AV: E=Sophos;i="5.73,331,1583222400"; d="scan'208";a="432512904" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.47.131]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Apr 2020 03:29:31 -0700 Date: Wed, 29 Apr 2020 11:29:27 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, bluca@debian.org, david.marchand@redhat.com, ktraynor@redhat.com Message-ID: <20200429102927.GB1907@bricha3-MOBL.ger.corp.intel.com> References: <20200429100831.398-1-bruce.richardson@intel.com> <20200429100831.398-3-bruce.richardson@intel.com> <6109402.zIJbB62Pao@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6109402.zIJbB62Pao@thomas> Subject: Re: [dpdk-dev] [PATCH 2/7] build: remove unnecessary variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" O Wed, Apr 29, 2020 at 12:19:38PM +0200, Thomas Monjalon wrote: > 29/04/2020 12:08, Bruce Richardson: > > Since all libraries are explicitly linked as part of a build, we no longer > > need to track ones that should be always included for linking against apps. > > I don't understand why telemetry was managed differently. > Because it was never directly called by applications - and so unneeded from the linkers viewpoint - but still needed to be linked in to allow apps to support emitting telemetry data. Therefore it was needed to add it explicitly because it was never in the required dependency list for each app. This wasn't needed for make, since all libs were always linked into make builds. The previous patch in this set changes meson to behave that way too. /Bruce