DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/igc: remove some useless log
@ 2020-04-30  6:23 alvinx.zhang
  2020-05-07  6:31 ` Ye Xiaolong
  2020-05-07  9:36 ` [dpdk-dev] [PATCH v2] " alvinx.zhang
  0 siblings, 2 replies; 5+ messages in thread
From: alvinx.zhang @ 2020-04-30  6:23 UTC (permalink / raw)
  To: dev; +Cc: xiaolong.ye, jia.guo, Alvin Zhang, stable

From: Alvin Zhang <alvinx.zhang@intel.com>

As title.

Fixes: 746664d546fb (net/igc: implement flow API)
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/igc/igc_txrx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index 5b269b6..4654ec4 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
 {
 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
 
-	if (!rss_filter->enable) {
-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
+	if (!rss_filter->enable)
 		return;
-	}
 
 	/* recover default RSS configuration */
 	igc_rss_configure(dev);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/igc: remove some useless log
  2020-04-30  6:23 [dpdk-dev] [PATCH] net/igc: remove some useless log alvinx.zhang
@ 2020-05-07  6:31 ` Ye Xiaolong
  2020-05-07  7:22   ` Zhang, AlvinX
  2020-05-07  9:36 ` [dpdk-dev] [PATCH v2] " alvinx.zhang
  1 sibling, 1 reply; 5+ messages in thread
From: Ye Xiaolong @ 2020-05-07  6:31 UTC (permalink / raw)
  To: alvinx.zhang; +Cc: dev, jia.guo, stable

On 04/30, alvinx.zhang@intel.com wrote:
>From: Alvin Zhang <alvinx.zhang@intel.com>
>
>As title.
>
>Fixes: 746664d546fb (net/igc: implement flow API)
>Cc: stable@dpdk.org
>
>Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>---
> drivers/net/igc/igc_txrx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
>index 5b269b6..4654ec4 100644
>--- a/drivers/net/igc/igc_txrx.c
>+++ b/drivers/net/igc/igc_txrx.c
>@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
> {
> 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
> 
>-	if (!rss_filter->enable) {
>-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
>+	if (!rss_filter->enable)
> 		return;

Why this log is useless?

>-	}
> 
> 	/* recover default RSS configuration */
> 	igc_rss_configure(dev);
>-- 
>1.8.3.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/igc: remove some useless log
  2020-05-07  6:31 ` Ye Xiaolong
@ 2020-05-07  7:22   ` Zhang, AlvinX
  0 siblings, 0 replies; 5+ messages in thread
From: Zhang, AlvinX @ 2020-05-07  7:22 UTC (permalink / raw)
  To: Ye, Xiaolong; +Cc: dev, Guo, Jia, stable

Hi Xiaolong,

The purpose of this function is to clear RSS related configuration, if the RSS filter not been enabled, this message will be printed.
The reason for printing this message is that this function will be called when the RSS flow was previously deleted and will prompt the user if RSS is not enabled. 
When rectifying later, deleting the RSS flow will not call this function, and this function is similar to another function but the other function does not print the log, 
so the other function is replaced by this function, but I forgot to delete the log.

Thanks,
Alvin


> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, May 7, 2020 2:32 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/igc: remove some useless log
> 
> On 04/30, alvinx.zhang@intel.com wrote:
> >From: Alvin Zhang <alvinx.zhang@intel.com>
> >
> >As title.
> >
> >Fixes: 746664d546fb (net/igc: implement flow API)
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> >---
> > drivers/net/igc/igc_txrx.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> >diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
> >index 5b269b6..4654ec4 100644
> >--- a/drivers/net/igc/igc_txrx.c
> >+++ b/drivers/net/igc/igc_txrx.c
> >@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void
> *rx_queue,
> >uint16_t offset)  {
> > 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
> >
> >-	if (!rss_filter->enable) {
> >-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
> >+	if (!rss_filter->enable)
> > 		return;
> 
> Why this log is useless?
> 
> >-	}
> >
> > 	/* recover default RSS configuration */
> > 	igc_rss_configure(dev);
> >--
> >1.8.3.1
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v2] net/igc: remove some useless log
  2020-04-30  6:23 [dpdk-dev] [PATCH] net/igc: remove some useless log alvinx.zhang
  2020-05-07  6:31 ` Ye Xiaolong
@ 2020-05-07  9:36 ` alvinx.zhang
  2020-05-11  2:57   ` Ye Xiaolong
  1 sibling, 1 reply; 5+ messages in thread
From: alvinx.zhang @ 2020-05-07  9:36 UTC (permalink / raw)
  To: dev; +Cc: wei.zhao1, jia.guo, xiaolong.ye

From: Alvin Zhang <alvinx.zhang@intel.com>

Some log will always be printed when the device is initialized
and shut down, which will mislead users and should be removed.

Fixes: 746664d546fb (net/igc: implement flow API)
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---

V2: update git log

 drivers/net/igc/igc_txrx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index 5b269b6..4654ec4 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
 {
 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
 
-	if (!rss_filter->enable) {
-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
+	if (!rss_filter->enable)
 		return;
-	}
 
 	/* recover default RSS configuration */
 	igc_rss_configure(dev);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/igc: remove some useless log
  2020-05-07  9:36 ` [dpdk-dev] [PATCH v2] " alvinx.zhang
@ 2020-05-11  2:57   ` Ye Xiaolong
  0 siblings, 0 replies; 5+ messages in thread
From: Ye Xiaolong @ 2020-05-11  2:57 UTC (permalink / raw)
  To: alvinx.zhang; +Cc: dev, wei.zhao1, jia.guo

On 05/07, alvinx.zhang@intel.com wrote:
>From: Alvin Zhang <alvinx.zhang@intel.com>
>
>Some log will always be printed when the device is initialized
>and shut down, which will mislead users and should be removed.
>
>Fixes: 746664d546fb (net/igc: implement flow API)
>Cc: stable@dpdk.org
>
>Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>---
>
>V2: update git log
>
> drivers/net/igc/igc_txrx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
>index 5b269b6..4654ec4 100644
>--- a/drivers/net/igc/igc_txrx.c
>+++ b/drivers/net/igc/igc_txrx.c
>@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
> {
> 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
> 
>-	if (!rss_filter->enable) {
>-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
>+	if (!rss_filter->enable)
> 		return;
>-	}
> 
> 	/* recover default RSS configuration */
> 	igc_rss_configure(dev);
>-- 
>1.8.3.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-11  3:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30  6:23 [dpdk-dev] [PATCH] net/igc: remove some useless log alvinx.zhang
2020-05-07  6:31 ` Ye Xiaolong
2020-05-07  7:22   ` Zhang, AlvinX
2020-05-07  9:36 ` [dpdk-dev] [PATCH v2] " alvinx.zhang
2020-05-11  2:57   ` Ye Xiaolong

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git