From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org, kevin.laatz@intel.com
Cc: reshma.pattan@intel.com, jerinjacobk@gmail.com,
david.marchand@redhat.com, keith.wiles@intel.com,
mb@smartsharesystems.com, thomas@monjalon.net,
stephen@networkplumber.org, bluca@debian.org,
Bruce Richardson <bruce.richardson@intel.com>,
Ciara Power <ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH v5 06/18] telemetry: introduce new telemetry functionality
Date: Thu, 30 Apr 2020 17:01:25 +0100 [thread overview]
Message-ID: <20200430160137.59135-7-ciara.power@intel.com> (raw)
In-Reply-To: <20200430160137.59135-1-ciara.power@intel.com>
From: Bruce Richardson <bruce.richardson@intel.com>
This patch introduces a new telemetry connection socket and handling
functionality. Like the existing telemetry implementation (which is
unaffected by this change) it uses a unix socket, but unlike the
existing one it does not have a fixed list of commands - instead
libraries or applications can register telemetry commands and callbacks
to provide a full-extensible solution for all kinds of telemetry across
DPDK.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
Reviewed-by: Keith Wiles <keith.wiles@intel.com>
---
v4:
- Added initial non-json internal representation prototypes.
v2:
- Added DPDK information message on client connection.
- Added /info command to get DPDK information post-connect.
- Replaced pid in socket name with v2.
- Increased output buffer size to 16k.
- Telemetry default callbacks now registered by init function.
---
lib/librte_telemetry/Makefile | 4 +
lib/librte_telemetry/meson.build | 5 +-
lib/librte_telemetry/rte_telemetry.c | 3 +
lib/librte_telemetry/rte_telemetry.h | 95 ++++-
.../rte_telemetry_version.map | 2 +
lib/librte_telemetry/telemetry.c | 326 ++++++++++++++++++
lib/librte_telemetry/telemetry_data.h | 46 +++
7 files changed, 479 insertions(+), 2 deletions(-)
create mode 100644 lib/librte_telemetry/telemetry.c
create mode 100644 lib/librte_telemetry/telemetry_data.h
diff --git a/lib/librte_telemetry/Makefile b/lib/librte_telemetry/Makefile
index 2d7e442ab0..270e1aac54 100644
--- a/lib/librte_telemetry/Makefile
+++ b/lib/librte_telemetry/Makefile
@@ -9,6 +9,9 @@ LIB = librte_telemetry.a
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
CFLAGS += -I$(RTE_SDK)/lib/librte_metrics/
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/include
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(ARCH_DIR)/include
+CFLAGS += -pthread
LDLIBS += -lrte_eal
LDLIBS += -lpthread
@@ -20,6 +23,7 @@ EXPORT_MAP := rte_telemetry_version.map
SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) := rte_telemetry.c
SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += rte_telemetry_parser.c
SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += rte_telemetry_parser_test.c
+SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += telemetry.c
# export include files
SYMLINK-$(CONFIG_RTE_LIBRTE_TELEMETRY)-include := rte_telemetry.h
diff --git a/lib/librte_telemetry/meson.build b/lib/librte_telemetry/meson.build
index 18b214a8e8..0cdae414a4 100644
--- a/lib/librte_telemetry/meson.build
+++ b/lib/librte_telemetry/meson.build
@@ -1,7 +1,10 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
-sources = files('rte_telemetry.c', 'rte_telemetry_parser.c', 'rte_telemetry_parser_test.c')
+includes = [global_inc]
+
+sources = files('rte_telemetry.c', 'rte_telemetry_parser.c', 'rte_telemetry_parser_test.c',
+ 'telemetry.c')
headers = files('rte_telemetry.h', 'rte_telemetry_internal.h', 'rte_telemetry_parser.h')
includes += include_directories('../librte_metrics')
diff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c
index 2fb8ffe873..45b6d9d948 100644
--- a/lib/librte_telemetry/rte_telemetry.c
+++ b/lib/librte_telemetry/rte_telemetry.c
@@ -503,6 +503,9 @@ rte_telemetry_init(void)
return -EPERM;
}
+ if (rte_telemetry_new_init() != 0)
+ return -1;
+
return 0;
}
diff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h
index aedb318598..66290a3fdf 100644
--- a/lib/librte_telemetry/rte_telemetry.h
+++ b/lib/librte_telemetry/rte_telemetry.h
@@ -3,19 +3,80 @@
*/
#include <stdint.h>
+#include <rte_compat.h>
#ifndef _RTE_TELEMETRY_H_
#define _RTE_TELEMETRY_H_
+/** Maximum number of telemetry callbacks. */
+#define TELEMETRY_MAX_CALLBACKS 64
+/** Maximum length for string used in object. */
+#define RTE_TEL_MAX_STRING_LEN 64
+/** Maximum length of string. */
+#define RTE_TEL_MAX_SINGLE_STRING_LEN 8192
+/** Maximum number of dictionary entries. */
+#define RTE_TEL_MAX_DICT_ENTRIES 256
+/** Maximum number of array entries. */
+#define RTE_TEL_MAX_ARRAY_ENTRIES 512
+
/**
+ * @warning
+ * @b EXPERIMENTAL: all functions in this file may change without prior notice
+ *
* @file
* RTE Telemetry
*
* The telemetry library provides a method to retrieve statistics from
- * DPDK by sending a JSON encoded message over a socket. DPDK will send
+ * DPDK by sending a request message over a socket. DPDK will send
* a JSON encoded response containing telemetry data.
***/
+/** opaque structure used internally for managing data from callbacks */
+struct rte_tel_data;
+
+/**
+ * The types of data that can be managed in arrays or dicts.
+ * For arrays, this must be specified at creation time, while for
+ * dicts this is specified implicitly each time an element is added
+ * via calling a type-specific function.
+ */
+enum rte_tel_value_type {
+ RTE_TEL_STRING_VAL, /** a string value */
+ RTE_TEL_INT_VAL, /** a signed 32-bit int value */
+ RTE_TEL_U64_VAL, /** an unsigned 64-bit int value */
+};
+
+/**
+ * This telemetry callback is used when registering a telemetry command.
+ * It handles getting and formatting information to be returned to telemetry
+ * when requested.
+ *
+ * @param cmd
+ * The cmd that was requested by the client.
+ * @param params
+ * Contains data required by the callback function.
+ * @param info
+ * The information to be returned to the caller.
+ *
+ * @return
+ * Length of buffer used on success.
+ * @return
+ * Negative integer on error.
+ */
+typedef int (*telemetry_cb)(const char *cmd, const char *params,
+ struct rte_tel_data *info);
+
+/**
+ * Used for handling data received over a telemetry socket.
+ *
+ * @param sock_id
+ * ID for the socket to be used by the handler.
+ *
+ * @return
+ * Void.
+ */
+typedef void * (*handler)(void *sock_id);
+
/**
* @warning
* @b EXPERIMENTAL: this API may change without prior notice
@@ -66,4 +127,36 @@ __rte_experimental
int32_t
rte_telemetry_selftest(void);
+/**
+ * Used when registering a command and callback function with telemetry.
+ *
+ * @param cmd
+ * The command to register with telemetry.
+ * @param fn
+ * Callback function to be called when the command is requested.
+ * @param help
+ * Help text for the command.
+ *
+ * @return
+ * 0 on success.
+ * @return
+ * -EINVAL for invalid parameters failure.
+ * @return
+ * -ENOENT if max callbacks limit has been reached.
+ */
+__rte_experimental
+int
+rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help);
+
+/**
+ * Initialize new version of Telemetry.
+ *
+ * @return
+ * 0 on success.
+ * @return
+ * -1 on failure.
+ */
+__rte_experimental
+int
+rte_telemetry_new_init(void);
#endif
diff --git a/lib/librte_telemetry/rte_telemetry_version.map b/lib/librte_telemetry/rte_telemetry_version.map
index a80058c59c..fb4e8d2989 100644
--- a/lib/librte_telemetry/rte_telemetry_version.map
+++ b/lib/librte_telemetry/rte_telemetry_version.map
@@ -3,7 +3,9 @@ EXPERIMENTAL {
rte_telemetry_cleanup;
rte_telemetry_init;
+ rte_telemetry_new_init;
rte_telemetry_parse;
+ rte_telemetry_register_cmd;
rte_telemetry_selftest;
rte_telemetry_set_metrics_fns;
diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c
new file mode 100644
index 0000000000..d1e92340dd
--- /dev/null
+++ b/lib/librte_telemetry/telemetry.c
@@ -0,0 +1,326 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+
+#include <unistd.h>
+#include <pthread.h>
+#include <sys/socket.h>
+#include <sys/un.h>
+#include <dlfcn.h>
+
+/* we won't link against libbsd, so just always use DPDKs-specific strlcpy */
+#undef RTE_USE_LIBBSD
+#include <rte_string_fns.h>
+#include <rte_common.h>
+#include <rte_spinlock.h>
+#include <rte_version.h>
+
+#include "rte_telemetry.h"
+#include "telemetry_json.h"
+#include "telemetry_data.h"
+
+#define MAX_CMD_LEN 56
+#define MAX_HELP_LEN 64
+#define MAX_OUTPUT_LEN (1024 * 16)
+
+static void *
+client_handler(void *socket);
+
+struct cmd_callback {
+ char cmd[MAX_CMD_LEN];
+ telemetry_cb fn;
+ char help[MAX_HELP_LEN];
+};
+
+struct socket {
+ int sock;
+ char path[sizeof(((struct sockaddr_un *)0)->sun_path)];
+ handler fn;
+};
+static struct socket v2_socket; /* socket for v2 telemetry */
+static char telemetry_log_error[1024]; /* Will contain error on init failure */
+/* list of command callbacks, with one command registered by default */
+static struct cmd_callback callbacks[TELEMETRY_MAX_CALLBACKS];
+static int num_callbacks; /* How many commands are registered */
+/* Used when accessing or modifying list of command callbacks */
+static rte_spinlock_t callback_sl = RTE_SPINLOCK_INITIALIZER;
+
+int
+rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help)
+{
+ int i = 0;
+
+ if (strlen(cmd) >= MAX_CMD_LEN || fn == NULL || cmd[0] != '/'
+ || strlen(help) >= MAX_HELP_LEN)
+ return -EINVAL;
+ if (num_callbacks >= TELEMETRY_MAX_CALLBACKS)
+ return -ENOENT;
+
+ rte_spinlock_lock(&callback_sl);
+ while (i < num_callbacks && strcmp(cmd, callbacks[i].cmd) > 0)
+ i++;
+ if (i != num_callbacks)
+ /* Move elements to keep the list alphabetical */
+ memmove(callbacks + i + 1, callbacks + i,
+ sizeof(struct cmd_callback) * (num_callbacks - i));
+
+ strlcpy(callbacks[i].cmd, cmd, MAX_CMD_LEN);
+ callbacks[i].fn = fn;
+ strlcpy(callbacks[i].help, help, MAX_HELP_LEN);
+ num_callbacks++;
+ rte_spinlock_unlock(&callback_sl);
+
+ return 0;
+}
+
+static void
+output_json(const char *cmd, const struct rte_tel_data *d, int s)
+{
+ char out_buf[MAX_OUTPUT_LEN];
+
+ char *cb_data_buf;
+ size_t buf_len, prefix_used, used = 0;
+ unsigned int i;
+
+ RTE_BUILD_BUG_ON(sizeof(out_buf) < MAX_CMD_LEN +
+ RTE_TEL_MAX_SINGLE_STRING_LEN + 10);
+ switch (d->type) {
+ case RTE_TEL_NULL:
+ used = snprintf(out_buf, sizeof(out_buf), "{\"%.*s\":null}",
+ MAX_CMD_LEN, cmd ? cmd : "none");
+ break;
+ case RTE_TEL_STRING:
+ used = snprintf(out_buf, sizeof(out_buf), "{\"%.*s\":\"%.*s\"}",
+ MAX_CMD_LEN, cmd,
+ RTE_TEL_MAX_SINGLE_STRING_LEN, d->data.str);
+ break;
+ case RTE_TEL_DICT:
+ prefix_used = snprintf(out_buf, sizeof(out_buf), "{\"%.*s\":",
+ MAX_CMD_LEN, cmd);
+ cb_data_buf = &out_buf[prefix_used];
+ buf_len = sizeof(out_buf) - prefix_used - 1; /* space for '}' */
+
+ used = rte_tel_json_empty_obj(cb_data_buf, buf_len, 0);
+ for (i = 0; i < d->data_len; i++) {
+ const struct tel_dict_entry *v = &d->data.dict[i];
+ switch (v->type) {
+ case RTE_TEL_STRING_VAL:
+ used = rte_tel_json_add_obj_str(cb_data_buf,
+ buf_len, used,
+ v->name, v->value.sval);
+ break;
+ case RTE_TEL_INT_VAL:
+ used = rte_tel_json_add_obj_int(cb_data_buf,
+ buf_len, used,
+ v->name, v->value.ival);
+ break;
+ case RTE_TEL_U64_VAL:
+ used = rte_tel_json_add_obj_u64(cb_data_buf,
+ buf_len, used,
+ v->name, v->value.u64val);
+ break;
+ }
+ }
+ used += prefix_used;
+ used += strlcat(out_buf + used, "}", sizeof(out_buf) - used);
+ break;
+ case RTE_TEL_ARRAY_STRING:
+ case RTE_TEL_ARRAY_INT:
+ case RTE_TEL_ARRAY_U64:
+ prefix_used = snprintf(out_buf, sizeof(out_buf), "{\"%.*s\":",
+ MAX_CMD_LEN, cmd);
+ cb_data_buf = &out_buf[prefix_used];
+ buf_len = sizeof(out_buf) - prefix_used - 1; /* space for '}' */
+
+ used = rte_tel_json_empty_array(cb_data_buf, buf_len, 0);
+ for (i = 0; i < d->data_len; i++)
+ if (d->type == RTE_TEL_ARRAY_STRING)
+ used = rte_tel_json_add_array_string(
+ cb_data_buf,
+ buf_len, used,
+ d->data.array[i].sval);
+ else if (d->type == RTE_TEL_ARRAY_INT)
+ used = rte_tel_json_add_array_int(cb_data_buf,
+ buf_len, used,
+ d->data.array[i].ival);
+ else if (d->type == RTE_TEL_ARRAY_U64)
+ used = rte_tel_json_add_array_u64(cb_data_buf,
+ buf_len, used,
+ d->data.array[i].u64val);
+ used += prefix_used;
+ used += strlcat(out_buf + used, "}", sizeof(out_buf) - used);
+ break;
+ }
+ if (write(s, out_buf, used) < 0)
+ perror("Error writing to socket");
+}
+
+static void
+perform_command(telemetry_cb fn, const char *cmd, const char *param, int s)
+{
+ struct rte_tel_data data;
+
+ int ret = fn(cmd, param, &data);
+ if (ret < 0) {
+ char out_buf[MAX_CMD_LEN + 10];
+ int used = snprintf(out_buf, sizeof(out_buf), "{\"%.*s\":null}",
+ MAX_CMD_LEN, cmd ? cmd : "none");
+ if (write(s, out_buf, used) < 0)
+ perror("Error writing to socket");
+ return;
+ }
+ output_json(cmd, &data, s);
+}
+
+static int
+unknown_command(const char *cmd __rte_unused, const char *params __rte_unused,
+ struct rte_tel_data *d)
+{
+ return d->type = RTE_TEL_NULL;
+}
+
+static void *
+client_handler(void *sock_id)
+{
+ int s = (int)(uintptr_t)sock_id;
+ char buffer[1024];
+ char info_str[1024];
+ snprintf(info_str, sizeof(info_str),
+ "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}",
+ rte_version(), getpid(), MAX_OUTPUT_LEN);
+ if (write(s, info_str, strlen(info_str)) < 0) {
+ close(s);
+ return NULL;
+ }
+
+ /* receive data is not null terminated */
+ int bytes = read(s, buffer, sizeof(buffer) - 1);
+ while (bytes > 0) {
+ buffer[bytes] = 0;
+ const char *cmd = strtok(buffer, ",");
+ const char *param = strtok(NULL, ",");
+ telemetry_cb fn = unknown_command;
+ int i;
+
+ if (cmd && strlen(cmd) < MAX_CMD_LEN) {
+ rte_spinlock_lock(&callback_sl);
+ for (i = 0; i < num_callbacks; i++)
+ if (strcmp(cmd, callbacks[i].cmd) == 0) {
+ fn = callbacks[i].fn;
+ break;
+ }
+ rte_spinlock_unlock(&callback_sl);
+ }
+ perform_command(fn, cmd, param, s);
+
+ bytes = read(s, buffer, sizeof(buffer) - 1);
+ }
+ close(s);
+ return NULL;
+}
+
+static void *
+socket_listener(void *socket)
+{
+ while (1) {
+ pthread_t th;
+ struct socket *s = (struct socket *)socket;
+ int s_accepted = accept(s->sock, NULL, NULL);
+ if (s_accepted < 0) {
+ snprintf(telemetry_log_error,
+ sizeof(telemetry_log_error),
+ "Error with accept, telemetry thread quitting\n");
+ return NULL;
+ }
+ pthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);
+ pthread_detach(th);
+ }
+ return NULL;
+}
+
+static inline char *
+get_socket_path(const char *runtime_dir, const int version)
+{
+ static char path[PATH_MAX];
+ snprintf(path, sizeof(path), "%s/dpdk_telemetry.v%d",
+ strlen(runtime_dir) ? runtime_dir : "/tmp", version);
+ return path;
+}
+
+static void
+unlink_sockets(void)
+{
+ if (v2_socket.path[0])
+ unlink(v2_socket.path);
+}
+
+static int
+create_socket(char *path)
+{
+ int sock = socket(AF_UNIX, SOCK_SEQPACKET, 0);
+ if (sock < 0) {
+ snprintf(telemetry_log_error, sizeof(telemetry_log_error),
+ "Error with socket creation, %s",
+ strerror(errno));
+ return -1;
+ }
+
+ struct sockaddr_un sun = {.sun_family = AF_UNIX};
+ strlcpy(sun.sun_path, path, sizeof(sun.sun_path));
+ unlink(sun.sun_path);
+ if (bind(sock, (void *) &sun, sizeof(sun)) < 0) {
+ snprintf(telemetry_log_error, sizeof(telemetry_log_error),
+ "Error binding socket: %s",
+ strerror(errno));
+ sun.sun_path[0] = 0;
+ goto error;
+ }
+
+ if (listen(sock, 1) < 0) {
+ snprintf(telemetry_log_error, sizeof(telemetry_log_error),
+ "Error calling listen for socket: %s",
+ strerror(errno));
+ goto error;
+ }
+
+ return sock;
+
+error:
+ close(sock);
+ unlink_sockets();
+ return -1;
+}
+
+static int
+telemetry_v2_init(const char *runtime_dir)
+{
+ pthread_t t_new;
+
+ v2_socket.fn = client_handler;
+ if (strlcpy(v2_socket.path, get_socket_path(runtime_dir, 2),
+ sizeof(v2_socket.path)) >= sizeof(v2_socket.path)) {
+ snprintf(telemetry_log_error, sizeof(telemetry_log_error),
+ "Error with socket binding, path too long");
+ return -1;
+ }
+
+ v2_socket.sock = create_socket(v2_socket.path);
+ if (v2_socket.sock < 0)
+ return -1;
+ pthread_create(&t_new, NULL, socket_listener, &v2_socket);
+ atexit(unlink_sockets);
+
+ return 0;
+}
+
+int32_t
+rte_telemetry_new_init(void)
+{
+ const char *error_str;
+ if (telemetry_v2_init(rte_eal_get_runtime_dir()) != 0) {
+ error_str = telemetry_log_error;
+ printf("Error initialising telemetry - %s", error_str);
+ return -1;
+ }
+ return 0;
+}
diff --git a/lib/librte_telemetry/telemetry_data.h b/lib/librte_telemetry/telemetry_data.h
new file mode 100644
index 0000000000..ff3a371a33
--- /dev/null
+++ b/lib/librte_telemetry/telemetry_data.h
@@ -0,0 +1,46 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+
+#ifndef _TELEMETRY_DATA_H_
+#define _TELEMETRY_DATA_H_
+
+#include <inttypes.h>
+#include "rte_telemetry.h"
+
+enum tel_container_types {
+ RTE_TEL_NULL, /** null, used as error value */
+ RTE_TEL_STRING, /** basic string type, no included data */
+ RTE_TEL_DICT, /** name-value pairs, of individual value type */
+ RTE_TEL_ARRAY_STRING, /** array of string values only */
+ RTE_TEL_ARRAY_INT, /** array of signed, 32-bit int values */
+ RTE_TEL_ARRAY_U64, /** array of unsigned 64-bit int values */
+};
+
+/* each type here must have an equivalent enum in the value types enum in
+ * telemetry.h and an array type defined above, and have appropriate
+ * type assignment in the RTE_TEL_data_start_array() function
+ */
+union tel_value {
+ char sval[RTE_TEL_MAX_STRING_LEN];
+ int ival;
+ uint64_t u64val;
+};
+
+struct tel_dict_entry {
+ char name[RTE_TEL_MAX_STRING_LEN];
+ enum rte_tel_value_type type;
+ union tel_value value;
+};
+
+struct rte_tel_data {
+ enum tel_container_types type;
+ unsigned int data_len; /* for array or object, how many items */
+ union {
+ char str[RTE_TEL_MAX_SINGLE_STRING_LEN];
+ struct tel_dict_entry dict[RTE_TEL_MAX_DICT_ENTRIES];
+ union tel_value array[RTE_TEL_MAX_ARRAY_ENTRIES];
+ } data; /* data container */
+};
+
+#endif
--
2.17.1
next prev parent reply other threads:[~2020-04-30 16:03 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 17:18 [dpdk-dev] [PATCH 00/12] update and simplify telemetry library Ciara Power
2020-03-19 17:18 ` [dpdk-dev] [PATCH 01/12] telemetry: move code to metrics for later reuse Ciara Power
2020-03-19 17:18 ` [dpdk-dev] [PATCH 02/12] metrics: reduce code taken from telemetry Ciara Power
2020-03-19 17:18 ` [dpdk-dev] [PATCH 03/12] telemetry: invert dependency on metrics Ciara Power
2020-03-19 17:18 ` [dpdk-dev] [PATCH 04/12] telemetry: introduce new telemetry functionality Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 05/12] ethdev: add callback support for telemetry Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 06/12] usertools: add new telemetry python script Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 07/12] rawdev: add callback support for telemetry Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 08/12] examples/l3fwd-power: enable use of new telemetry Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 09/12] telemetry: introduce telemetry backward compatibility Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 10/12] telemetry: remove existing telemetry files Ciara Power
2020-03-19 17:19 ` [dpdk-dev] [PATCH 11/12] lib: add telemetry as eal dependency Ciara Power
2020-03-20 12:03 ` Jerin Jacob
2020-03-20 13:50 ` Bruce Richardson
2020-03-19 17:19 ` [dpdk-dev] [PATCH 12/12] eal: add eal telemetry callbacks Ciara Power
2020-04-01 15:42 ` [dpdk-dev] [PATCH 00/12] update and simplify telemetry library David Marchand
2020-04-01 16:16 ` Bruce Richardson
2020-04-02 8:30 ` Morten Brørup
2020-04-02 9:38 ` Thomas Monjalon
2020-04-01 16:48 ` Wiles, Keith
2020-04-02 10:09 ` Bruce Richardson
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 00/16] " Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 01/16] build: add arch-specific header path to global includes Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 02/16] telemetry: move code to metrics for later reuse Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 03/16] metrics: reduce code taken from telemetry Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 04/16] telemetry: invert dependency on metrics Ciara Power
2020-04-10 16:15 ` Pattan, Reshma
2020-04-15 9:50 ` Power, Ciara
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 05/16] telemetry: introduce new telemetry functionality Ciara Power
2020-04-08 17:56 ` Wiles, Keith
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 06/16] telemetry: add utility functions for creating json Ciara Power
2020-04-08 18:12 ` Wiles, Keith
2020-04-09 8:19 ` Bruce Richardson
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 07/16] app/test: add telemetry json tests Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support for telemetry Ciara Power
2020-04-08 18:16 ` Wiles, Keith
2020-04-09 8:20 ` Bruce Richardson
2020-04-10 9:57 ` [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support fortelemetry Morten Brørup
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 09/16] usertools: add new telemetry python script Ciara Power
2020-04-10 9:43 ` Pattan, Reshma
2020-04-10 9:54 ` Bruce Richardson
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 10/16] rawdev: add callback support for telemetry Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 11/16] examples/l3fwd-power: enable use of new telemetry Ciara Power
2020-04-10 8:42 ` Pattan, Reshma
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 12/16] telemetry: introduce telemetry backward compatibility Ciara Power
2020-04-10 17:00 ` Pattan, Reshma
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 13/16] telemetry: remove existing telemetry files Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 14/16] lib: add telemetry as eal dependency Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 15/16] eal: add eal telemetry callbacks Ciara Power
2020-04-08 16:49 ` [dpdk-dev] [PATCH v2 16/16] doc: update telemetry documentation Ciara Power
2020-04-08 18:03 ` [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library Thomas Monjalon
2020-04-09 9:19 ` Bruce Richardson
2020-04-09 9:37 ` Thomas Monjalon
2020-04-10 14:39 ` Wiles, Keith
2020-04-10 14:51 ` Thomas Monjalon
2020-04-10 14:59 ` Wiles, Keith
2020-04-23 10:30 ` Luca Boccassi
2020-04-23 10:44 ` Thomas Monjalon
2020-04-23 11:46 ` Luca Boccassi
2020-04-10 10:49 ` Morten Brørup
2020-04-10 14:21 ` Wiles, Keith
2020-04-10 18:06 ` [dpdk-dev] [PATCH v2 00/16] update and simplify telemetrylibrary Morten Brørup
2020-04-20 13:18 ` Bruce Richardson
2020-04-20 14:55 ` [dpdk-dev] [PATCH v2 00/16] update and simplifytelemetrylibrary Morten Brørup
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 00/17] update and simplify telemetry library Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 01/17] build: add arch-specific header path to global includes Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 02/17] telemetry: move code to metrics for later reuse Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 03/17] metrics: reduce code taken from telemetry Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 04/17] telemetry: invert dependency on metrics Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 05/17] telemetry: introduce new telemetry functionality Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 06/17] telemetry: add utility functions for creating json Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 07/17] app/test: add telemetry json tests Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 08/17] ethdev: add callback support for telemetry Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 09/17] usertools: add new telemetry python script Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 10/17] rawdev: add callback support for telemetry Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 11/17] examples/l3fwd-power: enable use of new telemetry Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 12/17] telemetry: introduce telemetry backward compatibility Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 13/17] telemetry: remove existing telemetry files Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 14/17] lib: add telemetry as eal dependency Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 15/17] eal: remove rte-option infrastructure Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 16/17] eal: add eal telemetry callbacks Ciara Power
2020-04-21 12:39 ` [dpdk-dev] [PATCH v3 17/17] doc: update telemetry documentation Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 00/18] update and simplify telemetry library Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 01/18] build: add arch-specific header path to global includes Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 02/18] telemetry: move code to metrics for later reuse Ciara Power
2020-04-24 15:29 ` Stephen Hemminger
2020-04-24 15:49 ` Bruce Richardson
2020-04-27 9:53 ` Power, Ciara
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 03/18] metrics: reduce code taken from telemetry Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 04/18] telemetry: invert dependency on metrics Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 05/18] telemetry: add utility functions for creating json Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 06/18] telemetry: introduce new telemetry functionality Ciara Power
2020-04-24 20:50 ` Wiles, Keith
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 07/18] telemetry: add functions for returning callback data Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 08/18] telemetry: add default callback commands Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 09/18] usertools: add new telemetry python script Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 10/18] ethdev: add callback support for telemetry Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 11/18] rawdev: " Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 12/18] examples/l3fwd-power: enable use of new telemetry Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 13/18] telemetry: introduce telemetry backward compatibility Ciara Power
2020-04-24 20:59 ` Wiles, Keith
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 14/18] telemetry: remove existing telemetry files Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 15/18] lib: add telemetry as eal dependency Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 16/18] eal: remove rte-option infrastructure Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 17/18] eal: add eal telemetry callbacks Ciara Power
2020-04-24 12:41 ` [dpdk-dev] [PATCH v4 18/18] doc: update telemetry documentation Ciara Power
2020-04-24 21:09 ` [dpdk-dev] [PATCH v4 00/18] update and simplify telemetry library Wiles, Keith
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 " Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 01/18] build: add arch-specific header path to global includes Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 02/18] telemetry: move code to metrics for later reuse Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 03/18] metrics: reduce code taken from telemetry Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 04/18] telemetry: invert dependency on metrics Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 05/18] telemetry: add utility functions for creating json Ciara Power
2020-04-30 16:01 ` Ciara Power [this message]
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 07/18] telemetry: add functions for returning callback data Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 08/18] telemetry: add default callback commands Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 09/18] usertools: add new telemetry python script Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 10/18] ethdev: add callback support for telemetry Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 11/18] rawdev: " Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 12/18] examples/l3fwd-power: enable use of new telemetry Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 13/18] telemetry: introduce telemetry backward compatibility Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 14/18] telemetry: remove existing telemetry files Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 15/18] lib: add telemetry as eal dependency Ciara Power
2020-05-10 22:29 ` Thomas Monjalon
2020-05-11 8:41 ` Bruce Richardson
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 16/18] eal: remove rte-option infrastructure Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 17/18] eal: add eal telemetry callbacks Ciara Power
2020-04-30 16:01 ` [dpdk-dev] [PATCH v5 18/18] doc: update telemetry documentation Ciara Power
2020-05-01 14:41 ` [dpdk-dev] [PATCH v5 00/18] update and simplify telemetry library Wiles, Keith
2020-05-10 22:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430160137.59135-7-ciara.power@intel.com \
--to=ciara.power@intel.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=keith.wiles@intel.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).