From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65813A046B; Thu, 30 Apr 2020 21:10:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C12CF1DC05; Thu, 30 Apr 2020 21:09:16 +0200 (CEST) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id CE9221DBD2 for ; Thu, 30 Apr 2020 21:09:10 +0200 (CEST) Received: by mail-pj1-f67.google.com with SMTP id a7so1184073pju.2 for ; Thu, 30 Apr 2020 12:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SYVPClk50VHw4w/TIB5gWngK2d+zI8GbigTwmXk3QTA=; b=eTck8MvKtY+pcpxBZ4BzdkypA3lzGMKTCpsAbZmJNIxxtZHNuVFFOAcCOzf+jWROem msdpxxb58UITvXOQ4Pll8wZJSGaRIKje1BiWgjR1JaqCCnax/7hpgy1qTjq9MbVy911b 11mom9J+qS6uFoVz9AKAGbj9vSerT1ghKF29KEbXGgDfK0SE5UIVLnwHYL+sbwVU2L5Z KBfEb7vYJsGovYqO8P8VTSvjzTLWmOSG3StZDbPwVH4W7LFj8DC3Ac7FKwj7XLChmFCt 66Szo+M8JAKOlQ4U5yfUxVLIMx3/QK4+H6s4UWbSbthfrFjI6HU2H2zq200PemrwVyyF mQlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SYVPClk50VHw4w/TIB5gWngK2d+zI8GbigTwmXk3QTA=; b=L23C7t2osRs2KI5LU+jXjOsFuQCmgJxzYGlLFDzhvxox5z6LD4DtoA54ddZb457ymq 7EVXOOFfIW1grB86BOBlWVSG82U0yb97utXwqN9KCaX5d1PZiUpRq7Nak+rxvmNu6WW7 tTEJwROwf9xanPaPeMKliifQXdrAPAvMr1VJDJZ31g5Mx6iT7OjTyEHjqhGS6bx1zWhx RJA1Ic840J7cPR6zfO5ITOfeDpJJUsIVdlexFxHmz/Dbb4/5sBElV/IDj+TnmyKFz6so FGp4M/SSsbya102Pzv5vcF8DED4aOvOmcwD6XB+93kUEXxko1dqgxGMRUNWM8rEb9jwa 4+fw== X-Gm-Message-State: AGi0PubqE5H7435Hrtchj55yR10suoz9Sbed5CNbbDojwfDCqDFVQSOs UNszdi9pgTxIuKjh/IqzKClyF0lZ67neAA== X-Google-Smtp-Source: APiQypLbvPySPMAkirIbcFX1ug66hTyfiU+/GYj7EgXPK/t4yZ8jf8RJSkymaJaknjlFWld0t/+lkA== X-Received: by 2002:a17:902:a586:: with SMTP id az6mr438796plb.201.1588273749509; Thu, 30 Apr 2020 12:09:09 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id fy21sm452075pjb.25.2020.04.30.12.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 12:09:08 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 30 Apr 2020 12:08:52 -0700 Message-Id: <20200430190853.498-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200430190853.498-1-stephen@networkplumber.org> References: <20200430190853.498-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 6/7] net/netvsc: do RSS across rx queue only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If number of tx queues is greater than the number of rx queues; the driver ends up allocating more channels than rx queues. The problem is that the RSS indirection table is programed such that some packets will end up on a channel that would never be polled. The fix is to limit the RSS indirection table by number of rx queues not channels. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 7bf5465ce5e7..60102362e124 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -575,7 +575,7 @@ static int hn_dev_configure(struct rte_eth_dev *dev) dev->data->nb_tx_queues); for (i = 0; i < NDIS_HASH_INDCNT; i++) - hv->rss_ind[i] = i % hv->num_queues; + hv->rss_ind[i] = i % dev->data->nb_rx_queues; hn_rss_hash_init(hv, rss_conf); -- 2.20.1