From: Harry van Haaren <harry.van.haaren@intel.com>
To: dev@dpdk.org
Cc: bernard.iremonger@intel.com, ferruh.yigit@intel.com,
Harry van Haaren <harry.van.haaren@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems
Date: Fri, 1 May 2020 12:08:14 +0100 [thread overview]
Message-ID: <20200501110814.67384-1-harry.van.haaren@intel.com> (raw)
This commit fixes failures of the flow_classify_autotest when
ran on dual-socket servers, as the sample application does not
support more than a single socket. Increasing the NB_SOCKETS
value allows the test to run successfully.
Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot
easily statically allocate the array. As a bugfix patch, I'd
prefer not add complexity of dynamically allocating based on
rte_socket_count(), hence just increasing the value seems the
most pragmatic fix.
Fixes: tag is a bit complex, code was moved in previous commit.
This fixes tag is against when the NB_SOCKET = 1 was introduced.
Cc: stable@dpdk.org
---
app/test/test_flow_classify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
index ff5265c6a..ef0b6fdd5 100644
--- a/app/test/test_flow_classify.c
+++ b/app/test/test_flow_classify.c
@@ -23,7 +23,7 @@
#define FLOW_CLASSIFY_MAX_RULE_NUM 100
#define MAX_PKT_BURST 32
-#define NB_SOCKETS 1
+#define NB_SOCKETS 4
#define MEMPOOL_CACHE_SIZE 256
#define MBUF_SIZE 512
#define NB_MBUF 512
--
2.17.1
next reply other threads:[~2020-05-01 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 11:08 Harry van Haaren [this message]
2020-05-01 11:50 ` Ferruh Yigit
2020-05-05 11:02 ` Iremonger, Bernard
2020-05-11 20:56 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501110814.67384-1-harry.van.haaren@intel.com \
--to=harry.van.haaren@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).