From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5900A04AC; Fri, 1 May 2020 13:07:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 269AE1D9A2; Fri, 1 May 2020 13:07:28 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 754F81D92D; Fri, 1 May 2020 13:07:26 +0200 (CEST) IronPort-SDR: vwWPvtcwUpGfYKORMc+CUUW01qXIKjL+JCTT8Z3yRfq1z7XfC0j551ZIm0T/YnEUDGQpnPktsF gxFEkTLUVX6Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 04:07:25 -0700 IronPort-SDR: si7JB256I6EXtIq0FgPHsCWgAtQ7gkCyf19fYYcycnPdGpgt5o+GURzrZsMZo7dr9ygaNgqDU4 la4JgiLN++MQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,339,1583222400"; d="scan'208";a="433284698" Received: from silpixa00399779.ir.intel.com (HELO silpixa00399779.ger.corp.intel.com) ([10.237.222.209]) by orsmga005.jf.intel.com with ESMTP; 01 May 2020 04:07:23 -0700 From: Harry van Haaren To: dev@dpdk.org Cc: bernard.iremonger@intel.com, ferruh.yigit@intel.com, Harry van Haaren , stable@dpdk.org Date: Fri, 1 May 2020 12:08:14 +0100 Message-Id: <20200501110814.67384-1-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit fixes failures of the flow_classify_autotest when ran on dual-socket servers, as the sample application does not support more than a single socket. Increasing the NB_SOCKETS value allows the test to run successfully. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Signed-off-by: Harry van Haaren --- DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot easily statically allocate the array. As a bugfix patch, I'd prefer not add complexity of dynamically allocating based on rte_socket_count(), hence just increasing the value seems the most pragmatic fix. Fixes: tag is a bit complex, code was moved in previous commit. This fixes tag is against when the NB_SOCKET = 1 was introduced. Cc: stable@dpdk.org --- app/test/test_flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c index ff5265c6a..ef0b6fdd5 100644 --- a/app/test/test_flow_classify.c +++ b/app/test/test_flow_classify.c @@ -23,7 +23,7 @@ #define FLOW_CLASSIFY_MAX_RULE_NUM 100 #define MAX_PKT_BURST 32 -#define NB_SOCKETS 1 +#define NB_SOCKETS 4 #define MEMPOOL_CACHE_SIZE 256 #define MBUF_SIZE 512 #define NB_MBUF 512 -- 2.17.1