From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A7A2A04AD; Fri, 1 May 2020 15:17:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79A261D905; Fri, 1 May 2020 15:17:43 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 7ACAA1D6FD for <dev@dpdk.org>; Fri, 1 May 2020 15:17:41 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 041DBQ4n018488; Fri, 1 May 2020 06:17:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=5RRqhR/B0eJVPP94ig1ed3nSOYa46jn9M2vaqk2aNZI=; b=ggyDGUc7AhMpjajGSNJWbdrw/sczv4O2bhBhi8hMDAPwcjRLdjqV7nq0+EtlfFqUCzHX mYDIzmrY+YH84Nba/Y10UVxs3++o31CYLYzDty9R3oCSuAZGLX9Vdz1zX44pB1VJZm8C iXy3YyBgq/oHuPqDXRfOtoQEgAY+TbejtiCIAhp0BX2NfbTvhv/MHqyyTvzkojLRFp2e OVzYBdCuR5B2uk730B686caYgXHt2f8LFvMvqju/L6e8HcShrC7v/Di412PIA6kkxWRy TsxaC27TawFN+59IQk4L8P5Cwliml/keL+wYwGHLMg9kkYYKaG4U6bif9hUWat7c1SoV 1g== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30r7em2mhm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 May 2020 06:17:34 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 1 May 2020 06:17:29 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 1 May 2020 06:17:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBNxqK8cYODwBzgKwIC/ZgTuQsXcZBWwA2HlqILO4lctglMla3Up3Iu9fdgHiYiO9EUyGytpkTfCDONcsIP5XJJ83UjJsdQKtb5bAWetZu3d7wYX/J5/FJITyO3slEMmLyWb3E6kC2wklm9C/K3Q3hLf03E3NGTd7fhzdMWeuNugmAt2X3lhdBKj5CranukkCM1AZOr9lraNTuhfSrxheCp/Enqp6GMKAB+KLqlSqxuVExdcXTsGmR2hbTLcDspBbsggvk51KTO40jxb3JRXaUwCXuKKlynPVdYHM2ozcvNWL5wnMyUBTHf9grn5XbCSwaxuysBOXZh2eujrcoU4uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RRqhR/B0eJVPP94ig1ed3nSOYa46jn9M2vaqk2aNZI=; b=KO/ruzKU44Glm9m+nZXmSkS94h0s1mSBq8v1PHEXkQMHEJ//2CJgyDO6tiOAQBPKt9fBueBeVjTisDid5HdZvytJwD5eJ0xQDAfQWPG+GcJbkS8Gkd/va+nhn28dARV2GWXcRqzIMt3x2nkzMUmAaf4xtlI4NXDCFees7HL14KoeftX0v1hu3RxHpaeOsWquWrCryegTQEr3zoHR7J8pNNWqBAB5t7cpR7Uk64MOZKQmAeFbwWA1Zj9TFENQz0Jb0Ea7gx+Q2HYvlpThdPRUWm1Web9gQF+/cGjbsJ5TZSmVv5VAa1sZ2y4H5C4ud2wjCkXxZcXvnxcYfIEagzPv6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RRqhR/B0eJVPP94ig1ed3nSOYa46jn9M2vaqk2aNZI=; b=BoSUfaIzad+gSvYtFqqyHkNv1emS3cGDa6tNPLPluupUPTfnZv7ScNBD5vANGOCyp5CwB2JOTq2KCiGpobW3JLEtJ9mqqm4LsGutT8iiTniApt1z7DWUGEWdudwrFdrfOVVP1n1udCAJdivLMSLAZ2AL4M7u3HbVMyOGqaXE0l8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2933.namprd18.prod.outlook.com (2603:10b6:a03:10e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Fri, 1 May 2020 13:17:28 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2937.028; Fri, 1 May 2020 13:17:27 +0000 Date: Fri, 1 May 2020 18:46:58 +0530 From: Nithin Dabilpuram <ndabilpuram@marvell.com> To: Ferruh Yigit <ferruh.yigit@intel.com> CC: Bruce Richardson <bruce.richardson@intel.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob <jerinjacobk@gmail.com>, Luca Boccassi <bluca@debian.org>, Nithin Dabilpuram <nithind1988@gmail.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>, "kkanas@marvell.com" <kkanas@marvell.com>, "Kinsella, Ray" <ray.kinsella@intel.com>, Neil Horman <nhorman@tuxdriver.com>, Kevin Traynor <ktraynor@redhat.com>, David Marchand <david.marchand@redhat.com> Message-ID: <20200501131634.GA24835@outlook.office365.com> References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200428144535.GC1897@bricha3-MOBL.ger.corp.intel.com> <19c8b69f68bcdb7ac23126e63456223f7aff0465.camel@debian.org> <1923738.gORTcIGjah@thomas> <BYAPR11MB2935CCDB5A93D2CF0F9EB2AEEBAD0@BYAPR11MB2935.namprd11.prod.outlook.com> <20200429090354.GA1903@bricha3-MOBL.ger.corp.intel.com> <74165680-6b05-a7c3-21a7-c66372b462e4@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74165680-6b05-a7c3-21a7-c66372b462e4@intel.com> User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BM1PR01CA0127.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::21) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BM1PR01CA0127.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Fri, 1 May 2020 13:17:23 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 107be2ac-af22-4c0b-606c-08d7edd1febd X-MS-TrafficTypeDiagnostic: BYAPR18MB2933: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <BYAPR18MB29334842B0D076EE7B9CD2E4AFAB0@BYAPR18MB2933.namprd18.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0390DB4BDA X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M1dgOXDQSaid42pgGtyuia4B2yYHHDPJ9XELuIc2Jf7eas0OXHLz1rVbK8SuBr9Cks37R6V6jWLjGKwhP/jtnueNTB8TZ4z/C7enFehba2B8YOWio5hnOYoACpw+6JhhOd/sbe71wBHLykmo88Y7DmAw8d605nNmc8KkhuZRlxLHxO/qvPJkIzq52NcqQzeFIpHXPo/p6OTQ9cqidPMA1pKpeAsghfeWun3fCYQ+VxtNlEZasuSub4ORH46ptCJqaK2Wy2clI3fgnOn9ipPnV3RnAbChhe5xdl45hxb3n9F7IHtMUN8KBKrVNfFKvNDp4XznVTgBm151t1rlTWr3r0xvExdkAPQPuh6zGrOFRmItW+wtg5xK9Bl2MKFp3N5FeZGyihLqX+ccotNeEVRjO5lszTB/8Lh1BXAA6m7VCcQpTFWTPdnV6vV3Q0XtaEmCAjnY452OXq/nzsuN6YXDvPr/XeWMEENtlYWJNiNLKm9nlAstLxohsoXbC/1j5DrTvsILw5T3cVgXbABf6z9W4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(39850400004)(376002)(346002)(396003)(478600001)(6666004)(966005)(8936002)(66946007)(956004)(8676002)(66556008)(66476007)(86362001)(4326008)(55016002)(1076003)(6916009)(55236004)(53546011)(186003)(316002)(16526019)(7696005)(52116002)(26005)(9686003)(7416002)(6506007)(54906003)(5660300002)(33656002)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: A1FEBWGqAdeNpgTL08Gf6CKRyJxVmF2wlXxrjFRQl9fNpb2aAxq8rFLCVDVob34RhmJiejAy80S62RTSdqqLkg9wvePv8JTX6VucCpwwWq+aEV65xQxcFFZOrWLskyNjh2BcuikTcM5/lY/dXOZS+cgirZyoDw/PnOWZ7AgJAls3Mg0lkZ8rrcQIdd3nbaJNoH9sDDAH9etEGhd8+LfJwuOd80jjW4H3OuAUGhjH1eyFz50ByOav/G6akFsKDDR8IEg8H/EulTZGhT8HZX2Q7g+oxL3nvcoasFjm2FnY6d8qwkyQRPUpA5U2ftfzr3nQa5CvHgc+gv3F4CIoVIXoJYOX2cpeMjtmc0HBlON2RODnbvnEvRpuu2rVGtITOZA1eFawOWlXUCNywb2Kr1GYlzHRXKj1lMxHeMwQ0w6tAroS9zghcvUwiLGT0Nu5VmR+vISDpD6Qrz+iPJRpaSIgJCQu9Wnic3AKBJ6VnvfPenbgOwxJA6MyXqBA/hE+9JXJbi9nVif7iTUbGjjrpUUHaaqGUEBPCNhIr5BbJp5/pxe+HofnrVHT1Z3e8x8Zpsspb0vlKPXlqfWgVV1bxC5vMa/jT5LojbjUBk+Wqur0x340mpixqeJLntPPuMHVgSgOCnagOeo9XlsfSXB5wMEHF84no+rD9oPa42AyNNiOBSNNTT2mVZUH2zeED2JyyE3sbJIhMZbymsm0qoNMXqHwQIzx7wtsoU+3X6JYkvb7OLz1Zie1YYDWc5mXTVNSgYAjJQUHxmAjMzanzKScsyZ+NEw+HDaJQh569ToSHNz0JNQ= X-MS-Exchange-CrossTenant-Network-Message-Id: 107be2ac-af22-4c0b-606c-08d7edd1febd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2020 13:17:27.6964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mG1B3pjSkx43tPQnrKwsAFdY1GXQM8bKohG+wObEvwST/Dbh9yTFPbPKZ67MHcAmXNVnnmHHC9SZGShY8jC4xA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2933 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-01_06:2020-04-30, 2020-05-01 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, May 01, 2020 at 11:27:02AM +0100, Ferruh Yigit wrote: > External Email > > ---------------------------------------------------------------------- > On 4/29/2020 10:03 AM, Bruce Richardson wrote: > > On Wed, Apr 29, 2020 at 09:45:44AM +0100, Dumitrescu, Cristian wrote: > >> > >> > >>> -----Original Message----- > >>> From: Thomas Monjalon <thomas@monjalon.net> > >>> Sent: Tuesday, April 28, 2020 4:54 PM > >>> To: Jerin Jacob <jerinjacobk@gmail.com>; Dumitrescu, Cristian > >>> <cristian.dumitrescu@intel.com> > >>> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh > >>> <ferruh.yigit@intel.com>; Luca Boccassi <bluca@debian.org>; Nithin > >>> Dabilpuram <nithind1988@gmail.com>; Singh, Jasvinder > >>> <jasvinder.singh@intel.com>; Andrew Rybchenko > >>> <arybchenko@solarflare.com>; dev@dpdk.org; jerinj@marvell.com; > >>> kkanas@marvell.com; Nithin Dabilpuram <ndabilpuram@marvell.com>; > >>> Kinsella, Ray <ray.kinsella@intel.com>; Neil Horman > >>> <nhorman@tuxdriver.com>; Kevin Traynor <ktraynor@redhat.com>; David > >>> Marchand <david.marchand@redhat.com> > >>> Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper > >>> config in pkt mode > >>> > >>> 28/04/2020 17:04, Luca Boccassi: > >>>> On Tue, 2020-04-28 at 15:45 +0100, Bruce Richardson wrote: > >>>>> On Tue, Apr 28, 2020 at 03:06:20PM +0100, Ferruh Yigit wrote: > >>>>>> On 4/27/2020 5:59 PM, Jerin Jacob wrote: > >>>>>>> On Mon, Apr 27, 2020 at 10:19 PM Ferruh Yigit > >>> <ferruh.yigit@intel.com> wrote: > >>>>>>>> On 4/27/2020 5:29 PM, Jerin Jacob wrote: > >>>>>>>>> On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit > >>> <ferruh.yigit@intel.com> wrote: > >>>>>>>>>> On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > >>>>>>>>>>> From: Yigit, Ferruh <ferruh.yigit@intel.com> > >>>>>>>>>>>> On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: > >>>>>>>>>>>>> From: Nithin Dabilpuram <nithind1988@gmail.com> > >>>>>>>>>>>>>> This patch also updates tm port/level/node capability > >>> structures with > >>>>>>>>>>>>>> exiting features of scheduler wfq packet mode, > >>> scheduler wfq byte mode > >>>>>>>>>>>>>> and private/shared shaper byte mode. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> SoftNIC PMD is also updated with new capabilities. > >>> [...] > >>>>>>>>>>>> Hi Nithin, > >>>>>>>>>>>> > >>>>>>>>>>>> It looks like patch is causing ABI break, I am getting following > >>> warning [1], > >>>>>>>>>>>> can you please check? > >>>>>>>>>>>> > >>>>>>>>>>>> [1] > >>>>>>>>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__pastebin.com_XYNFg14u&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=ej5sP3-cEhEoCTZOia-QivXqgljtzBcMLtZGs-5c-Uc&s=B8z_5mQ2xO3C1izjmRe2zBApMrCUcW6KcAN-adglhJQ&e= > >>>>>>>>>>> > >>>>>>>>>>> Hi Ferruh, > >>>>>>>>>>> > >>>>>>>>>>> The RTE_TM API is marked as experimental, > >>>>>>>>>>> but it looks that this was not correctly marked > >>>>>>>>>>> when __rte_experimental ABI checker was introduced. > >>>>>>>>>>> > >>>>>>>>>>> It is marked as experimental at the top of the rte_tm.h, > >>>>>>>>>>> similarly to other APIs introduced around same time, > >>>>>>>>>>> but it was not correctly picked up by the ABI check procedure > >>>>>>>>>>> when later introduced, so __rte_experimental was not added > >>> to every function. > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> :( > >>>>>>>>>> > >>>>>>>>>> Is it time to mature them? > >>>>>>>>>> > >>>>>>>>>> As you said they are not marked as experimental both in header > >>> file (function > >>>>>>>>>> declarations) and .map file. > >>>>>>>>>> > >>>>>>>>>> The problem is, they are not marked as experimental in > >>> DPDK_20.0 ABI (v19.11), > >>>>>>>>>> so marking them as experimental now will break the ABI. Not > >>> sure what to do, > >>>>>>>>>> cc'ed a few ABI related names for comment. > >>>>>>>>>> > >>>>>>>>>> For me, we need to proceed as the experimental tag removed > >>> and APIs become > >>>>>>>>>> mature starting from v19.11, since this is what happened in > >>> practice, and remove > >>>>>>>>>> a few existing being experimental references in the doxygen > >>> comments. > >>>>>>>>> > >>>>>>>>> I think, accidentally we can not make a library as NON- > >>> experimental. > >>>>>>>>> TM never went through experimental to mature transition(see git > >>> log > >>>>>>>>> lib/librte_ethdev/rte_tm.h) > >>>>>>>>> It was a bug to not mark as experimental in each function in the > >>> ABI process. > >>>>>>>>> Some of the features like packet marking are not even > >>> implemented by any HW. > >>>>>>>>> I think, we can make API stable only all the features are > >>> implemented > >>>>>>>>> by one or two HW. > >>> > >>> Yes this is what was decided one or two years ago I think. > >>> But rte_tm API was introduced 3 years ago and is implemented by 6 PMDs. > >>> > >>> > >>> > >>>>>>>> Fair enough, specially if the API is not ready yet. > >>>>>>>> > >>>>>>>> But they were part of stable ABI, and marking them as experimental > >>> now will > >>>>>>>> break the old applications using these APIs. > >>>>>>> > >>>>>>> it is still marked as EXPERIMENTAL everywhere and API is not ready > >>> yet. > >>> > >>> rte_tm is implemented in 6 PMDs. > >>> > >>> > >>>>>> Existing experimental marks are text only for human parsing. > >>>>>> > >>>>>> The compiler attribute and build time checks are missing, and the > >>> symbol in the > >>>>>> binary doesn't have experimental tag. Our scripts and automated > >>> checks won't > >>>>>> detect it as experimental. > >>>>>> > >>>>>> My point is just having experimental comment in header file is not > >>> enough to > >>>>>> qualify the APIs as experimental. > >>>>>> > >>>>>>> Anyway, we need to break the ABI to make it work on various HW. > >>> > >>> Yes this is why I was asking in 19.11 to check our API, > >>> in order to avoid such situation. > >>> > >>> > >>>>>>> I am not sure what to do? > >>> > >>> Either manage ABI versioning, or wait 20.11. > >>> > >>> > >>>>>>> IMO, We need to send a patch as Fixes: for the bug of not adding > >>>>>>> __rte_experimental in each function. > >>> > >>> No, this is wrong. > >>> > >> > >> Why exactly is this wrong? This is the gap that caused the current discussion, right? > >> > > It's wrong for this release, since we can't change things from stable back > > to experimental. Any such patch will have to wait for 20.11, as agreed in > > the discussion. > > > > Deferring the patchet for this release. > > Reminder that if the option "to mark rte_tm_* as experimental in v20.11" > selected, requires deprecation notice before v20.11. Thanks Ferruh for reminder. I'll send a deprecation notice patch for the same.