DPDK patches and discussions
 help / color / mirror / Atom feed
From: Renata Saiakhova <Renata.Saiakhova@ekinops.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 0/2] Memory corruption due to HW rings allocation
Date: Sun,  3 May 2020 18:26:34 +0200	[thread overview]
Message-ID: <20200503162636.5233-1-Renata.Saiakhova@ekinops.com> (raw)

igb and ixgbe drivers allocate HW rings using rte_eth_dma_zone_reserve(),
which checks first if the memzone exists for a given name, consisting of port
id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id.
If the memzone with a given name exists it is returned, otherwise it is
allocated.
Disconnecting dpdk port from one type of interface (igb) and connecting it
to another type of interface (ixgbe) for the same port id, potentially creates
memory overlap and corruption, because it may require memzone of bigger size.
That's what is happening from switching from igb to ixgbe having the same port
id.

Renata Saiakhova (2):
  librte_ethdev: Introduce a function to release HW rings
  drivers/net: Fix in e1000 and ixgbe HW rings memory overlap

 drivers/net/e1000/igb_rxtx.c             |  2 ++
 drivers/net/ixgbe/ixgbe_rxtx.c           |  2 ++
 lib/librte_ethdev/rte_ethdev.c           | 23 +++++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev_driver.h    | 14 ++++++++++++++
 lib/librte_ethdev/rte_ethdev_version.map |  1 +
 5 files changed, 42 insertions(+)

-- 
2.17.1


             reply	other threads:[~2020-05-04 17:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 16:26 Renata Saiakhova [this message]
2020-05-03 16:26 ` [dpdk-dev] [PATCH 1/2] librte_ethdev: Introduce a function to release HW rings Renata Saiakhova
2020-05-05 10:25   ` Burakov, Anatoly
2020-05-05 10:45     ` Burakov, Anatoly
2020-05-05 12:49       ` Renata Saiakhova
2020-05-05 13:36         ` Burakov, Anatoly
2020-05-05 15:47   ` Lukasz Wojciechowski
2020-05-05 17:25     ` Renata Saiakhova
2020-05-05 17:31       ` Lukasz Wojciechowski
2020-05-06 10:14       ` Burakov, Anatoly
2020-05-03 16:26 ` [dpdk-dev] [PATCH 2/2] drivers/net: Fix in e1000 and ixgbe HW rings memory overlap Renata Saiakhova
2020-05-05 10:28   ` Burakov, Anatoly
2020-05-05 10:59     ` Thomas Monjalon
2020-05-05 11:36       ` Burakov, Anatoly
2020-05-05 11:01 ` [dpdk-dev] [PATCH 0/2] Memory corruption due to HW rings allocation Thomas Monjalon
2020-05-05 11:19   ` Renata Saiakhova
2020-05-05 12:35     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200503162636.5233-1-Renata.Saiakhova@ekinops.com \
    --to=renata.saiakhova@ekinops.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).