From: <jerinj@marvell.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>,
<david.marchand@redhat.com>, "Jerin Jacob" <jerinj@marvell.com>
Subject: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum
Date: Mon, 4 May 2020 18:56:53 +0530 [thread overview]
Message-ID: <20200504132653.3668706-1-jerinj@marvell.com> (raw)
In-Reply-To: <20200121080021.2835490-1-jerinj@marvell.com>
From: Jerin Jacob <jerinj@marvell.com>
Some machines may have a lot of PCI devices and all of them are
not bound to DPDK. In such case the logs from EAL creates a lot of
clutter on boot-up, typically one needs to scroll the screen to
find other issues in boot-up.
This patch changes the following to reduce the clutter in
the default boot-up logs.
- Change the log-level of PCI probes to `debug`
- Introduce new driver probe as `info` log-level for the successful probe.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Introduce new driver probe as `info` log-level for the successful
probe(Thomas)
drivers/bus/pci/pci_common.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 3f5542076..6585a4b47 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -136,7 +136,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
/* Match of device and driver failed */
return 1;
- RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
+ RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
loc->domain, loc->bus, loc->devid, loc->function,
dev->device.numa_node);
@@ -161,7 +161,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
return -EEXIST;
}
- RTE_LOG(INFO, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
+ RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
dev->id.device_id, dr->driver.name);
/*
@@ -195,6 +195,10 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
}
}
+ RTE_LOG(INFO, EAL, "Probe PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n",
+ dr->driver.name, dev->id.vendor_id, dev->id.device_id,
+ loc->domain, loc->bus, loc->devid, loc->function,
+ dev->device.numa_node);
/* call the driver probe() function */
ret = dr->probe(dr, dev);
if (already_probed)
--
2.26.2
next prev parent reply other threads:[~2020-05-04 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:00 [dpdk-dev] [PATCH] " jerinj
2020-02-06 14:14 ` Thomas Monjalon
2020-02-06 14:36 ` Jerin Jacob
2020-04-25 20:12 ` Thomas Monjalon
2020-04-26 17:42 ` Jerin Jacob
2020-04-26 18:06 ` Thomas Monjalon
2020-04-26 18:48 ` Jerin Jacob
2020-04-26 19:56 ` Thomas Monjalon
2020-04-27 18:02 ` Jerin Jacob
2020-05-04 13:26 ` jerinj [this message]
2020-05-07 13:54 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2020-05-07 15:36 ` Thomas Monjalon
2020-05-11 14:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504132653.3668706-1-jerinj@marvell.com \
--to=jerinj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).