From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44633A034F; Wed, 6 May 2020 11:05:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D84641D6B4; Wed, 6 May 2020 11:05:18 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D20CF1D675; Wed, 6 May 2020 11:05:17 +0200 (CEST) IronPort-SDR: EiqZVT075P98YubQyNLcAL4OfOyXxG4YUpQdIf5eQ4dBVBLIU0cb5HCmD9Td4aMD0YLevxwFPD +wJ2Q5Uvgj6Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 02:05:16 -0700 IronPort-SDR: VkmfgRbd4RfMX0anDIzsuzSov+slKBXKTLq1pWzbr+AQmYMkF/61ZSy6GvYYnBkbx/Pacdb/Hn B8FboZV5V2pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,358,1583222400"; d="scan'208";a="251143630" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 06 May 2020 02:05:15 -0700 Date: Wed, 6 May 2020 16:57:32 +0800 From: Ye Xiaolong To: Junyu Jiang Cc: dev@dpdk.org, Qiming Yang , stable@dpdk.org Message-ID: <20200506085732.GA49901@intel.com> References: <20200429072516.65403-1-junyux.jiang@intel.com> <20200506030525.3907-1-junyux.jiang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506030525.3907-1-junyux.jiang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ice: fix core dumped issue in switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/06, Junyu Jiang wrote: >The number of queues in queue group should be checked before >using it. This patch fixed the issue. > >Fixes: 47d460d63233 ("net/ice: rework switch filter") >Cc: stable@dpdk.org > >Signed-off-by: Junyu Jiang >Tested-by: Qimai Xiao >--- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c >index 179430136..c2762e331 100644 >--- a/drivers/net/ice/ice_switch_filter.c >+++ b/drivers/net/ice/ice_switch_filter.c >@@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > switch (action_type) { > case RTE_FLOW_ACTION_TYPE_RSS: > act_qgrop = action->conf; >+ if (act_qgrop->queue_num <= 1) >+ goto error; > rule_info->sw_act.fltr_act = > ICE_FWD_TO_QGRP; > rule_info->sw_act.fwd_id.q_id = >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.