From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9624A034F; Wed, 6 May 2020 14:37:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC1991D9AF; Wed, 6 May 2020 14:36:52 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by dpdk.org (Postfix) with ESMTP id 1346F1D976 for ; Wed, 6 May 2020 14:36:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QsOuFaURYK/JWfbMRGAzQ9LO5ZSJPhcYwzrbv4cGDC9qjGhKkiA++oD19hEFfh9w2nIxdABRF9zpugWO+ngnoo4wxzUXj39RSxRto0JzGMkPkngjAYd/v1aPNhI0KJZAe1wbLwbfbt0R96v2l92KRrrpRGSgsEFAukC2dq56vMdxTBxaMURWguUmLzAmoT3ym14CNE6+613XRWxfUFVPJoT3APf41I4ZMCybb4wK11/BGB2xC8+mKvUL0BIsrFAVya4PaLKN8qtGHhcZMRaHvnqbO7k32d3nH2rpTFFIOOaZfG/mYiFidD5+YcK4Y5UQsUvdLE3Qv4J6D87fjjqIag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aPy+ygDMoh3chTYIOwN+kIE43ZLcen3Z1B1OseRUoL8=; b=k8cwSSnT5KLHLI2om+bPzH3pxjENXYAQSCpxCVrkMCXd87e6NG10Lg+x05I4QmLKGEb8Gc7wUtIQPyTZjKQ5NgTjqu5+1nXvp39biUPv69f+NbWLuDGT8ZeES7OeL1YFjhjTQ1goFv/seHc788WIQkFjw2u7lO2SUX/MGxfxlB2GD8KBi8uVshr+pbsG/A3txBtspjdWRFDRlK6cfrn/zbK7yDYebawf3lfMX9asVWHeifY+PpRigoN3dfoLFXkwy+eICtWQIDWuP9EhWniVJxhzdRc7bBojCie84QPXSSqbBSxsHGAurDH7bhbPFGOD3PruZ7M8tkuPkE0aaBP53A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aPy+ygDMoh3chTYIOwN+kIE43ZLcen3Z1B1OseRUoL8=; b=WkBy72VHwNgJvq626o3ICRdFory2nMR96nbKQPrgSxLm+bVc2srUjrs+0nFHcD2tbtekQ1oNVwxSNa580Lr9jYVcT+bDEehSRwPKdtFuErsVdCnvUtQzvCZs6WYIVdgJU+HVbPeuMyKgR8a3Y/VGeAuWntwBgWVdcaIwrlKaR3M= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) by AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Wed, 6 May 2020 12:36:47 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::900:c0ac:78bd:18fc]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::900:c0ac:78bd:18fc%6]) with mapi id 15.20.2958.030; Wed, 6 May 2020 12:36:47 +0000 From: Wisam Jaddo To: dev@dpdk.org, jackmin@mellanox.com, thomas@monjalon.net, jerinjacobk@gmail.com, gerlitz.or@gmail.com, l.yan@epfl.ch, ajit.khaparde@broadcom.com Date: Wed, 6 May 2020 12:36:25 +0000 Message-Id: <20200506123627.22340-4-wisamm@mellanox.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200506123627.22340-1-wisamm@mellanox.com> References: <20200430103341.1845-2-wisamm@mellanox.com> <20200506123627.22340-1-wisamm@mellanox.com> Content-Type: text/plain X-ClientProxiedBy: PR0P264CA0164.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::32) To AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (37.142.13.130) by PR0P264CA0164.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Wed, 6 May 2020 12:36:46 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [37.142.13.130] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7bc694f5-2e73-4179-9638-08d7f1ba2431 X-MS-TrafficTypeDiagnostic: AM0PR05MB4209:|AM0PR05MB4209: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-Forefront-PRVS: 03950F25EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9BuAeRQS8KdnfRxFJXSC7vL6Rb9X13SjHRRlCq1anWFPSWoVuf9p6MkKevx/Ld8vD/Ee8sHRBJVN3tRMpxZ4eH3p4idVHPAAfc87daAiiH5GWWrOqzimrEdlTe/uO3l8kGLy+o1KcqPoH2HqBkNsYohGIoqE6TWG7pNesZFIZ59KTQQcGgGNJR2kSHxpEDHHC7aaoDCGjyT/a0SSuyN9DeGXQ7ayDsFSQh7VcP3qylqxfY0rmtQzOYKn7TTfG9bz7SQIj4vkIBVi4ybn+kb9Q8Di+8b4052quckE1eNyDkXKgP6wD0ERH2T3mzp99Nd2pYyTii8G1lyDl9qe3ePXQ8QBFj54SLABTnSZP3kl7tJYGgGeFRVMy7pKsWK4dcUmaqxojnBkLc3xxaxXUJ3S8s4yNC+Kd0eLNhLHeey9hXaIKeHZp9DGtNgEu+6RpP4i1NDPvaa0TSnrD/6gyfpRTR/9DvT7qrc0+LPeXrrPuYYqLYCOiiLCiVADbH5xL32sRyVXC3+AQl0jjgzoujGtLg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(33430700001)(316002)(86362001)(1076003)(26005)(8676002)(55016002)(36756003)(33440700001)(52116002)(66946007)(186003)(7696005)(66556008)(66476007)(16526019)(478600001)(956004)(2906002)(8936002)(8886007)(5660300002)(6666004)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: DhgVxkGfdtASGARU44SP9JA11ZQqaTR6yN373Ak8T0xW0C7dzjCxAcA7Aa2sb5u6g4HyeD6/Gx1vda17gDIPwcognE+Iclugw7f/IoATASAquDZKPdKDUGlrIU3H6dFn7WgUicRff6uOnCRtk806b6HfzdIMVXlFemyoSLJYiFkuPJNMfPODT5DCaKO3lSGrroCSQFDbSQhsA1mJ+UXSKx5eDUYjwV7wMFOCGg91I+fMBIM14/L65nRP1oZEsLueYlufXPU4rQD9KVmtBVd+CUoy4DhcvZLn2lGUEVGs3npYzIxfoWLnmyjXk+J+ezV+uN0J3l+Wgy/35CecBn5tyLNWXyRt8gKlUFqgWGs4WarOZuVOk7RiLTC7S6h1coMdT/Dfz/xuRAn364S2s3HZ01vy+n+huzEb9rwhGhdRV083iNIUoi4SPFiI+hzJ5C12qHj5Euh22mT8e8itOO+ufh1R22+NI39UTF/Do9LXg6qGqw2HLlJ0qR/Z/6bCHhtiPUqwboRpOG6RFlI4bcCt8nh51n2d54m8i2qz+aapPm+afkPF9yjMSisUNZeMGbd6X3r2xWw1000ks+BvHZ4bAtUDdf9cDE3uExRHfBBd82UZJU8+ljRxw/HVrqjIuHAiZdsC+wX4LH7j+apxXS+NBIPWAqD6NJtvnepmNi7accLsnnCIL9ZaGfSRe5PH2afbIWHk+SltaFb0o+YzfjVrtAywlHoKMaE/vnYLdEwyGFXh/qz0Peods8OAc7d1yBswe8lvf8dEUQF2M0Gw1bcRtIiywXEsS04AH4a+kyLBMgU= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc694f5-2e73-4179-9638-08d7f1ba2431 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2020 12:36:47.1733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: shnDgzDFY9gMaawNj4VHqW//oqEpv2LysR1rRj1m0i1MiPbyLw+rZ/aRSn0tkU7Q0ePAiy56rAIdttDyf+OmwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4209 Subject: [dpdk-dev] [PATCH v5 3/5] app/flow-perf: add deletion rate calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add the ability to test deletion rate for flow performance application. This feature is disabled by default, and can be enabled by add "--deletion-rate" in the application command line options. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 86 ++++++++++++++++++++++++++++++++++ doc/guides/tools/flow-perf.rst | 4 ++ 2 files changed, 90 insertions(+) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 463e4a782..1b42cffda 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -49,6 +49,7 @@ static uint16_t flow_actions; static uint8_t flow_attrs; static volatile bool force_quit; static bool dump_iterations; +static bool delete_flag; static struct rte_mempool *mbuf_mp; static uint32_t nb_lcores; static uint32_t flows_count; @@ -64,6 +65,8 @@ usage(char *progname) " flows to insert, default is 4,000,000\n"); printf(" --dump-iterations: To print rates for each" " iteration\n"); + printf(" --deletion-rate: Enable deletion rate" + " calculations\n"); printf("To set flow attributes:\n"); printf(" --ingress: set ingress attribute in flows\n"); @@ -145,6 +148,7 @@ args_parse(int argc, char **argv) { "help", 0, 0, 0 }, { "flows-count", 1, 0, 0 }, { "dump-iterations", 0, 0, 0 }, + { "deletion-rate", 0, 0, 0 }, /* Attributes */ { "ingress", 0, 0, 0 }, { "egress", 0, 0, 0 }, @@ -260,6 +264,8 @@ args_parse(int argc, char **argv) } if (!strcmp(lgopts[opt_idx].name, "dump-iterations")) dump_iterations = true; + if (!strcmp(lgopts[opt_idx].name, "deletion-rate")) + delete_flag = true; break; default: printf("Invalid option: %s\n", argv[optind]); @@ -279,9 +285,75 @@ print_flow_error(struct rte_flow_error error) error.message ? error.message : "(no stated reason)"); } +static inline void +destroy_flows(int port_id, struct rte_flow **flow_list) +{ + struct rte_flow_error error; + clock_t start_iter, end_iter; + double cpu_time_used = 0; + double flows_rate; + double cpu_time_per_iter[MAX_ITERATIONS]; + double delta; + uint32_t i; + int iter_id; + + for (i = 0; i < MAX_ITERATIONS; i++) + cpu_time_per_iter[i] = -1; + + if (iterations_number > flows_count) + iterations_number = flows_count; + + /* Deletion Rate */ + printf("Flows Deletion on port = %d\n", port_id); + start_iter = clock(); + for (i = 0; i < flows_count; i++) { + if (!flow_list[i]) + break; + + memset(&error, 0x33, sizeof(error)); + if (rte_flow_destroy(port_id, flow_list[i], &error)) { + print_flow_error(error); + rte_exit(EXIT_FAILURE, "Error in deleting flow"); + } + + if (i && !((i + 1) % iterations_number)) { + /* Save the deletion rate of each iter */ + end_iter = clock(); + delta = (double) (end_iter - start_iter); + iter_id = ((i + 1) / iterations_number) - 1; + cpu_time_per_iter[iter_id] = + delta / CLOCKS_PER_SEC; + cpu_time_used += cpu_time_per_iter[iter_id]; + start_iter = clock(); + } + } + + /* Deletion rate per iteration */ + if (dump_iterations) + for (i = 0; i < MAX_ITERATIONS; i++) { + if (cpu_time_per_iter[i] == -1) + continue; + delta = (double)(iterations_number / + cpu_time_per_iter[i]); + flows_rate = delta / 1000; + printf(":: Iteration #%d: %d flows " + "in %f sec[ Rate = %f K/Sec ]\n", + i, iterations_number, + cpu_time_per_iter[i], flows_rate); + } + + /* Deletion rate for all flows */ + flows_rate = ((double) (flows_count / cpu_time_used) / 1000); + printf("\n:: Total flow deletion rate -> %f K/Sec\n", + flows_rate); + printf(":: The time for deleting %d in flows %f seconds\n", + flows_count, cpu_time_used); +} + static inline void flows_handler(void) { + struct rte_flow **flow_list; struct rte_flow_error error; clock_t start_iter, end_iter; double cpu_time_used; @@ -293,6 +365,7 @@ flows_handler(void) int port_id; int iter_id; uint32_t eagain_counter = 0; + uint32_t flow_index; nr_ports = rte_eth_dev_count_avail(); @@ -304,8 +377,14 @@ flows_handler(void) printf(":: Flows Count per port: %d\n", flows_count); + flow_list = rte_zmalloc("flow_list", + (sizeof(struct rte_flow *) * flows_count) + 1, 0); + if (flow_list == NULL) + rte_exit(EXIT_FAILURE, "No Memory available!"); + for (port_id = 0; port_id < nr_ports; port_id++) { cpu_time_used = 0; + flow_index = 0; if (flow_group > 0) { /* * Create global rule to jump into flow_group, @@ -322,6 +401,7 @@ flows_handler(void) print_flow_error(error); rte_exit(EXIT_FAILURE, "error in creating flow"); } + flow_list[flow_index++] = flow; } /* Insertion Rate */ @@ -345,6 +425,8 @@ flows_handler(void) rte_exit(EXIT_FAILURE, "error in creating flow"); } + flow_list[flow_index++] = flow; + if (i && !((i + 1) % iterations_number)) { /* Save the insertion rate of each iter */ end_iter = clock(); @@ -378,6 +460,9 @@ flows_handler(void) printf(":: The time for creating %d in flows %f seconds\n", flows_count, cpu_time_used); printf(":: EAGAIN counter = %d\n", eagain_counter); + + if (delete_flag) + destroy_flows(port_id, flow_list); } } @@ -532,6 +617,7 @@ main(int argc, char **argv) dump_iterations = false; flows_count = DEFAULT_RULES_COUNT; iterations_number = DEFAULT_ITERATION; + delete_flag = false; flow_group = 0; signal(SIGINT, signal_handler); diff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst index b45fccd69..b64c23875 100644 --- a/doc/guides/tools/flow-perf.rst +++ b/doc/guides/tools/flow-perf.rst @@ -17,6 +17,8 @@ give different flow each time, and all other items will have open masks. The current design have single core insertion rate. +The application also provide the ability to measure rte flow deletion rate. + Compiling the Application ========================= @@ -63,6 +65,8 @@ The command line options are: Print rates for each iteration of flows. Default iteration is 1,00,000. +* ``--deletion-rate`` + Enable deletion rate calculations. Attributes: -- 2.17.1