From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Andrzej Ostruszka [C]" <aostruszka@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support
Date: Wed, 6 May 2020 13:19:34 -0700 [thread overview]
Message-ID: <20200506131934.383f73fa@hermes.lan> (raw)
In-Reply-To: <da93696f-99c4-a131-9a73-7d5a9025c7ec@intel.com>
On Wed, 6 May 2020 19:41:28 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 4/27/2020 12:32 PM, Andrzej Ostruszka [C] wrote:
> > On 25/04/2020 01:36, Stephen Hemminger wrote:
> >> In recent Linux kernels, there is support for extended acknowledgement
> >> to netlink messages. This is quite useful for diagnosing errors
> >> in configuration in the kernel with TAP.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >> ---
> > [...]
> >> +#else
> >> +/*
> >> + * External ACK support was added in Linux kernel 4.17
> >> + * on older kernels, just ignore that part of message
> >> + */
> >> +#define tap_nl_dump_ext_ack(nh, err) do { } while();
> >
> > Maybe "while(0)" here?
> >
>
> +1, will fix while merging.
>
> I assume since it is in #else leg it has not been tested but #if leg tested well.
Yes, haven't built on distros that are old enough to hit the #else :-(
next prev parent reply other threads:[~2020-05-06 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 23:36 [dpdk-dev] [PATCH 0/2] net/tap: simplfication and servicabilty improvements Stephen Hemminger
2020-04-24 23:36 ` [dpdk-dev] [PATCH 1/2] net/tap: simplify netlink send/receive functions Stephen Hemminger
2020-04-24 23:36 ` [dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support Stephen Hemminger
2020-04-27 11:32 ` Andrzej Ostruszka [C]
2020-05-06 18:41 ` Ferruh Yigit
2020-05-06 20:19 ` Stephen Hemminger [this message]
2020-04-25 13:14 ` [dpdk-dev] [PATCH 0/2] net/tap: simplfication and servicabilty improvements Wiles, Keith
2020-05-06 18:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506131934.383f73fa@hermes.lan \
--to=stephen@networkplumber.org \
--cc=aostruszka@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).