From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3090FA034E; Wed, 6 May 2020 22:19:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1103A1D9EB; Wed, 6 May 2020 22:19:45 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3ABB41D969 for ; Wed, 6 May 2020 22:19:44 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id x77so1665681pfc.0 for ; Wed, 06 May 2020 13:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kvIb7aHQQguBDpqlUt8PxdsR00jv6FcnUjm+2RnU2Rg=; b=f92YrW+La/Oiy6/qda6tYCBw3Ab+3Ba95BOFyrReG+roiaIpDyJAT0RB0MMB3wXyG+ 8MbVzqnezQyQGVhA3NI9vOE3dvqIbTt25+HrWe8jpvkHz2govuRdcB6U8n2/QhQFMqOi fJLQwnoKL34WpBum+IbB3zlc3I0K+NbePYWt9T/ALVvCWLlFFhwBN/2nW53mS9kwm1n2 hLB5CIuYxU5PIaylGqauzRp6/+3y9vHEl23JYBRzEgSYRJieLKtGnZVFy/o0N0sAUcKz +QcY8Wt8OG6KTZxLsf/soOlCED2mCvL57CCYYpGGyZBToTTCMNqGG22sranJ0JRotEuD JBtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kvIb7aHQQguBDpqlUt8PxdsR00jv6FcnUjm+2RnU2Rg=; b=LXwFVJiCcYxkY7YRJ41jSOF+nDfJXwsJNScPervyvdlnQomuhyk+LBWNvDyh12A4hD 0dUhyVwACMQHSBGDX2i+JQVvyitB1HJOCSm2lsM7soa2ALSgoIEhoch5v6dNhoyhRVcb M5J6j3ZFj0fHpmU2yTcblXrcf/lM/3qQf3v2z5gz1Wmu5OA9Y0M5qUfGPdTV5QNGhL70 qoVl9ioVRl6fjIZZO7g7i67vRBf8J+t0oGaFgvqluseGtQHSU+NfZlJA/AF0MFvS1A1K oA4lDCEwOlhzGKXSSQMiCVgylDFbOsH7cT0s8U9VRzd4bcAmpIIhuWqLk+FTuKfA6+Ip LSng== X-Gm-Message-State: AGi0PuYN70ZYEyFeV8gTXgWj4gSofwfIC1YWYNeIEXYZFsCoDNWZOCVu dfCekZ3cHaoobxH81qBRr617Ng== X-Google-Smtp-Source: APiQypIEF4mplUWNEc/tqmamDihqyjnvQCLqmyiVPiuFhGGep8u5Wk47w+kElvrFDC1k50NZTRVcoA== X-Received: by 2002:aa7:982b:: with SMTP id q11mr9803806pfl.260.1588796383319; Wed, 06 May 2020 13:19:43 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 127sm2704511pfw.72.2020.05.06.13.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 13:19:43 -0700 (PDT) Date: Wed, 6 May 2020 13:19:34 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: "Andrzej Ostruszka [C]" , "dev@dpdk.org" Message-ID: <20200506131934.383f73fa@hermes.lan> In-Reply-To: References: <20200424233657.12267-1-stephen@networkplumber.org> <20200424233657.12267-3-stephen@networkplumber.org> <2d66766b-033f-ef05-66ac-97dc4d916c24@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: use netlink extended ack support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 6 May 2020 19:41:28 +0100 Ferruh Yigit wrote: > On 4/27/2020 12:32 PM, Andrzej Ostruszka [C] wrote: > > On 25/04/2020 01:36, Stephen Hemminger wrote: > >> In recent Linux kernels, there is support for extended acknowledgement > >> to netlink messages. This is quite useful for diagnosing errors > >> in configuration in the kernel with TAP. > >> > >> Signed-off-by: Stephen Hemminger > >> --- > > [...] > >> +#else > >> +/* > >> + * External ACK support was added in Linux kernel 4.17 > >> + * on older kernels, just ignore that part of message > >> + */ > >> +#define tap_nl_dump_ext_ack(nh, err) do { } while(); > > > > Maybe "while(0)" here? > > > > +1, will fix while merging. > > I assume since it is in #else leg it has not been tested but #if leg tested well. Yes, haven't built on distros that are old enough to hit the #else :-(