From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C7DCA034E; Wed, 6 May 2020 22:25:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BE6B1DA7B; Wed, 6 May 2020 22:25:43 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 7443A1DA60 for ; Wed, 6 May 2020 22:25:41 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id 7so2878110pjo.0 for ; Wed, 06 May 2020 13:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pzIDPBCX5ZDqsosWa7ypkxVhu/jpueuCDcsiL2mBgno=; b=ToHOkxCtjrCB/LTqFk9JBwOnJUbuaClPf1IrG58wMD+tj+MyZr0qCcfU38VNP2imoO sEHTWHrcE0MLz2XB30m67EhhWiuhtmQ1HGZatwHOiGosCR/SCNYID+iqBBp+GMKMqZQ3 X4CP7n2I8ZqbXa3lmAlZiZsBvFSocJWw3eXixwyEaNdy6EB0X3VoRfgW9AMlGimnv4vA dPgcp8wYrwh8gqSmAbQkLlMR4K5fMGV7J9S2H6n3jeLPf8nmkTNgo42A1WXVrg1Krk6e 4StsCx/KkGYaPwLGj6tJmsswkUYIK1egTlhWDNXb4UUGh9TSj5SVTlNr4b+UgIxz2SJ9 E7dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pzIDPBCX5ZDqsosWa7ypkxVhu/jpueuCDcsiL2mBgno=; b=d+xgXpRs9vHKQ8Dfvf4AKkpKCIlPDIzS+wN/kYb+2gxmBh3sbAlSEPhbBoKntvcmxU uCgNHdPiQ7Wx5hJI8m3C5Ocajw7RBcyNULMsGTN8aiy4YSrdn9Ogjm4UQcTraDRfhPDd VRfRmkSlJx8YC57fjhTaR5x6fZIECaZrgt8WErg6ewsVzUQGlN8HtdMOUvW68TtIepuP pr6pP5x7z2fuCSufHLAq/BSIZO8kmiiHh09DPNBFZ8CHw9r7h/rtBgWkslMXjo9qKHdQ qhnj3Kds6TliyCXYualz74I/UKD0C2kXOPwJGgAJgWJLvOZ/t5gy/Xpefg1Hd/oazokO YKuw== X-Gm-Message-State: AGi0PuZgYVYNjMZBbeGHdt5UITH0nsOTB85ubEjJqhKOTb3H0yeTN5FZ kcaN7KtogpCXwTLAZtOUUfu5n0h4BV6kOw== X-Google-Smtp-Source: APiQypL1HO/gCei6K39b5TrSGyA1WqDPxCjOqXkrc4AyqaZLAvekF9FeCIumDEER8miPVeYkpMVsnQ== X-Received: by 2002:a17:90a:ee84:: with SMTP id i4mr11824886pjz.71.1588796740548; Wed, 06 May 2020 13:25:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h13sm2125343pgm.69.2020.05.06.13.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 13:25:40 -0700 (PDT) Date: Wed, 6 May 2020 13:25:37 -0700 From: Stephen Hemminger To: =?UTF-8?B?R2HDq3Rhbg==?= Rivet Cc: David Marchand , dev@dpdk.org Message-ID: <20200506132537.608e73d3@hermes.lan> In-Reply-To: <20200506172123.w37j737azn7ijdxa@u256.net> References: <20200506124314.14009-1-david.marchand@redhat.com> <20200506124314.14009-2-david.marchand@redhat.com> <20200506172123.w37j737azn7ijdxa@u256.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 6 May 2020 19:21:23 +0200 Ga=C3=ABtan Rivet wrote: > On 06/05/20 14:43 +0200, David Marchand wrote: > > Internal symbols do not need the rte_ prefix. > > Some symbols do not need to be exposed in the private header and have > > been made static. > >=20 > > Fixes: c752998b5e2e ("pci: introduce library and driver") > >=20 > > Signed-off-by: David Marchand =20 >=20 > For this patch, I would like to understand why we are having this > policy. Symbols that are emitted for later linking will be present in > archives generated by the framework. Am I wrong to think they can > conflict with user app symbols? >=20 > If that is correct, we should use pci_* prefix for static symbols, > rte_* for everything else, even "internal" symbols -- in the sense > that they are meant to be opaque to the user, but will still be linked > in static build. >=20 > If I'm wrong in thinking this, then ok with this policy and let's go > forward to align naming in PCI bus. >=20 Agree that all symbols need a prefix. Any symbol that is not static is visible to the application if static linki= ng. There is some pre-linking magic can be done but DPDK isn't doing it.