From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85B29A034F; Wed, 6 May 2020 16:07:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BFE8C1D94F; Wed, 6 May 2020 16:07:32 +0200 (CEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by dpdk.org (Postfix) with ESMTP id BCF0C1D92F; Wed, 6 May 2020 16:07:31 +0200 (CEST) X-Originating-IP: 86.246.31.132 Received: from u256.net (lfbn-idf2-1-566-132.w86-246.abo.wanadoo.fr [86.246.31.132]) (Authenticated sender: grive@u256.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 4CFA81C0014; Wed, 6 May 2020 14:06:02 +0000 (UTC) Date: Wed, 6 May 2020 16:05:57 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , John McNamara , Anatoly Burakov , Maxime Coquelin , Zhihong Wang , Xiaolong Ye , Gaetan Rivet Message-ID: <20200506140557.sm4hsakfe3cam22m@u256.net> References: <20200506124314.14009-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200506124314.14009-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH 1/2] remove references to private PCI probe function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello David, On 06/05/20 14:43 +0200, David Marchand wrote: > rte_pci_probe() is private to the PCI bus. > Clean the remaining references in the documentation and comments. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > doc/guides/sample_app_ug/l2_forward_event.rst | 8 -------- > doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 9 --------- > doc/guides/sample_app_ug/link_status_intr.rst | 7 ------- > doc/guides/sample_app_ug/multi_process.rst | 2 +- > drivers/bus/pci/pci_common.c | 6 +++--- > drivers/bus/pci/private.h | 10 ---------- > drivers/net/virtio/virtio_user_ethdev.c | 2 +- > 7 files changed, 5 insertions(+), 39 deletions(-) > > diff --git a/doc/guides/sample_app_ug/l2_forward_event.rst b/doc/guides/sample_app_ug/l2_forward_event.rst > index 8bdf352c4e..d536eee819 100644 > --- a/doc/guides/sample_app_ug/l2_forward_event.rst > +++ b/doc/guides/sample_app_ug/l2_forward_event.rst > @@ -204,9 +204,6 @@ chapters that related to the Poll Mode and Event mode Driver in the > > .. code-block:: c > > - if (rte_pci_probe() < 0) > - rte_panic("Cannot probe PCI\n"); > - > /* reset l2fwd_dst_ports */ > > for (portid = 0; portid < RTE_MAX_ETHPORTS; portid++) > @@ -236,11 +233,6 @@ chapters that related to the Poll Mode and Event mode Driver in the > rte_eth_dev_info_get((uint8_t) portid, &dev_info); > } > > -Observe that: > - > -* rte_pci_probe() parses the devices on the PCI bus and initializes recognized > - devices. > - Reading the docs overall, what needed to be covered by referencing rte_pci_probe() here should be covered by the reference to rte_eal_init() earlier. So simply removing rte_pci_probe() line in these docs seems ok. LGTM, Reviewed-by: Gaetan Rivet -- Gaëtan