From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5FF0A034E; Wed, 6 May 2020 19:21:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 405791DA62; Wed, 6 May 2020 19:21:45 +0200 (CEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by dpdk.org (Postfix) with ESMTP id EE1D21DA61 for ; Wed, 6 May 2020 19:21:43 +0200 (CEST) X-Originating-IP: 86.246.31.132 Received: from u256.net (lfbn-idf2-1-566-132.w86-246.abo.wanadoo.fr [86.246.31.132]) (Authenticated sender: grive@u256.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 00A271BF206; Wed, 6 May 2020 17:21:30 +0000 (UTC) Date: Wed, 6 May 2020 19:21:23 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: David Marchand Cc: dev@dpdk.org Message-ID: <20200506172123.w37j737azn7ijdxa@u256.net> References: <20200506124314.14009-1-david.marchand@redhat.com> <20200506124314.14009-2-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200506124314.14009-2-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/05/20 14:43 +0200, David Marchand wrote: > Internal symbols do not need the rte_ prefix. > Some symbols do not need to be exposed in the private header and have > been made static. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > > Signed-off-by: David Marchand For this patch, I would like to understand why we are having this policy. Symbols that are emitted for later linking will be present in archives generated by the framework. Am I wrong to think they can conflict with user app symbols? If that is correct, we should use pci_* prefix for static symbols, rte_* for everything else, even "internal" symbols -- in the sense that they are meant to be opaque to the user, but will still be linked in static build. If I'm wrong in thinking this, then ok with this policy and let's go forward to align naming in PCI bus. -- Gaëtan