From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, thomas@monjalon.net, talshn@mellanox.com,
dmitry.koziuk@gmail.com, harini.ramakrishnan@microsoft.com,
ocardona@microsoft.com, anand.rawat@intel.com,
ranjit.menon@intel.com, yohadt@mellanox.com
Subject: Re: [dpdk-dev] [PATCH v4 1/2] timer: move from common to Unix directory
Date: Wed, 6 May 2020 22:49:05 +0300 [thread overview]
Message-ID: <20200506224905.2d214d30@Sovereign> (raw)
In-Reply-To: <20200506120109.9856-2-fady@mellanox.com>
On 2020-05-06 15:01 GMT+0300 Fady Bader wrote:
[snip]
> diff --git a/lib/librte_eal/unix/meson.build b/lib/librte_eal/unix/meson.build
> index 5734f26ad..d13e66663 100644
> --- a/lib/librte_eal/unix/meson.build
> +++ b/lib/librte_eal/unix/meson.build
> @@ -4,4 +4,5 @@
> sources += files(
> 'eal_unix.c',
> 'eal_unix_memory.c',
> + 'eal_timer.c',
> )
> --
> 2.16.1.windows.4
>
I suggest creating unix/ directory by this patch to break dependency on
memory management series, because its review will clearly take longer. I'd
better rebase MM series after this one will get merged.
--
Dmitry Kozlyuk
next prev parent reply other threads:[~2020-05-06 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 12:01 [dpdk-dev] [PATCH v4 0/2] eal timer split and implementation for Windows Fady Bader
2020-05-06 12:01 ` [dpdk-dev] [PATCH v4 1/2] timer: move from common to Unix directory Fady Bader
2020-05-06 19:49 ` Dmitry Kozlyuk [this message]
2020-05-06 12:01 ` [dpdk-dev] [PATCH v4 2/2] timer: support EAL functions on Windows Fady Bader
2020-05-06 19:43 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506224905.2d214d30@Sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=anand.rawat@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.koziuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).