From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D46CA00C5; Thu, 7 May 2020 11:46:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B18D1DB3E; Thu, 7 May 2020 11:46:09 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80072.outbound.protection.outlook.com [40.107.8.72]) by dpdk.org (Postfix) with ESMTP id 13E4F1DA0B for ; Thu, 7 May 2020 11:46:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhOThNb40lQlgQESbLi3hKkMYhQDYlgmoGEspNUxuOoW3eSQ4ePKWoGxdMGRMG6bqFJrni0oBNvOIet0VShy1x0h9ElQIl8Rz6SZGP/BE9sdi6kAwn/CKzGW3xOuqZv5acoO3WaRot2YNChdeqbs7PtmxuOXeEUKkXEaZWWNvmm4GQ3YxnJ08AagkzIyWAyCIIGiTvXAwFGolujUBYyKYvbI8Rhu5k2402pTHP3/ocZ2USCSlgsxCuQV/fGyhiAOQcdanctXQxPGWtgbrndHVKEBKxSrNBjLgRtE0Vs9qdu7S6agF3Ym7YVO06jPRSdcnpCyE1WwpHUzO7yIBnuY0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/VA7VXa4zdZVKclogbM3qo8XwObllPwD6J6IGEupG8=; b=KF7yX7OtVHsI+2ARL3ebL1dRf6HSfiTGttzrt8ryg8+keyamJL7sZguqUHjSrxLQ7wVNgleVNiFDbv6dyOZLy4VpXg0kFAbEW1rFpQ32Ot1swvTB9bPFvKW2aC3iVCDIYj2d0WP84HilJdsn3yUouAcIyXSoIBi9ugbzO0NFoFOLRdjyGlKYNaPKIQitpk9beYoAJyAN93SeEB8gCJrUZBEbydpgY2nNygbQsLZLYlB4fAmtGSY3jsCS5pb6f9W3ap5rkuPOHLO7aX40gdFzemXclkU11L9z7W6AXGTeZmFF5f0FkZxknGBD6wbyTfBFlqVEFeajYvieevvlGe/eog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/VA7VXa4zdZVKclogbM3qo8XwObllPwD6J6IGEupG8=; b=hBpD5cZ8MS6Ep1MFrf1IpVlBGlP+SPP/6aZczT3S3ov3dhSo0RWM/e1LdBoIx2TOLMdUT1OhS+Mea2U+5y++D3QdhAHAwJcFKRNHRT657DgwZK9yIGsXucSpiwYNLJHxjZYwwPBlODoY8tmvbl6FG5B2O9mkW/8M96uKQjvk9Q8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6115.eurprd05.prod.outlook.com (2603:10a6:208:131::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.21; Thu, 7 May 2020 09:46:07 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2958.034; Thu, 7 May 2020 09:46:07 +0000 From: Raslan Darawsheh To: ferruh.yigit@intel.com Cc: dev@dpdk.org, stephen@networkplumber.org Date: Thu, 7 May 2020 12:45:29 +0300 Message-Id: <20200507094529.7117-1-rasland@mellanox.com> X-Mailer: git-send-email 2.26.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM4PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:200:89::14) To AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (188.161.229.217) by AM4PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:200:89::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2979.28 via Frontend Transport; Thu, 7 May 2020 09:46:06 +0000 X-Mailer: git-send-email 2.26.0 X-Originating-IP: [188.161.229.217] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1d6c94b6-e8bf-4bed-227e-08d7f26b76fc X-MS-TrafficTypeDiagnostic: AM0PR05MB6115: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-Forefront-PRVS: 03965EFC76 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N5507jc6+kWC1mfYbZNgPKnj5JfauCgyBN8dsACMYbPNZiA3CP5gzVdyw+ST0uGnRz2nkXWpmByaEOBy96AbgyDo8hr6EDeKWiSyBQCiQ8pa++kdm5mIrtdR6gB0MQ64OApefaDti67Ro/d7YblSld4cBqqm1WOHpGBV0l6FDBALr1qC9rrLbZ7XPaCfo7iOW5VVuDIe5Gx7n5ZphzLbtGXnRZMT8LEQgurge0LQAGdParQzxwSKftrSov1hg5/AY9aZRyPI09YhdMuXIHRTt8yqfwvnOUDZ49C257FERPv0app3c/n496t4XWQ9cpg06q/2/h0p55veukzj2XleQ8X1UYuKrdHJSq8Z29bNftVGzR9z/0Y78A7yTrELplJqNN0cMd2eQE42UK9n4ohv7jbsBYWbeAI5veG2/TPTv9QvFTcqFG6G6mWHvNFpLD566QygZLhFVtoHFLCSoGh3RUBoGNVaPwH0bULWYqt/yi/fxiNYgR2pghxeaHzcYIUm8pp4noJdKwQtoBjiKXuXhQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(136003)(346002)(366004)(376002)(33430700001)(66556008)(66946007)(33440700001)(7696005)(2906002)(52116002)(186003)(36756003)(16526019)(8886007)(6916009)(4326008)(26005)(83290400001)(83300400001)(86362001)(83320400001)(83280400001)(83310400001)(8936002)(55016002)(478600001)(4744005)(6666004)(1076003)(66476007)(316002)(956004)(8676002)(5660300002)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VzZsuTiXCxmhSLLvGmqXzSGEE3NNeoE9b5UnhtWro650zQyAjMsLZj6xC0iNBVnfHnX78IeTKol62wHWprw14Qv/veTCl9q0LPkuyO971cEP2XHaxP+bUtU/S+FvGOKwjzYpkBt3bDiVEk2Jth3JQj7CyuSm1LF7NSVHNBdLFbhfk8Ku4X1sI+lRiacCABN3A1HN9bMqdhZoCccE6P8eH3+QcGmGJcTvDjxUPTzWOTac1EYORFfJBZ6g78v+sEddjNwT8n44+t3cWWl89pxRFpP9U6lzn/IITdxiCvORgsESY2TjScVCAQvcH+HyW1SMrdTa5rp4JqZN3xfQ13ECK8MS3fy7U6J54XZowBJ0aIp+w3e4ODnljrFtfj3jl565L8qSeiUFcz6KP356gcwzK/ZpTUD3XpzjdvHO4CPOI2Yzl46maRkBJuX4LX9vPIFFwk/Fh3scRVcNtC8cS1z8d+VbW0V6fROa/SX7H+OFE2ZgbON0lWJB8wt+4M6/G0AVjsoWsRuKniJWF/Mhe0a0eQVI8FISu8K5jKQrgcSaLEM1xvWRBKpj7CuCLkgCvbfviNS30xrNRSdV7es5ZJCIzIf48t7NUAwnJSlOIaNkBrWAl9fkpDV2hAfEEoMZSFqwnJ+kx5EFRj9kGL08YQeV5gkO34v1X0rx1WXeumS5ELS3Jz1hbEgMYhfVMiLoAaQSzBM2P+IUSuRh+K8VcBx2oMHdUSs48/okrcbPStnBFjbzMnFkGrDJqDyfOTp1C33SPX5m8T4qofPjLGdq+nms/1GCvJ2gauuBULzbB7aSaIsY3Md95EVnJySe5BG3cllq X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6c94b6-e8bf-4bed-227e-08d7f26b76fc X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2020 09:46:06.9594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eR2nX2Iqa0ic2Hg46fmFR5GeT/wB73CRvUPEoOyYvvCADi/XIDcLeHnv7xwLR8Tjn7fbXhHlooIsldrNTgX7Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6115 Subject: [dpdk-dev] [PATCH] net/tap: fix compilation issue with old kernels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With old kernels that don't have support for extended ack the variable one is not used which will cause a compilation failure: drivers/net/tap/tap_netlink.c:48:6: error: unused variable 'one' [-Werror=unused-variable] int one = 1; ^~~ cc1: all warnings being treated as errors Fixes: f11e38d90980 ("net/tap: use netlink extended ack support") Cc: stephen@networkplumber.org Signed-off-by: Raslan Darawsheh --- drivers/net/tap/tap_netlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c index a77486d8e..b73802b51 100644 --- a/drivers/net/tap/tap_netlink.c +++ b/drivers/net/tap/tap_netlink.c @@ -45,7 +45,9 @@ tap_nl_init(uint32_t nl_groups) .nl_family = AF_NETLINK, .nl_groups = nl_groups, }; +#ifdef NETLINK_EXT_ACK int one = 1; +#endif fd = socket(AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, NETLINK_ROUTE); if (fd < 0) { -- 2.26.0