From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: talshn@mellanox.com
Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com,
david.marchand@redhat.com, grive@u256.net,
ranjit.menon@intel.com, navasile@linux.microsoft.com,
anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 3/7] pci: build on Windows
Date: Fri, 8 May 2020 02:27:41 +0300 [thread overview]
Message-ID: <20200508022741.05a644e5@Sovereign> (raw)
In-Reply-To: <20200507121646.624-4-talshn@mellanox.com>
On 2020-05-07 15:16 GMT+0300 talshn@mellanox.com wrote:
> From: Tal Shnaiderman <talshn@mellanox.com>
>
> Added off_t in Windows header file as a supported
> type since it is needed by PCI.
>
> Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
> ---
> lib/librte_eal/windows/include/rte_os.h | 1 +
> lib/meson.build | 5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
> index 62805a307..1c433b976 100644
> --- a/lib/librte_eal/windows/include/rte_os.h
> +++ b/lib/librte_eal/windows/include/rte_os.h
> @@ -48,6 +48,7 @@ extern "C" {
>
> /* as in <windows.h> */
> typedef long long ssize_t;
> +typedef long off_t;
Windows actually has off_t in <sys/types.h>, where it is by POSIX. Shouldn't
rte_pci.h include <sys/types.h> instead? IMO, shims should be kept at minimum.
--
Dmitry Kozlyuk
next prev parent reply other threads:[~2020-05-07 23:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 12:16 [dpdk-dev] [PATCH v3 0/7] Windows bus/pci support talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 1/7] eal: move OS common functions to single file talshn
2020-05-07 23:26 ` Dmitry Kozlyuk
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 2/7] pci: use OS generic memory mapping functions talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 3/7] pci: build on Windows talshn
2020-05-07 23:27 ` Dmitry Kozlyuk [this message]
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 4/7] drivers: ignore pmdinfogen generation for Windows talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 5/7] drivers: fix incorrect meson import folder " talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 6/7] bus/pci: introduce Windows support with stubs talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers talshn
2020-05-07 22:50 ` Dmitry Kozlyuk
2020-05-07 23:06 ` Dmitry Kozlyuk
2020-05-10 9:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508022741.05a644e5@Sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).