From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79CAAA00C5; Fri, 8 May 2020 01:27:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61DB31DBC9; Fri, 8 May 2020 01:27:44 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 0D8851DAB3 for ; Fri, 8 May 2020 01:27:43 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id b26so5963833lfa.5 for ; Thu, 07 May 2020 16:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FsWtvwuCyieJpBIgwXQ7koUeuBma8dLI+A3SbmwxL0I=; b=HcDcUbMbLNxE7jla58I5+yKH14lvL7wIB9ldzZ6YRIE4nMYe0K2rAh/32PPi43uXb1 lumkzTDPrPFgshA5dNOyJUA+AtYDN+SoYRl3dx/ULR2sDdFrQtzRyb//rEwX55mn/a3d JLdA6XZ96A3THH1LCX6ZfvHJK89o58wMj7Kefmxhsx35amDUgKoi4ssd5N8uc8sAh0Vz Crax4ld5CpKbuUAWG67D9b5eBrj27izmZdtWGHolkHJDaXr7xoFAxAS5sTFg7fQhz00I 1ZjDnFzPZvLEhfXEV0D9fRhpSu/0LVfhcloEKLqygESLy+Vex8bf3hZc78liFg7Hr8dz uFqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FsWtvwuCyieJpBIgwXQ7koUeuBma8dLI+A3SbmwxL0I=; b=ietKwAPfEuwboTRqoqZi/wpYKI2JtmgWjEFfhNQxRw35s8LZcSj/wXB8M5E0ERaErL Dy2ILlLQ0lDl7HI+aWsSFng1/+J87osPS165hWwyic2qbUOScw0y71tF+Hqq2i3lSs2/ zuGqfeSN+x+VCCLOEMUMSkZac92fg6Na1+VmYeQwXD+9NXPIoptisBkFHcwX4LAKUUve mQx+MYmRKcm+fgT9EyaJAkD+FTiNuTqoxJS4EFsdwW3yrfhEZSWhhVQpERxRD1t0l+3v lZkNeB6Qt0TLQoFPBfND2v/VcdxlVmP9LBV32qqidbQMJ7OW+dwIw+yeWZYTzjJZ8iHc PgTw== X-Gm-Message-State: AGi0PubEQaoTLq+sOmP6Miv+vYgvDxClDziAAfJoCwkIPRGafC5PNr8b a/33WXvLlYo027SY3SzI5KA= X-Google-Smtp-Source: APiQypLAajy4IleW8naSkNHcAPRXBaGFxrN3YgpPxqqeWNHB5woEVU1fjSHYRjDeXe5qbiRWKU8YqA== X-Received: by 2002:ac2:504c:: with SMTP id a12mr10403215lfm.110.1588894062663; Thu, 07 May 2020 16:27:42 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id r9sm4238707ljg.69.2020.05.07.16.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 16:27:42 -0700 (PDT) Date: Fri, 8 May 2020 02:27:41 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, anatoly.burakov@intel.com Message-ID: <20200508022741.05a644e5@Sovereign> In-Reply-To: <20200507121646.624-4-talshn@mellanox.com> References: <20200507121646.624-1-talshn@mellanox.com> <20200507121646.624-4-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/7] pci: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-05-07 15:16 GMT+0300 talshn@mellanox.com wrote: > From: Tal Shnaiderman > > Added off_t in Windows header file as a supported > type since it is needed by PCI. > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/windows/include/rte_os.h | 1 + > lib/meson.build | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h > index 62805a307..1c433b976 100644 > --- a/lib/librte_eal/windows/include/rte_os.h > +++ b/lib/librte_eal/windows/include/rte_os.h > @@ -48,6 +48,7 @@ extern "C" { > > /* as in */ > typedef long long ssize_t; > +typedef long off_t; Windows actually has off_t in , where it is by POSIX. Shouldn't rte_pci.h include instead? IMO, shims should be kept at minimum. -- Dmitry Kozlyuk