From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA44DA00C5; Fri, 8 May 2020 10:44:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E3F61DB33; Fri, 8 May 2020 10:44:04 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 40DA01DB24; Fri, 8 May 2020 10:44:01 +0200 (CEST) IronPort-SDR: AsLKCm/26BGUAYniSsSTRyUSsh/QeuhzcDMgAtU4V3SoarSbNjbGZFqBdJ5yLy1jVaQC5ytmh1 jftekM8r7tvw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 01:44:00 -0700 IronPort-SDR: T12cHGh5val1wvgQJvHuIDDM4j41F9cmSUhdUD9rUNfKKRnBdQR6OzH10mIDE6w6Ylv7xVYzUl o0KWgyobnESA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,367,1583222400"; d="scan'208";a="251765229" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 08 May 2020 01:43:58 -0700 Date: Fri, 8 May 2020 16:36:07 +0800 From: Ye Xiaolong To: Phil Yang Cc: "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "wenzhuo.lu@intel.com" , "qi.z.zhang@intel.com" , Lijian Zhang , Gavin Hu , Honnappa Nagarahalli , nd , "stable@dpdk.org" Message-ID: <20200508083607.GE75514@intel.com> References: <1584600111-17412-1-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/08, Phil Yang wrote: >> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber >> ports >> >> With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it >> is possible when a port is started to experience a timing issue >> which prevents the link from ever being fully set up. >> >> In ixgbe_dev_link_update_share(), if the media type is fiber and the >> link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback >> to ixgbe_dev_setup_link_thread_handler() is scheduled which should >> try to set up the link and clear the flag afterwards. >> >> If the device is started before the flag is cleared, the scheduled >> callback is cancelled. This causes the flag to remain set and >> subsequent calls to ixgbe_dev_link_update_share() return >> without trying to retrieve the link state because the flag is set. >> >> In ixgbe_dev_cancel_link_thread(), after cancelling the callback, >> unset the flag on the device to avoid this condition. >> >> Fixes: 819d0d1d57f1 ("net/ixgbe: fix blocking system events") >> Cc: stable@dpdk.org >> >> Bugzilla ID: 388 >> >> Signed-off-by: Phil Yang >> Signed-off-by: Lijian Zhang >> Reviewed-by: Gavin Hu >> --- > >Ping. This fix makes sense to me, thanks for the work. And it seems can't be applied to latest dpdk-next-net-intel cleanly, could you do a rebase? Thanks, Xiaolong > >Thanks, >Phil > >