* [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
@ 2020-05-07 1:15 Wei Zhao
2020-05-07 1:52 ` Lu, Nannan
2020-05-11 2:55 ` Ye Xiaolong
0 siblings, 2 replies; 4+ messages in thread
From: Wei Zhao @ 2020-05-07 1:15 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, nannan.lu, Wei Zhao
The dummy packet for pppoe-ipv6 has an error, we should
use 0x3b for next header in ipv6 header in the dummy packet,
or some case can not be download, such as:
"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 /
end actions vf id 1 / end"
Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ice/base/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
index 957142a10..a07ceea70 100644
--- a/drivers/net/ice/base/ice_switch.c
+++ b/drivers/net/ice/base/ice_switch.c
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
0x00, 0x57, /* PPP Link Layer 24 */
0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
- 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x3b, 0x00,
0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
--
2.19.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
2020-05-07 1:15 [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error Wei Zhao
@ 2020-05-07 1:52 ` Lu, Nannan
2020-05-09 5:36 ` Zhang, Qi Z
2020-05-11 2:55 ` Ye Xiaolong
1 sibling, 1 reply; 4+ messages in thread
From: Lu, Nannan @ 2020-05-07 1:52 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Zhang, Qi Z
Tested-by: Lu, Nannan <nannan.lu@intel.com>
-----Original Message-----
From: Zhao1, Wei
Sent: Thursday, May 7, 2020 9:16 AM
To: dev@dpdk.org
Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Nannan <nannan.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:
"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"
Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ice/base/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
index 957142a10..a07ceea70 100644
--- a/drivers/net/ice/base/ice_switch.c
+++ b/drivers/net/ice/base/ice_switch.c
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
0x00, 0x57, /* PPP Link Layer 24 */
0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
- 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x3b, 0x00,
0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
--
2.19.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
2020-05-07 1:52 ` Lu, Nannan
@ 2020-05-09 5:36 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2020-05-09 5:36 UTC (permalink / raw)
To: Lu, Nannan, Zhao1, Wei, dev
> -----Original Message-----
> From: Lu, Nannan <nannan.lu@intel.com>
> Sent: Thursday, May 7, 2020 9:52 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
>
> Tested-by: Lu, Nannan <nannan.lu@intel.com>
>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Thursday, May 7, 2020 9:16 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Nannan <nannan.lu@intel.com>;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
>
> The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next
> header in ipv6 header in the dummy packet, or some case can not be download,
> such as:
>
> "eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"
>
> Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error
2020-05-07 1:15 [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error Wei Zhao
2020-05-07 1:52 ` Lu, Nannan
@ 2020-05-11 2:55 ` Ye Xiaolong
1 sibling, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2020-05-11 2:55 UTC (permalink / raw)
To: Wei Zhao; +Cc: dev, qi.z.zhang, nannan.lu
On 05/07, Wei Zhao wrote:
>The dummy packet for pppoe-ipv6 has an error, we should
>use 0x3b for next header in ipv6 header in the dummy packet,
>or some case can not be download, such as:
>
>"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 /
>end actions vf id 1 / end"
>
>Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
>
>Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>---
> drivers/net/ice/base/ice_switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
>index 957142a10..a07ceea70 100644
>--- a/drivers/net/ice/base/ice_switch.c
>+++ b/drivers/net/ice/base/ice_switch.c
>@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
> 0x00, 0x57, /* PPP Link Layer 24 */
>
> 0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
>- 0x00, 0x00, 0x00, 0x00,
>+ 0x00, 0x00, 0x3b, 0x00,
> 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00,
>--
>2.19.1
>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-11 3:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 1:15 [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error Wei Zhao
2020-05-07 1:52 ` Lu, Nannan
2020-05-09 5:36 ` Zhang, Qi Z
2020-05-11 2:55 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).