From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A86AAA0350; Mon, 11 May 2020 05:03:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E8D41D152; Mon, 11 May 2020 05:03:51 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D35DB1C23C for ; Mon, 11 May 2020 05:03:49 +0200 (CEST) IronPort-SDR: a98PVjFZ5/aIBlflsGlFcX4J3VlaS452TuAKmSneXbfh+5mVySI8rTYwNFGLDUsRGgP1HsbMpZ 5Z1Sy3+nlZoA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 20:03:48 -0700 IronPort-SDR: giFuxr/skbjyjqP0WzHo09riDHgz02JJsfJYxPTSnNhM3xmNczAxhSb6UqRn4R+pZRzuqBOti/ djpAyqPA47mA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="252480734" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 10 May 2020 20:03:47 -0700 Date: Mon, 11 May 2020 10:55:46 +0800 From: Ye Xiaolong To: Wei Zhao Cc: dev@dpdk.org, qi.z.zhang@intel.com, nannan.lu@intel.com Message-ID: <20200511025546.GK75514@intel.com> References: <20200507011541.66624-1-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507011541.66624-1-wei.zhao1@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/07, Wei Zhao wrote: >The dummy packet for pppoe-ipv6 has an error, we should >use 0x3b for next header in ipv6 header in the dummy packet, >or some case can not be download, such as: > >"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / >end actions vf id 1 / end" > >Fixes: 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet") > >Signed-off-by: Wei Zhao >--- > drivers/net/ice/base/ice_switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c >index 957142a10..a07ceea70 100644 >--- a/drivers/net/ice/base/ice_switch.c >+++ b/drivers/net/ice/base/ice_switch.c >@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = { > 0x00, 0x57, /* PPP Link Layer 24 */ > > 0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */ >- 0x00, 0x00, 0x00, 0x00, >+ 0x00, 0x00, 0x3b, 0x00, > 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, >-- >2.19.1 > Applied to dpdk-next-net-intel, Thanks.