From: Ye Xiaolong <xiaolong.ye@intel.com>
To: alvinx.zhang@intel.com
Cc: dev@dpdk.org, wei.zhao1@intel.com, jia.guo@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] net/igc: remove some useless log
Date: Mon, 11 May 2020 10:57:42 +0800 [thread overview]
Message-ID: <20200511025742.GL75514@intel.com> (raw)
In-Reply-To: <20200507093636.19008-1-alvinx.zhang@intel.com>
On 05/07, alvinx.zhang@intel.com wrote:
>From: Alvin Zhang <alvinx.zhang@intel.com>
>
>Some log will always be printed when the device is initialized
>and shut down, which will mislead users and should be removed.
>
>Fixes: 746664d546fb (net/igc: implement flow API)
>Cc: stable@dpdk.org
>
>Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>---
>
>V2: update git log
>
> drivers/net/igc/igc_txrx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
>index 5b269b6..4654ec4 100644
>--- a/drivers/net/igc/igc_txrx.c
>+++ b/drivers/net/igc/igc_txrx.c
>@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
> {
> struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
>
>- if (!rss_filter->enable) {
>- PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
>+ if (!rss_filter->enable)
> return;
>- }
>
> /* recover default RSS configuration */
> igc_rss_configure(dev);
>--
>1.8.3.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2020-05-11 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 6:23 [dpdk-dev] [PATCH] " alvinx.zhang
2020-05-07 6:31 ` Ye Xiaolong
2020-05-07 7:22 ` Zhang, AlvinX
2020-05-07 9:36 ` [dpdk-dev] [PATCH v2] " alvinx.zhang
2020-05-11 2:57 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511025742.GL75514@intel.com \
--to=xiaolong.ye@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).