From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABC23A0350; Mon, 11 May 2020 05:05:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 267C31D151; Mon, 11 May 2020 05:05:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 23F0E1D150 for ; Mon, 11 May 2020 05:05:45 +0200 (CEST) IronPort-SDR: rXQ+83/EyYL6MkSjVlvCTOK9VpZ/wgq4Re4INmTe0xNDMC8jFuyzBH2Dssllj5aKQcOP7KzPC2 ZUS5d2tLdsjg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 20:05:45 -0700 IronPort-SDR: PzVPCsWuwVkBCAJi3KXZo2sa/+QX94iFPlHxKN2+R/ExKlBYWtwYsYwl/IPMM1USc5lAe4n5PO 3w1FFvJSMZsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="252481153" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 10 May 2020 20:05:44 -0700 Date: Mon, 11 May 2020 10:57:42 +0800 From: Ye Xiaolong To: alvinx.zhang@intel.com Cc: dev@dpdk.org, wei.zhao1@intel.com, jia.guo@intel.com Message-ID: <20200511025742.GL75514@intel.com> References: <20200430062326.20676-1-alvinx.zhang@intel.com> <20200507093636.19008-1-alvinx.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507093636.19008-1-alvinx.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/igc: remove some useless log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/07, alvinx.zhang@intel.com wrote: >From: Alvin Zhang > >Some log will always be printed when the device is initialized >and shut down, which will mislead users and should be removed. > >Fixes: 746664d546fb (net/igc: implement flow API) >Cc: stable@dpdk.org > >Signed-off-by: Alvin Zhang >--- > >V2: update git log > > drivers/net/igc/igc_txrx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c >index 5b269b6..4654ec4 100644 >--- a/drivers/net/igc/igc_txrx.c >+++ b/drivers/net/igc/igc_txrx.c >@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset) > { > struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev); > >- if (!rss_filter->enable) { >- PMD_DRV_LOG(WARNING, "RSS filter not enabled!"); >+ if (!rss_filter->enable) > return; >- } > > /* recover default RSS configuration */ > igc_rss_configure(dev); >-- >1.8.3.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.