DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/iavf: delete unused value
@ 2020-05-11  8:36 Leyi Rong
  2020-05-12  5:44 ` Ye Xiaolong
  0 siblings, 1 reply; 2+ messages in thread
From: Leyi Rong @ 2020-05-11  8:36 UTC (permalink / raw)
  To: xiaolong.ye; +Cc: dev, Leyi Rong

Fix coverity defects of unused value.

Coverity issue: 357745, 357769

Fixes: b8b4c54ef9b0 ("net/iavf: support flexible Rx descriptor in normal path")

Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
 drivers/net/iavf/iavf_rxtx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 2cf70d929..05a7dd898 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -958,7 +958,6 @@ iavf_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 			rte_prefetch0(rxq->sw_ring[rx_id]);
 		}
 		rxm = rxe;
-		rxe = nmb;
 		dma_addr =
 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
 		rxdp->read.hdr_addr = 0;
@@ -1064,7 +1063,6 @@ iavf_recv_pkts_flex_rxd(void *rx_queue,
 			rte_prefetch0(rxq->sw_ring[rx_id]);
 		}
 		rxm = rxe;
-		rxe = nmb;
 		dma_addr =
 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
 		rxdp->read.hdr_addr = 0;
@@ -1157,7 +1155,6 @@ iavf_recv_scattered_pkts_flex_rxd(void *rx_queue, struct rte_mbuf **rx_pkts,
 		}
 
 		rxm = rxe;
-		rxe = nmb;
 		dma_addr =
 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
 
@@ -1311,7 +1308,6 @@ iavf_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 		}
 
 		rxm = rxe;
-		rxe = nmb;
 		dma_addr =
 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/iavf: delete unused value
  2020-05-11  8:36 [dpdk-dev] [PATCH] net/iavf: delete unused value Leyi Rong
@ 2020-05-12  5:44 ` Ye Xiaolong
  0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2020-05-12  5:44 UTC (permalink / raw)
  To: Leyi Rong; +Cc: dev

On 05/11, Leyi Rong wrote:
>Fix coverity defects of unused value.
>
>Coverity issue: 357745, 357769
>
>Fixes: b8b4c54ef9b0 ("net/iavf: support flexible Rx descriptor in normal path")
>
>Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>---
> drivers/net/iavf/iavf_rxtx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
>index 2cf70d929..05a7dd898 100644
>--- a/drivers/net/iavf/iavf_rxtx.c
>+++ b/drivers/net/iavf/iavf_rxtx.c
>@@ -958,7 +958,6 @@ iavf_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> 			rte_prefetch0(rxq->sw_ring[rx_id]);
> 		}
> 		rxm = rxe;
>-		rxe = nmb;
> 		dma_addr =
> 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
> 		rxdp->read.hdr_addr = 0;
>@@ -1064,7 +1063,6 @@ iavf_recv_pkts_flex_rxd(void *rx_queue,
> 			rte_prefetch0(rxq->sw_ring[rx_id]);
> 		}
> 		rxm = rxe;
>-		rxe = nmb;
> 		dma_addr =
> 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
> 		rxdp->read.hdr_addr = 0;
>@@ -1157,7 +1155,6 @@ iavf_recv_scattered_pkts_flex_rxd(void *rx_queue, struct rte_mbuf **rx_pkts,
> 		}
> 
> 		rxm = rxe;
>-		rxe = nmb;
> 		dma_addr =
> 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
> 
>@@ -1311,7 +1308,6 @@ iavf_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
> 		}
> 
> 		rxm = rxe;
>-		rxe = nmb;
> 		dma_addr =
> 			rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));
> 
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-12  5:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11  8:36 [dpdk-dev] [PATCH] net/iavf: delete unused value Leyi Rong
2020-05-12  5:44 ` Ye Xiaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).