From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79181A0350; Mon, 11 May 2020 10:41:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9E451C22F; Mon, 11 May 2020 10:41:30 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7DFC51C225 for ; Mon, 11 May 2020 10:41:29 +0200 (CEST) IronPort-SDR: LVNWIhFeHpCrrgPfpuPrRusSb2/7S5JeZxU3LMKw0TdYmI0KjapogpMbFT2LM/2RXP/mJMeMCM riFx3eX9rYXw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 01:41:28 -0700 IronPort-SDR: hmHeyiL0C/Ec50V0gQFg0hPaAihOCrrJ+YnbbI5yzmTYyp4Ku6GhU8LHYXVu8dM5Qf+dBzDe4G ehgkLLDgaxHg== X-IronPort-AV: E=Sophos;i="5.73,379,1583222400"; d="scan'208";a="408853293" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.48]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 May 2020 01:41:25 -0700 Date: Mon, 11 May 2020 09:41:22 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Ciara Power , dev@dpdk.org, kevin.laatz@intel.com, reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com, keith.wiles@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, bluca@debian.org Message-ID: <20200511084122.GA1957@bricha3-MOBL.ger.corp.intel.com> References: <20200319171907.60891-1-ciara.power@intel.com> <20200430160137.59135-1-ciara.power@intel.com> <20200430160137.59135-16-ciara.power@intel.com> <19147519.Yz81rIOvuz@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19147519.Yz81rIOvuz@thomas> Subject: Re: [dpdk-dev] [PATCH v5 15/18] lib: add telemetry as eal dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 12:29:17AM +0200, Thomas Monjalon wrote: > 30/04/2020 18:01, Ciara Power: > > This patch moves telemetry further down the build, and adds it as a > > dependency for EAL. Telemetry V2 is now configured to build by default, > > and the legacy support is built when the telemetry config flag is set. > > > > Telemetry now has EAL flags, shown below: > > "--telemetry" = Enables telemetry (this is default if no flags given) > > What is the need for enabling something already enabled? > So we don't get an error when somebody who used to pass in the parameter e.g. from their scripts, continues to do so. Having it on the list is pretty harmless, but helps a lot with backward compatibility. > > "--no-telemetry" = Disables telemetry > [...] > > + case OPT_TELEMETRY_NUM: > > + break; > > + case OPT_NO_TELEMETRY_NUM: > > + conf->no_telemetry = 1; > > + break; > > I feel one option would be enough. >