From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Kevin Laatz <kevin.laatz@intel.com>,
Ciara Power <ciara.power@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: [dpdk-dev] [PATCH] telemetry: fix error log output
Date: Mon, 11 May 2020 17:09:31 +0200 [thread overview]
Message-ID: <20200511150931.1693-1-david.marchand@redhat.com> (raw)
Caught while running testpmd:
No telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected
Add missing \n.
Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_telemetry/telemetry.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c
index 9a1e945455..56a2fed3f5 100644
--- a/lib/librte_telemetry/telemetry.c
+++ b/lib/librte_telemetry/telemetry.c
@@ -275,8 +275,8 @@ socket_listener(void *socket)
int s_accepted = accept(s->sock, NULL, NULL);
if (s_accepted < 0) {
snprintf(telemetry_log_error,
- sizeof(telemetry_log_error),
- "Error with accept, telemetry thread quitting\n");
+ sizeof(telemetry_log_error),
+ "Error with accept, telemetry thread quitting");
return NULL;
}
pthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);
@@ -400,12 +400,12 @@ rte_telemetry_init(const char *runtime_dir, const char **err_str)
{
if (telemetry_v2_init(runtime_dir) != 0) {
*err_str = telemetry_log_error;
- printf("Error initialising telemetry - %s", *err_str);
+ printf("Error initialising telemetry - %s\n", *err_str);
return -1;
}
if (telemetry_legacy_init(runtime_dir) != 0) {
*err_str = telemetry_log_error;
- printf("No telemetry legacy support- %s", *err_str);
+ printf("No telemetry legacy support - %s\n", *err_str);
}
return 0;
}
--
2.23.0
next reply other threads:[~2020-05-11 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 15:09 David Marchand [this message]
2020-05-11 16:38 ` Bruce Richardson
2020-05-11 16:59 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511150931.1693-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).