From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8945A0350; Mon, 11 May 2020 17:09:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EF261C197; Mon, 11 May 2020 17:09:47 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 032AA1C197 for ; Mon, 11 May 2020 17:09:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589209783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rCjjqzdjrwtOKg23LwnFzjxHrOlXGdDy8DYJknOMxos=; b=RUbAtetLNWCS9u2CscCPmOoac2wIqFNZq7wmrOON2cxCq/qkxmWlnVpkCdw6XaHO2gJkQb 6Y0l7Xp7WTHu+8c7H5h8NkOcnoXMYzKCOZlwYPHwgeWzo4lA3ZEChVYZk22mvAaGugkjW7 jvkSmQxpdy0rBI6RSyRBNlfUSQn6y28= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-HQcJ2QYmMfqtYzBqPrTcSQ-1; Mon, 11 May 2020 11:09:41 -0400 X-MC-Unique: HQcJ2QYmMfqtYzBqPrTcSQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 148618014C0; Mon, 11 May 2020 15:09:40 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7ECC267642; Mon, 11 May 2020 15:09:38 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Kevin Laatz , Ciara Power , Bruce Richardson , Keith Wiles Date: Mon, 11 May 2020 17:09:31 +0200 Message-Id: <20200511150931.1693-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] telemetry: fix error log output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Caught while running testpmd: No telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected Add missing \n. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Signed-off-by: David Marchand --- lib/librte_telemetry/telemetry.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c index 9a1e945455..56a2fed3f5 100644 --- a/lib/librte_telemetry/telemetry.c +++ b/lib/librte_telemetry/telemetry.c @@ -275,8 +275,8 @@ socket_listener(void *socket) int s_accepted = accept(s->sock, NULL, NULL); if (s_accepted < 0) { snprintf(telemetry_log_error, - sizeof(telemetry_log_error), - "Error with accept, telemetry thread quitting\n"); + sizeof(telemetry_log_error), + "Error with accept, telemetry thread quitting"); return NULL; } pthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted); @@ -400,12 +400,12 @@ rte_telemetry_init(const char *runtime_dir, const char **err_str) { if (telemetry_v2_init(runtime_dir) != 0) { *err_str = telemetry_log_error; - printf("Error initialising telemetry - %s", *err_str); + printf("Error initialising telemetry - %s\n", *err_str); return -1; } if (telemetry_legacy_init(runtime_dir) != 0) { *err_str = telemetry_log_error; - printf("No telemetry legacy support- %s", *err_str); + printf("No telemetry legacy support - %s\n", *err_str); } return 0; } -- 2.23.0