DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] telemetry: fix error log output
@ 2020-05-11 15:09 David Marchand
  2020-05-11 16:38 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2020-05-11 15:09 UTC (permalink / raw)
  To: dev; +Cc: Kevin Laatz, Ciara Power, Bruce Richardson, Keith Wiles

Caught while running testpmd:
No telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected

Add missing \n.

Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_telemetry/telemetry.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c
index 9a1e945455..56a2fed3f5 100644
--- a/lib/librte_telemetry/telemetry.c
+++ b/lib/librte_telemetry/telemetry.c
@@ -275,8 +275,8 @@ socket_listener(void *socket)
 		int s_accepted = accept(s->sock, NULL, NULL);
 		if (s_accepted < 0) {
 			snprintf(telemetry_log_error,
-					sizeof(telemetry_log_error),
-					"Error with accept, telemetry thread quitting\n");
+				sizeof(telemetry_log_error),
+				"Error with accept, telemetry thread quitting");
 			return NULL;
 		}
 		pthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);
@@ -400,12 +400,12 @@ rte_telemetry_init(const char *runtime_dir, const char **err_str)
 {
 	if (telemetry_v2_init(runtime_dir) != 0) {
 		*err_str = telemetry_log_error;
-		printf("Error initialising telemetry - %s", *err_str);
+		printf("Error initialising telemetry - %s\n", *err_str);
 		return -1;
 	}
 	if (telemetry_legacy_init(runtime_dir) != 0) {
 		*err_str = telemetry_log_error;
-		printf("No telemetry legacy support- %s", *err_str);
+		printf("No telemetry legacy support - %s\n", *err_str);
 	}
 	return 0;
 }
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-11 16:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 15:09 [dpdk-dev] [PATCH] telemetry: fix error log output David Marchand
2020-05-11 16:38 ` Bruce Richardson
2020-05-11 16:59   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).