From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAD3CA04A2; Tue, 12 May 2020 11:50:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D19581C012; Tue, 12 May 2020 11:50:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 038B71BFF4 for ; Tue, 12 May 2020 11:50:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04C9UHDi006555; Tue, 12 May 2020 02:50:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=pfpt0818; bh=Qpz/2s3t4ma3RKA6xd8UPJQqo6xL0B6MNLaBRkOP6P8=; b=kW46GfJirjaJUEv/n3LcYbEXooqSm0SFnOoriebXPJngIvqcNSeF6fa9QvloXKRmzdUZ kfZvLd++rjcuONkFOoACF7LxU6fnEdRoRz93ltHkCvCAecqv+fKVd23qdEqUvre68s7N rrpgfsSt2OTcdEwTWsFS9FgD4j4uVYOqrT0RXxDA3h8B69u1c/09Mo2cbalup5cyVBK4 Hx6i8sZiRE9YYJ0R531U0tSKoJNY0U2D1ckaz3xf8B7Ga1bY/3JtT+9JZsiv2UfL8nlw ApBwQgkHlcjTPpvQYwT9zY8dfVjEQRE9/WebpR0A2G1qlh3IQt+LA48QuCPtiIoF3lDP xA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 30wv1narf0-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 May 2020 02:50:25 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 May 2020 02:50:23 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 May 2020 02:50:23 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 12 May 2020 02:50:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RRBdRKDV1Vz95tRsCARn3nMuO4/bpDS31ZrJ0JJFscp8Vbq8uuvjWhFgcgNYerVlwLhxWcgLBgJzk0TUkHonQ6vLc2yMoutpJcSpU3nqeHczf2hR0EFq5C9uvFuK7EQy0jeYnzuVEfQqXUopZovYhLSBqbz0PdFdf5W4wfPT3wokN1vpJkBswbBJPl8r0GMDEqte0MotGw6rBFqa2UtaCxbIRtqQoRkzBSV42Lqeiy7JEQ8atfK3PK7JeHichrYjN4jz3kHUeWujewr7ECVSNgdUAUi48tUSuMY03Xxo2wZ965yT1q2jmSaoo/sSDDpCUwoRi1INTuzj7l8+gMiM7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qpz/2s3t4ma3RKA6xd8UPJQqo6xL0B6MNLaBRkOP6P8=; b=C1OnLk7H4F33JnqWPyU7cgYY8vx+ooQXyIYd2H/Hy3g5tlDS0ZVGz62SIQ+fu3S0S2neB2uowCCw0cyMmyXh4Wme/1CT4Ty8lg9tTiJz1UtZhk4ll/+Bqu0M/DEgSdNky4I1dy/sP1vCHJSoa4v/gMuHNdOzS/82f5EdF5jei+awp9G7z6MgnjTYL0tIa6lb8LY4KFTrTvUUWFLmdBg76/bt2o77x42FtyvG9VZWoP7GOhLUoS//31hNZuuEKcyUWXoQ/ZhuyzgRhE4YYOaMhSqqIq2oIgyR6vKBMNK/d6k3GkkEOuhks9/h2tpOqoV0zeUHdt2CiTtOzaJnjO2MXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qpz/2s3t4ma3RKA6xd8UPJQqo6xL0B6MNLaBRkOP6P8=; b=iXciq6HRKOLxyFyjuhM8rxBHDa8RlMnzoOnHcPpf26NTzBgjdzZPrVIYcQrHm/2Eu+NtcHcUYA6PldsyweRuRdKIW/Jm8N85PASD7NgyZqsBi+9xDzFygElIgO63uNSAa/Kttcpf2P6HtF70CFxZ/axfBDk9zT61S9TK6zuEmBc= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2615.namprd18.prod.outlook.com (2603:10b6:a03:139::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Tue, 12 May 2020 09:50:21 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.2979.033; Tue, 12 May 2020 09:50:20 +0000 Date: Tue, 12 May 2020 15:20:05 +0530 From: Nithin Dabilpuram To: David Marchand CC: Jerin Jacob Kollanukkaran , Pavan Nikhilesh , dev , Thomas Monjalon , Ray Kinsella , Mattias =?iso-8859-1?Q?R=F6nnblom?= , "Kiran Kumar Kokkilagadda" , Xiao Wang , Andrzej Ostruszka Message-ID: <20200512095005.GA23383@outlook.office365.com> References: <20200405085613.1336841-1-jerinj@marvell.com> <20200411141428.1987768-1-jerinj@marvell.com> <20200411141428.1987768-21-jerinj@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::28) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Tue, 12 May 2020 09:50:17 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41ed55e1-96cd-49ba-ed52-08d7f659e22e X-MS-TrafficTypeDiagnostic: BYAPR18MB2615: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0401647B7F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bdZCel3OHg+iPo/wpTR7epv+dVDvhXMaKbsjmGfm3BxOi4m/3864UgGum0eaNK+Va7TSUIVQyTEwEonuGx6/ZOb+ZThR172ZnFP8pkTgOdMp7wgIxE39V1c6NeizryeEJ9KRhzIy864Gn8bVlrqC40NCZ/IvXE73DeIxl9HQXMYnAvzC3d8SYUw24vhB6O4mVcLmSXyWRwY8+XKHeK/Lr2CuPG7dDCmFIT8SgfiHM9zNcZhewpdww140BeY5HBb/aeQhMSXe1VHqrB7kvm2kwMx0XhKVZ12hoW/a8hI1xTpyud72Gv1CsbS5dkpjsYdqeXss4Oir0FLtdvx9bdirFVp4NIUzYEUJlKrPxahQ4BwZWRYR5Qpk6dwo/l2TiR01uXJvnkKwAo/M80Mw+jzXLPA4KNK7VkRQz4RTSp++WcyTEtrTGs2qcP8WweLd44q1fACHxDfN0EitDM2zljuL3FHh6VNU6aOTdR4EwdqeHvr4f/iAR8le5OPuGxtEDmXSzpBCbRQtjmTOJu9OtKIC0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(366004)(39860400002)(376002)(136003)(33430700001)(4326008)(8936002)(5660300002)(55016002)(33656002)(66946007)(66476007)(478600001)(1076003)(6916009)(66556008)(33440700001)(2906002)(6666004)(55236004)(9686003)(186003)(6506007)(86362001)(316002)(26005)(53546011)(8676002)(956004)(52116002)(7696005)(16526019)(54906003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: NgKIsXGHH5pkJ3gHpxGSgWBu/5n1XrHP1Y1KUo/BqbG199UHjU6yEw5TYxuA+bmd5u2W1EMAn77GBb/93JyUCf3tolEqRI87JtVBa2k1EsPOxBoIua1XnYS7eiPgp0C0jpwuyvGEZ2HDfPrueMb5aQZmvCGx3xwpHA9qi2liLuJv/BtykpdbfrGMkmWzjkXlTLzpU/SZTbUdHfQHIwnd2HMV85QRKM5nh4l4YpQ8vp62xDDJkAYJ+lqEbJD7MMgbHN8pG67xxbFKCTdfWJko4Gu7+Tvuq77a98xTX65GkvL7g3iQerGDz8HWMr8W4YOLSZAkf7iZxBl8Y+sIfJq0Wlz8nZGrqEw9jQduKT8ZAslqH4+njeJkB8e4TbX5MHUmKcQWsscRHXZHmAmApYjYRWTsSuJ+2fyh9tEku1oCu3t8PR+NXyApFrBzMqyQ0OFynr9ijahtAcmvQi8zGbOMXv8P5k6Qh6sdiilY21IBsLI= X-MS-Exchange-CrossTenant-Network-Message-Id: 41ed55e1-96cd-49ba-ed52-08d7f659e22e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2020 09:50:20.6671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ts/us4Z/kPvbs3Dcd0xvANKRBLndi056a3goqqAR6mEoWO5L66d6DamsuRGRBn9XGKSFRqiKwIqX4r59aoOfsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2615 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-12_02:2020-05-11, 2020-05-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v5 20/29] node: ipv4 lookup for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 12, 2020 at 11:31:26AM +0200, David Marchand wrote: > External Email > > ---------------------------------------------------------------------- > On Sat, Apr 11, 2020 at 4:16 PM wrote: > > > > From: Nithin Dabilpuram > > > > Add arm64 specific IPv4 lookup process function > > for ip4_lookup node. This node performs LPM lookup > > on every packet received and forwards it to a next > > node that is identified by lookup result. > > > > Signed-off-by: Nithin Dabilpuram > > Signed-off-by: Kiran Kumar K > > Signed-off-by: Pavan Nikhilesh > > --- > > lib/librte_node/ip4_lookup.c | 6 + > > lib/librte_node/ip4_lookup_neon.h | 238 ++++++++++++++++++++++++++++++ > > 2 files changed, 244 insertions(+) > > create mode 100644 lib/librte_node/ip4_lookup_neon.h > > Checking OVS dpdk-latest branch, I caught a build issue on Ubuntu > 16.04 for aarch64. > I reproduced it in travis by forcing the distribution to xenial in .travis.yml. > > FAILED: gcc -Ilib/lib@@rte_node@sta -Ilib -I../lib -Ilib/librte_node > -I../lib/librte_node -I. -I../ -Iconfig -I../config > -Ilib/librte_eal/include -I../lib/librte_eal/include > -Ilib/librte_eal/linux/include -I../lib/librte_eal/linux/include > -Ilib/librte_eal/arm/include -I../lib/librte_eal/arm/include > -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal > -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs > -Ilib/librte_telemetry/../librte_metrics > -I../lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry > -I../lib/librte_telemetry -Ilib/librte_graph -I../lib/librte_graph > -Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool > -I../lib/librte_mempool -Ilib/librte_ring -I../lib/librte_ring > -Ilib/librte_lpm -I../lib/librte_lpm -Ilib/librte_hash > -I../lib/librte_hash -Ilib/librte_ethdev -I../lib/librte_ethdev > -Ilib/librte_net -I../lib/librte_net -Ilib/librte_meter > -I../lib/librte_meter -Ilib/librte_cryptodev -I../lib/librte_cryptodev > -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall > -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual > -Wdeprecated -Wformat-nonliteral -Wformat-security > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -fno-strict-aliasing > -MD -MQ 'lib/lib@@rte_node@sta/librte_node_ip4_lookup.c.o' -MF > 'lib/lib@@rte_node@sta/librte_node_ip4_lookup.c.o.d' -o > 'lib/lib@@rte_node@sta/librte_node_ip4_lookup.c.o' -c > ../lib/librte_node/ip4_lookup.c > In file included from ../lib/librte_node/ip4_lookup.c:34:0: > ../lib/librte_node/ip4_lookup_neon.h: In function ‘ip4_lookup_node_process’: > ../lib/librte_node/ip4_lookup_neon.h:25:12: error: ‘dip’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > int32x4_t dip; > ^ > cc1: all warnings being treated as errors > ninja: build stopped: subcommand failed. > > > The odd thing is that a more recent gcc does not complain. > So there must be a catch, can you have a look? > Thanks. > Sure. Thanks. Will test and get back. > > -- > David Marchand >