* [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing
@ 2020-05-12 20:40 Stephen Hemminger
2020-05-13 22:24 ` Yong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2020-05-12 20:40 UTC (permalink / raw)
To: yongwang; +Cc: dev, Stephen Hemminger
The VMXNet3 protocol has a start-of-packet (SOP) and end-of-packet (EOP)
marker. If there was a bug where mbuf arrived without SOP the code
that chains the mbuf would dereference a null pointer.
Also, record any mbuf's dropped in statistics.
Although did the initial code no longer have access to VMware.
Compile tested only!
Coverity issue: 124563
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index dd99684bee4d..73e270f30f00 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -950,13 +950,17 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
RTE_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
- if (rxm->data_len) {
+ if (likely(start && rxm->data_len > 0)) {
start->pkt_len += rxm->data_len;
start->nb_segs++;
rxq->last_seg->next = rxm;
rxq->last_seg = rxm;
} else {
+ PMD_RX_LOG(ERR, "Error received empty or out of order frame.");
+ rxq->stats.drop_total++;
+ rxq->stats.drop_err++;
+
rte_pktmbuf_free_seg(rxm);
}
}
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing
2020-05-12 20:40 [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing Stephen Hemminger
@ 2020-05-13 22:24 ` Yong Wang
2020-05-14 16:15 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2020-05-13 22:24 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tuesday, May 12, 2020 at 1:40 PM
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] net/vmxnet3: handle bad host framing
The VMXNet3 protocol has a start-of-packet (SOP) and end-of-packet (EOP)
marker. If there was a bug where mbuf arrived without SOP the code
that chains the mbuf would dereference a null pointer.
Also, record any mbuf's dropped in statistics.
Although did the initial code no longer have access to VMware.
Compile tested only!
Coverity issue: 124563
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
<Acked-by> Yong Wang <yongwang@vmware.com>
drivers/net/vmxnet3/vmxnet3_rxtx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index dd99684bee4d..73e270f30f00 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -950,13 +950,17 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
RTE_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
- if (rxm->data_len) {
+ if (likely(start && rxm->data_len > 0)) {
start->pkt_len += rxm->data_len;
start->nb_segs++;
rxq->last_seg->next = rxm;
rxq->last_seg = rxm;
} else {
+ PMD_RX_LOG(ERR, "Error received empty or out of order frame.");
+ rxq->stats.drop_total++;
+ rxq->stats.drop_err++;
+
rte_pktmbuf_free_seg(rxm);
}
}
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing
2020-05-13 22:24 ` Yong Wang
@ 2020-05-14 16:15 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-05-14 16:15 UTC (permalink / raw)
To: Yong Wang, Stephen Hemminger; +Cc: dev
On 5/13/2020 11:24 PM, Yong Wang wrote:
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Tuesday, May 12, 2020 at 1:40 PM
> To: Yong Wang <yongwang@vmware.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>
> Subject: [PATCH] net/vmxnet3: handle bad host framing
>
> The VMXNet3 protocol has a start-of-packet (SOP) and end-of-packet (EOP)
> marker. If there was a bug where mbuf arrived without SOP the code
> that chains the mbuf would dereference a null pointer.
> Also, record any mbuf's dropped in statistics.
>
> Although did the initial code no longer have access to VMware.
> Compile tested only!
>
> Coverity issue: 124563
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
> <Acked-by> Yong Wang <yongwang@vmware.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-14 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 20:40 [dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing Stephen Hemminger
2020-05-13 22:24 ` Yong Wang
2020-05-14 16:15 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).